[Bug 13545] New: Add barcode image generator service
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Bug ID: 13545 Summary: Add barcode image generator service Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35094&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. <img src="/cgi-bin/koha/svc/barcode?barcode=<<items.barcode>>"></img> ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35094|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35095&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. <img src="/cgi-bin/koha/svc/barcode?barcode=<<items.barcode>>"></img> ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35095|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35103&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. <img src="/cgi-bin/koha/svc/barcode?barcode=<<items.barcode>>"></img> ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Brandon <brandon_h27@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35103|0 |1 is obsolete| | --- Comment #4 from Brandon <brandon_h27@hotmail.com> --- Created attachment 35128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35128&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. <img src="/cgi-bin/koha/svc/barcode?barcode=<<items.barcode>>"></img> ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image Signed-off-by: Brandon <brandon_h27@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Brandon <brandon_h27@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brandon_h27@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35128|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35325&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. <img src="/cgi-bin/koha/svc/barcode?barcode=<<items.barcode>>"></img> ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image Signed-off-by: Brandon <brandon_h27@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- It could be great to have a small POD, to know the codes it's possible to use. And maybe should we catch potential errors raised by the last line of the script? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35806&action=edit Bug 13545: (followup) POD and error handling This patch adds POD to the new /svc/barcode service, and also implements some error handling. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm failing this one, even though I attached a followup so the author checks both the followup and the POD I added. It should be clear which barcode 'types' we support, and they should be added to the dependencies if needed. For instance, I'm not sure we might add GD::Barcode to the dependencies. I tried with GD::Barcode:::QRcode and GD::Barcode::UPCE, and it works fine. I tested using an empty barcode number to generate an error. Please revisit and sign if it is ok, but at least the POD should be ammended. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #8)
I'm failing this one, even though I attached a followup so the author checks both the followup and the POD I added.
It should be clear which barcode 'types' we support, and they should be added to the dependencies if needed. For instance, I'm not sure we might add GD::Barcode to the dependencies.
I tried with GD::Barcode:::QRcode and GD::Barcode::UPCE, and it works fine.
I tested using an empty barcode number to generate an error.
Please revisit and sign if it is ok, but at least the POD should be ammended.
All the barcode types are part of the GD::Barcode module with the exception of Code93 which is used by the Canadian postal server. As such, I've left it out of the list for simplicity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35325|0 |1 is obsolete| | Attachment #35806|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35912&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. <img src="/cgi-bin/koha/svc/barcode?barcode=<<items.barcode>>"></img> ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image Signed-off-by: Brandon <brandon_h27@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35913&action=edit Bug 13545: (followup) POD and error handling This patch adds POD to the new /svc/barcode service, and also implements some error handling. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35914&action=edit Bug 13545 [QA Followup] - Complete POD documentation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35914|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35915&action=edit Bug 13545 [QA Followup] - Complete POD documentation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.18 CC| |katrin.fischer@bsz-bw.de Component|Architecture, internals, |Notices |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org