[Bug 16478] New: Translation breaks display of Checkout history in tab Checks / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Bug ID: 16478 Summary: Translation breaks display of Checkout history in tab Checks / On-site-checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt the filter for the tabs 'Checkouts' and 'On-site checkouts' uses text that is exposed to translation. If they are translated, the tabs will be empty on translated pages. (Note: Enable syspref OnSiteCheckuts for testing) See opac-readingrecord.tt line 83ff: [% IF issue.onsite_checkout %] onsite [% ELSE %] checkout [% END %] E.g. in German (/de-DE/modules/opac-readingrecord.tt), it translates to: [% IF issue.onsite_checkout %] vor Ort [% ELSE %] ausgeliehen [% END %] It should be the same as in the English version. A very dirty workaround would be not to translate 'onsite' and 'checkout' in Pootle. Most problably other language will fall into this trap as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 51334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51334&action=edit Screenshots with broken display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51336&action=edit Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts To test: - Make sure that syspref OnsiteCheckouts is enabled - Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled - Go to 'your reading history' (in English) - Display all three tabs - Apply patch - Reload page, display oll three tabs again, there should be no difference - Examine source code changes to verify that the words 'checkout' and 'onsite' no longer will be exposed to translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |veron@veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translation breaks display |Translation breaks display |of Checkout history in tab |of Checkout history in tab |Checks / On-site-checkouts |Checkouts / | |On-site-checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51336|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51337&action=edit Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts To test: - Make sure that syspref OnsiteCheckouts is enabled - Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled - Go to 'your reading history' (in English) - Display all three tabs - Apply patch - Reload page, display oll three tabs again, there should be no difference - Examine source code changes to verify that the words 'checkout' and 'onsite' no longer will be exposed to translation. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51338&action=edit Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51338|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 51342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51342&action=edit Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13234, 10860 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 [Bug 10860] On-site checkouts (was In-House Use) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 [Bug 13234] Make on-site checkouts visible in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the| |Jonathan Druart patch off| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51337|0 |1 is obsolete| | Attachment #51342|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51602&action=edit [PASSED QA] Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts To test: - Make sure that syspref OnsiteCheckouts is enabled - Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled - Go to 'your reading history' (in English) - Display all three tabs - Apply patch - Reload page, display oll three tabs again, there should be no difference - Examine source code changes to verify that the words 'checkout' and 'onsite' no longer will be exposed to translation. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51603&action=edit [PASSED QA] Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.05, thanks Marc, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14568 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org