[Bug 24941] New: Serials: Link to basket in acqusition details is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Bug ID: 24941 Summary: Serials: Link to basket in acqusition details is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com When using 'order from a subscription', acquisition details will show in the serials module on the subscription detail page. The basketnumber is linked, but the URL is broken: http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno= It's missing the basketno parameter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102029&action=edit Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102029|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 102103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102103&action=edit Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Notes for testing (mainly as I'm not that familiar with acquisitions or serials): - An example of the page where the link is not working correctly is for example (using koha-testing-docker): http://127.0.0.1:8081/cgi-bin/koha/serials/subscription-detail.pl?subscripti... - Replace the subscriptionid number with one you have setup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21467 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 679930c8597680a870f7c9801b6dbd40e1254edf Bug 21467: Display a summary line per parent_ordernumber Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 [Bug 21467] Allow several receipts for a given subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102103|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102130&action=edit Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x branch for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org