https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- git bisect points to the cause of the bug and to the solution: Bug 14715, "Results per page dropdown for catalogue search" adds an extra closing </div> tag which I'm assuming breaks the selector for the checkbox because the DOM context is changed. Removing the </div> at line 188 of opac-results.tt fixes the problem for me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102008|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 102145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102145&action=edit Bug 25004: Search results place hold button not enabled when checking result checkboxes on opac-search.pl This patch makes a minor correction to the markup of the OPAC search results page so that the event handlers attached to the checkboxes work correctly. The broken markup broke the jQuery selector used to control the event. An extra </div> was added by mistake by Bug 14715. To test, apply the patch and test the process of selecting multiple titles by checking the checkbox. Doing so should activate the "Place hold" and "Tag" controls. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102145|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 102176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102176&action=edit Bug 25004: Search results place hold button not enabled when checking result checkboxes on opac-search.pl This patch makes a minor correction to the markup of the OPAC search results page so that the event handlers attached to the checkboxes work correctly. The broken markup broke the jQuery selector used to control the event. An extra </div> was added by mistake by Bug 14715. To test, apply the patch and test the process of selecting multiple titles by checking the checkbox. Doing so should activate the "Place hold" and "Tag" controls. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- not needed in 19.11.x branch as https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 was not backported. -- You are receiving this mail because: You are watching all bug changes.