https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21994 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Looking into this a bit further, it's not a straightforward as it first appears. There is no defined delimiter between multiple prefs within a group, so there's no way of knowing where one ends and the next begins. The template just iterates through all entries in a group (or "line" as they're called in the template) whether they're text, form inputs etc. So, we either need to create a delimiter in the preferences/*.pref files to define where one pref in a group ends and the next begins. Or, and this feels like a better solution, stop putting multiple prefs in a single group. As far as I can see, there's no reason for doing this. If we chose the latter option, there would be a small amount of work involved in separating out multiple prefs into their own lines. A quick experiment with patrons.pref, suggests this is all that's required. Setting this bug to "In discussion" in case anyone has any further insight into this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21994 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Well, there's 3 bits of information being requested, the patch I was working when I noticed this added a fourth, which looked *really* messy. But for the example in the screenshot, would it not be better as: Defined a username/login [ ] and a password [ ]. Override from address with [ ] for emails sent using "Email" send driver. I think I've convinced myself that there's no practical reason why these should be grouped together in the same row anyway, regardless of how they're laid out. I think one pref per row is a fairly sane guideline, it will always ensure an easy to read layout and removes the arbitrary nature of the current situation of sometimes grouping prefs into a row and sometimes not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21994 --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin You're absolutely right, it's not particularly clear cut. The thing that really highlighted it for me was my work on Bug 21988, which adds an addition SMS preference. (see attachment) The seemingly obvious thing to do here was to add it to the same row as the existing SMS prefs however, as you can see, that results in a somewhat messy display. I'm not sure what the answer is, other than going through all prefs and breaking up those (such as SMS) that don't look great when occupying the same row. I'm aware it's subjective as to whether anything needs doing at all, but I thought it was worth raising. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21994 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think you are right, we should do it where it make sense, but not overdo it. If you put them under the same heading they will still show up together, but will look less messy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.