https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37911, 38930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 [Bug 37911] Prototype vue islands within static pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38930 [Bug 38930] Add a permissions store for Vue apps -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176877&action=edit Bug 38941: Convert the acquisitions menu to a Vue web component This is an example patch for creating a Vue island component that can be used throughout Koha. The component can then also be used in the work in Bug 38010 to migrate Vendors to Vue. This removes duplication of code by having a .inc file as well as a vue component to maintain Test plan: 1) Apply all patches including dependencies 2) Bug 37911 requires a Vue upgrade so you will need to run yarn install, then run a yarn build 3) Navigate to the acquisitions home page 4) The left menu should appear as before 5) Switch on the EDIFACT syspref - the acq menu should now display the edifact related options 6) Try logging in as a new patron with reduced permissions, the menu should update correctly according to the permissions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- This is a POC - interested to hear any ideas for improvement. I considered using the NavigationItem component to render the links but it changes the HTML structure slightly and is largely dependent on the Vue router -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176878|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178244&action=edit Bug 38941: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Janne, this bug has 2 dependencies that are not resolved yet. The sandboxes are not very clear when there is a conflict on applying the patches. Maybe have a look at the git log if you can. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178244|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181491&action=edit Bug 38941: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178243|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181492&action=edit Bug 38941: Convert the acquisitions menu to a Vue web component This is an example patch for creating a Vue island component that can be used throughout Koha. The component can then also be used in the work in Bug 38010 to migrate Vendors to Vue. This removes duplication of code by having a .inc file as well as a vue component to maintain Test plan: 1) Apply all patches including dependencies 2) Bug 37911 requires a Vue upgrade so you will need to run yarn install, then run a yarn build 3) Navigate to the acquisitions home page 4) The left menu should appear as before 5) Switch on the EDIFACT syspref - the acq menu should now display the edifact related options 6) Try logging in as a new patron with reduced permissions, the menu should update correctly according to the permissions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181626&action=edit Bug 38941: Rebase for follow-up to bug 37911 Bug 37911 added a follow-up that removed the original entry point from rspack to use the esm.js files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181493|0 |1 is obsolete| | --- Comment #13 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 181628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181628&action=edit Bug 38941: Add a cypress test Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181628|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181711&action=edit Bug 38941: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181627|0 |1 is obsolete| | Attachment #181629|0 |1 is obsolete| | Attachment #181711|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181724&action=edit Bug 38941: Convert the acquisitions menu to a Vue web component This is an example patch for creating a Vue island component that can be used throughout Koha. The component can then also be used in the work in Bug 38010 to migrate Vendors to Vue. This removes duplication of code by having a .inc file as well as a vue component to maintain Test plan: 1) Apply all patches including dependencies 2) Bug 37911 requires a Vue upgrade so you will need to run yarn install, then run a yarn build 3) Navigate to the acquisitions home page 4) The left menu should appear as before 5) Switch on the EDIFACT syspref - the acq menu should now display the edifact related options 6) Try logging in as a new patron with reduced permissions, the menu should update correctly according to the permissions Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181726&action=edit Bug 38941: Rebase for follow-up to bug 37911 Bug 37911 added a follow-up that removed the original entry point from rspack to use the esm.js files Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA script FAIL koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc FAIL filters missing_filter at line 25 ([% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 %] <script src="[% islands %]" type="module">) missing_filter at line 28 ( import { hydrate } from "[% islands %]";) I fixed it with the automated script in a separate commit. Please check! 2) Question about permission check We have this here, which appears to be a bit of a double up on first glance - do we need this in order to over both TT and vue cases where the menu is used? + suggestionscreate="[% CAN_user_suggestions_suggestions_create | html %]" + suggestionsmanage="[% CAN_user_suggestions_suggestions_manage | html %]" + suggestionsdelete="[% CAN_user_suggestions_suggestions_delete | html %]" And then: + v-if=" + suggestionscreate || + suggestionsmanage || + suggestionsdelete || + isUserPermitted( + 'CAN_user_suggestions_suggestions_create' + ) || + isUserPermitted( + 'CAN_user_suggestions_suggestions_manage' + ) || + isUserPermitted('CAN_user_suggestions_suggestions_delete') + " + > -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- Little question... I notice this bug depends on bug 38930, but then we're using Template::Toolkit to set attributes mapped to permissions on the acquisitions-menu web component. Looking again at the template, it looks like some parts of the template use the permission store from bug 38930 and some use the attributes/properties for the web component? Seems like it's only half-implemented here? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Matt Blenkinsop from comment #24)

the component that is used in the custom element can be used either as a Vue custom element in template toolkit or as a component in a Vue application. When used in a Vue app we get access to the pinia stores (permissionsStore) and can use the method provided by the permissionsStore to check permissions. Outside of a vue app however, we don't get access to a populated permissionsStore so we need to be able to accept the permissions from the template toolkit variables as component props

Looking back at the patch again, I see that it does support both methodologies for all cases. On first read, I thought it was using one methodology in one place and the other methodology in other places. My bad! That said, can you explain things more? In the case of acquisitions menu, it looks like you do have access to the pinia stores, but that it's just not being populated? It also looks like it gets mounted as a single component Vue app in the end? Looking at bug 38930, it looks like the permissionsStore is not used anywhere currently? There's the ERM example which shows an ERM-specific implementation for using the permissionsStore, but that seems suboptimal. When I first heard of bug 38930, I thought it was going to introduce a core API endpoint for fetching current user details and then put the permissions in the permissionsStore for use by Vue components. Even outside of Vue, I reckon having an API endpoint to fetch that information would be useful. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- (In reply to Matt Blenkinsop from comment #26)

Its currently being used by the Vendors Vue module -

Ah I see it now. Both the dependency chain in Bugzilla and the import of ./Islands/AcquisitionsMenu.vue in koha-tmpl/intranet-tmpl/prog/js/vue/components/LeftMenu.vue.

when the acquisitions menu is loaded as part of the vendors vue app we have access to the permissions store as it is populated by the module's config endpoint and the menu is just used as a generic vue component rather than a custom element.

I see what you mean when looking at /cgi-bin/koha/acqui/acqui-home.pl vs /cgi-bin/koha/acquisition/vendors?supplier=

When it is used as a custom element, the permissionsStore is technically available but isn't populated as there is no specific vue app with a config endpoint to populate from. A future enhancement could certainly be to update the permissions store to self-populate and remove the need for the TT variables

I reckon that would be a much more DRY option for sure. Anyway, cool beans. Thanks for explaining all that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #28 from David Nind <david@davidnind.com> --- Architecture change, no change to the UI, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.