[Bug 20724] New: ReservesNeedReturns syspref breaks "Holds awaiting pickup"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Bug ID: 20724 Summary: ReservesNeedReturns syspref breaks "Holds awaiting pickup" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com == Summary == waitingreserves.pl crashes when expirationdate is null. And ReservesNeedReturns has a regression causing expirationdate to be null. == Reproduce == 1. Set ReservesNeedReturns to "Don't automatically" 2. Place a hold on a specific item 3. Check it in and confirm hold 4. The hold should have an expiration date record page → Hold → "Expiration" column 5. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 6. Set ReservesNeedReturns to "Automatically" 7. Place a hold on a specific item (which should also behave like we check the item in to keep it for the patron) 8. The hold should have an empty expiration date record page → Hold → "Expiration" column 9. Holds awaiting pickup page should crash staff:/cgi-bin/koha/circ/waitingreserves.pl === Affected versions === Bug on master and 17.11. Works on 16.11, date isn't null -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |12063 Severity|major |critical --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It has been caused by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures Commit message says: - remove expiration date calculation in circ/waitingreserves.pl. Use the one in DB, Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 [Bug 12063] Change date calculation for reserve expiration to skip all holidays -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not think it's link to ReservesNeedReturns, it happens when no expiration date is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #2)
I do not think it's link to ReservesNeedReturns, it happens when no expiration date is selected.
Forget that, it's linked to this pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75211&action=edit Bug 20724: Try to fix ReservesNeedReturns wrong behaviour We need to call Koha::Hold->set_waiting to correctly calculate the expiration date. It fixes a regression introduced by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures The expiration date has to be set for waiting holds TODO: same fix has to be provided for the OPAC side TODO LATER: We certainly should move code from controllers to Koha::Hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|NEW |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That does not seem the best way to fix this issue but should work. Could you confirm? Which regressions possible? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 75219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75219&action=edit Bug 20724 [Alternate]: Try to fix ReservesNeedReturns wrong behaviour We need to call Koha::Hold->set_waiting to correctly calculate the expiration date. It fixes a regression introduced by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures The expiration date has to be set for waiting holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75211|0 |1 is obsolete| | Attachment #75219|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75221&action=edit Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns We need to call Koha::Hold->set_waiting to correctly calculate the expiration date. It fixes a regression introduced by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures The expiration date has to be set for waiting holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75222&action=edit Bug 20724: Move the ReservesNeedReturns logic to AddReserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75223&action=edit Bug 20724: Add tests for ReservesNeedReturns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|victor.grousset@biblibre.co |jonathan.druart@bugs.koha-c |m |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75221|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 75307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75307&action=edit Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns We need to call Koha::Hold->set_waiting to correctly calculate the expiration date. It fixes a regression introduced by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures The expiration date has to be set for waiting holds == Test plan (time to execute: less than 4min) == 1. Set ReservesNeedReturns to "Don't automatically" 2. Place a hold on a specific item 3. Check it in and confirm hold 4. The hold should have an expiration date record page → Hold → "Expiration" column 5. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 6. Set ReservesNeedReturns to "Automatically" 7. Place a hold on a specific item (which should also behave like we check the item in to keep it for the patron) 8. The hold should have an *empty* expiration date record page → Hold → "Expiration" column 9. Holds awaiting pickup page should crash staff:/cgi-bin/koha/circ/waitingreserves.pl 10. Cancel the hold to remove the corrupted data record page → Hold → the red X 11. Apply this patch 12. Place a hold on a specific item 13. The hold should have an expiration date (not empty) 14. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 15. Celebrate! Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75222|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 75308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75308&action=edit Bug 20724: Move the ReservesNeedReturns logic to AddReserve Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75223|0 |1 is obsolete| | --- Comment #12 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 75309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75309&action=edit Bug 20724: Add tests for ReservesNeedReturns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75309|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 75325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75325&action=edit Bug 20724: Add tests for ReservesNeedReturns Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- - Added a test plan - Confirmed that the patch works - Ran the tests - with the patches to ensure that they pass - and without the patches to ensure that the test are actually testing something -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #15 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- == Going further: existing data == This bug creates corrupted data that will still break the page. (waiting reserves with a NULL expirationdate) What do we do in these case? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- could we recalculate the expiration date for waiting items using the timestamp and ReservesMaxPickupDelay value? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #17 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Same bug or followup? So the patch will be quickly released to at least avoid generating corrupted data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If it's just a little database update I'd put it here I think. I can sign off this afternoon if noone else is faster. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, might be a little more complicated if you want the absolute correct date (with/without holidays). So we'd need to do what the code should have done? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #20 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Katrin Fischer from comment #18)
If it's just a little database update I'd put it here I think.
+1 (In reply to Katrin Fischer from comment #19)
Hm, might be a little more complicated if you want the absolute correct date (with/without holidays). So we'd need to do what the code should have done?
Most of the existing corrupted data[1] should be in the past so it will be expired anyway. Is that correct? Is yes then no need to worry about making an accurate correction. [1] And there is not much considering that it hasn't been reported until now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #21 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Posting the error here so someone searching for it will find this bug. Date::Calc::Date_to_Days(): not a valid date at /home/koha/src/circ/waitingreserves.pl line 122. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure how big of a problem it is, but it probably depends on how long a library allows for items to be picked up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) { AddReserve( $branch, $borrower->{'borrowernumber'}, $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title, $checkitem, $found, $itemtype ); } Horrible existing code with realbi and holds_to_place_count.. Also checkitem is passed to AddReserve each time in a for loop with biblionumbers. (It should be undef but you never know..) Note that the second patch removes $holds_to_place_count = 1. So lots of distraction here again with holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This might affect C4/ILSDI/Services.pm => One of the calls includes an itemnumber. Note that the code did not contain a reference to ReservesNeedsReturns. Koha/REST/V1/Hold.pm is also affected => Includes an itemnumber. Note that the code did not contain a reference to ReservesNeedsReturns. C4/SIP/ILS/Transaction/Hold.pm is NOT affected (no item number) serials/routing-preview.pl is not affected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75307|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75363&action=edit Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns We need to call Koha::Hold->set_waiting to correctly calculate the expiration date. It fixes a regression introduced by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures The expiration date has to be set for waiting holds == Test plan (time to execute: less than 4min) == 1. Set ReservesNeedReturns to "Don't automatically" 2. Place a hold on a specific item 3. Check it in and confirm hold 4. The hold should have an expiration date record page → Hold → "Expiration" column 5. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 6. Set ReservesNeedReturns to "Automatically" 7. Place a hold on a specific item (which should also behave like we check the item in to keep it for the patron) 8. The hold should have an *empty* expiration date record page → Hold → "Expiration" column 9. Holds awaiting pickup page should crash staff:/cgi-bin/koha/circ/waitingreserves.pl 10. Cancel the hold to remove the corrupted data record page → Hold → the red X 11. Apply this patch 12. Place a hold on a specific item 13. The hold should have an expiration date (not empty) 14. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 15. Celebrate! Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75308|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75364&action=edit Bug 20724: Move the ReservesNeedReturns logic to AddReserve Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75325|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75365&action=edit Bug 20724: Add tests for ReservesNeedReturns Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75366&action=edit Bug 20724: (QA follow-up) Remove two obsolete comment lines No test plan :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75367&action=edit Bug 20724: (QA follow-up) Add a simple db revision We should correct bad data too. This is a trivial, pragmatic approach. Instead of doing a complex calculation with holidays etc. (as was done on 12063), we just add MaxPickupDelay or 7 days to today probably resulting in a little bonus time. Only for waiting holds. When the ReservesNeedReturns pref was not Automatic, there should be no changes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- With previous comments in mind, balance goes to Passed QA for this patch set. Added a simple db rev (we should imo). @RM: If you want to refine, please do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 [Bug 20773] bug 20724 follow-up - Database cleanup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75367|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 75367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75367 Bug 20724: (QA follow-up) Add a simple db revision Moved to bug 20773. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #34 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #35 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org