https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Bug ID: 20724 Summary: ReservesNeedReturns syspref breaks "Holds awaiting pickup" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com == Summary == waitingreserves.pl crashes when expirationdate is null. And ReservesNeedReturns has a regression causing expirationdate to be null. == Reproduce == 1. Set ReservesNeedReturns to "Don't automatically" 2. Place a hold on a specific item 3. Check it in and confirm hold 4. The hold should have an expiration date record page → Hold → "Expiration" column 5. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 6. Set ReservesNeedReturns to "Automatically" 7. Place a hold on a specific item (which should also behave like we check the item in to keep it for the patron) 8. The hold should have an empty expiration date record page → Hold → "Expiration" column 9. Holds awaiting pickup page should crash staff:/cgi-bin/koha/circ/waitingreserves.pl === Affected versions === Bug on master and 17.11. Works on 16.11, date isn't null -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.