[Bug 34052] New: Incomplete relative URL to subscription-detail.pl breaks navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Bug ID: 34052 Summary: Incomplete relative URL to subscription-detail.pl breaks navigation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org On the serials-collection.pl page, there is a same-directory relative link to "subscription-detail.pl" under the "Subscription num." column. Most of the time this isn't a problem, but when you delete a serial, it sends you to a URL like this: http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl/?op=delete_confirmed&biblionumber=1&subscriptionid=1&serialid=1# That relative URL will be interpreted as the following: http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl/subscriptio... Instead of generating an error, this actually loads the http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl page. The /subscription-detail.pl would be just added to the PATH_INFO on the server. The solution is to use a root-relative URL like we do everywhere else (e.g. /cgi-bin/koha/serials/subscription-detail.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 152459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152459&action=edit Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152459|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152493&action=edit Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152493|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152591&action=edit Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incomplete relative URL to |Fix link to subscription |subscription-detail.pl |from serial collection page |breaks navigation | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Technically the bug description was correct, but I think we can make it a little more telling to users :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152591|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152592&action=edit Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org