[Bug 34015] New: Terminology: Relative issues should be Relative's checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Bug ID: 34015 Summary: Terminology: Relative issues should be Relative's checkouts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I found this string while translating. It seems to be a string for screen readers only. But I think it should still follow terminology. The string is in opac-user.tt, around line 670. <caption class="sr-only">Relative issues</caption> It's for the tab that shows Relatives' checkouts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 152384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152384&action=edit Bug 34015 - Terminology: Relative issues should be Relative's checkouts This patch changes the term 'issues' in a screen reader caption in the OPAC to the correct term 'checkouts'. To test: Setup: - Have a patron with a guarantee - Check out an item to the guarantee - Make sure the guarantee allows their guarantor to see their checkouts (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to be able to set this) 1. In the OPAC, log in with the guarantor patron 2. Click on the Relatives' checkouts tab 3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off) 4. Navigate to the table in the Relative's checkouts tab --> The screen reader should say 'Relative issue table with...' 5. Apply patch 6. Refresh the page 7. Restart the screen reader (if it was off) --> The screen reader should now say 'Relatives' checkouts table with...' Alternatively, open the page inspector and inspect the table, the caption is in the table tag, before the thead tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|oleonard@myacpl.org |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152384|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152387&action=edit Bug 34015: Terminology: Relative issues should be Relative's checkouts This patch changes the term 'issues' in a screen reader caption in the OPAC to the correct term 'checkouts'. To test: Setup: - Have a patron with a guarantee - Check out an item to the guarantee - Make sure the guarantee allows their guarantor to see their checkouts (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to be able to set this) 1. In the OPAC, log in with the guarantor patron 2. Click on the Relatives' checkouts tab 3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off) 4. Navigate to the table in the Relative's checkouts tab --> The screen reader should say 'Relative issue table with...' 5. Apply patch 6. Refresh the page 7. Restart the screen reader (if it was off) --> The screen reader should now say 'Relatives' checkouts table with...' Alternatively, open the page inspector and inspect the table, the caption is in the table tag, before the thead tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152387|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152586&action=edit Bug 34015: Terminology: Relative issues should be Relative's checkouts This patch changes the term 'issues' in a screen reader caption in the OPAC to the correct term 'checkouts'. To test: Setup: - Have a patron with a guarantee - Check out an item to the guarantee - Make sure the guarantee allows their guarantor to see their checkouts (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to be able to set this) 1. In the OPAC, log in with the guarantor patron 2. Click on the Relatives' checkouts tab 3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off) 4. Navigate to the table in the Relative's checkouts tab --> The screen reader should say 'Relative issue table with...' 5. Apply patch 6. Refresh the page 7. Restart the screen reader (if it was off) --> The screen reader should now say 'Relatives' checkouts table with...' Alternatively, open the page inspector and inspect the table, the caption is in the table tag, before the thead tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried to find other similar strings in the templates, but couldn't find any. Thx Caroline! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34015 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org