[Bug 40225] New: The --send-all option in the stockrotation job fails if there are no items to rotate at all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Bug ID: 40225 Summary: The --send-all option in the stockrotation job fails if there are no items to rotate at all Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The send-all option claims to send notices even if there are no items to rotate for the given branch; However, if there are no items to action anywhere on the system we skip all notices entirely, not respecting the send-all option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183444&action=edit Bug 40225: Check stationary items for stockrotation We should send the report even if all items are stationary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183445&action=edit Bug 40225: Send stockrotation report even when all items are stationary The stockrotation cronjob was only sending email reports when there were actionable items (items that needed to be moved between branches). This meant that libraries would not receive any notification when all items in their rotation were stationary, even when the --send-all flag was passed to the script. This patch modifies the report logic to also send reports when there are only stationary items, ensuring libraries have visibility into the complete status of their stock rotation items. Test plan: 1. Set up a stock rotation rota with items that are all stationary (items that should stay at their current branch) 2. Run the stockrotation cronjob: perl misc/cronjobs/stockrotation.pl 3. Without this patch: No email report is generated 4. Apply this patch 5. Run the cronjob again 6. Verify that an email report is now generated showing the stationary items 7. Test with mixed scenarios (some actionable, some stationary items) 8. Confirm reports are sent in all cases where items exist in the rotation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Automated patch testing results: [PASS] ALL PATCHES APPLY CLEANLY All patches apply successfully to the current codebase. **Patch Results:** [PASS] Bug-40225-Send-stockrotation-report-even-when-all-.patch (ID: 183445) Status: SUCCESS + Patch applies cleanly --- This is an automated message from the patch testing system. Tested against branch: main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 197109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197109&action=edit Bug 40225: Send stockrotation report even when all items are stationary The stockrotation cronjob was only sending email reports when there were actionable items (items that needed to be moved between branches). This meant that libraries would not receive any notification when all items in their rotation were stationary, even when the --send-all flag was passed to the script. This patch modifies the report logic to also send reports when there are only stationary items, ensuring libraries have visibility into the complete status of their stock rotation items. Test plan: 1. Set up a stock rotation rota with items that are all stationary (items that should stay at their current branch) 2. Run the stockrotation cronjob: perl misc/cronjobs/stockrotation.pl 3. Without this patch: No email report is generated 4. Apply this patch 5. Run the cronjob again 6. Verify that an email report is now generated showing the stationary items 7. Test with mixed scenarios (some actionable, some stationary items) 8. Confirm reports are sent in all cases where items exist in the rotation Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200459&action=edit Bug 40225: Send stockrotation report even when all items are stationary The stockrotation cronjob was only sending email reports when there were actionable items (items that needed to be moved between branches). This meant that libraries would not receive any notification when all items in their rotation were stationary, even when the --send-all flag was passed to the script. This patch modifies the report logic to also send reports when there are only stationary items, ensuring libraries have visibility into the complete status of their stock rotation items. Test plan: 1. Set up a stock rotation rota with items that are all stationary (items that should stay at their current branch) 2. Run the stockrotation cronjob: perl misc/cronjobs/stockrotation.pl 3. Without this patch: No email report is generated 4. Apply this patch 5. Run the cronjob again 6. Verify that an email report is now generated showing the stationary items 7. Test with mixed scenarios (some actionable, some stationary items) 8. Confirm reports are sent in all cases where items exist in the rotation Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.02 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40225 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.11.00,26.05.02 |26.11.00,26.05.02,25.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org