https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 192970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192970&action=edit Bug 41070: Fix selector in addorderiso validator -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192971|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 192973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192973&action=edit Bug 41070: Fix selector in addorderiso validator Steps to reproduce, do not apply patch 1 - Go to any record and click save -> marc (Unicode/utf8) 2 - Go to any vendor and add a basket 3 - In your acquisition grid, make sure "barcode" is mandatory 4 - In this basket, create a new order from file, use the generated file and wait for the end of the import. Click on add staged files to basket. 5 - Select the record, make sure no Fund or barcode is filled, neither in first or third tab. 6 - Validate: There will be an error due to the missing barcode. If there is another error, fill the missing part of the form. 7 - Apply patch, repeat 6, the error will be due to the missing fund 8 - Select a fund in the first panel -> the error will be due to the missing barcode 9 - Select a fund in the third panel -> the error will be due to the missing barcode Note: the point about the barcode are not relevant for the bug, they are just here to prevent the submission of the form. And avoid repeating steps 4-5. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192973|0 |1 is obsolete| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 192979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192979&action=edit Bug 41070: Fix selector in addorderiso validator Steps to reproduce, do not apply patch 1 - Go to any record and click save -> marc (Unicode/utf8) 2 - Go to any vendor and add a basket 3 - In your acquisition grid, make sure "barcode" is mandatory 4 - In this basket, create a new order from file, use the generated file and wait for the end of the import. Click on add staged files to basket. 5 - Select the record, make sure no Fund or barcode is filled, neither in first or third tab. 6 - Validate: There will be an error due to the missing barcode. If there is another error, fill the missing part of the form. 7 - Apply patch, repeat 6, the error will be due to the missing fund 8 - Select a fund in the first panel -> the error will be due to the missing barcode 9 - Select a fund in the third panel -> the error will be due to the missing barcode Note: the point about the barcode are not relevant for the bug, they are just here to prevent the submission of the form. And avoid repeating steps 4-5. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi, You can do what you want actually, the purpose of the barcode is to avoid being redirected while submitting the form. The point is to be able to perform 8 and 9 without having the form being submitted. As long as you have no item creation and you are able to see the error, this is fine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue when release notes| |adding an order to a basket | |using the "From a new file" | |option. | | | |When adding an order from | |the staged file there was | |no warning if you didn't | |select the fund in either | |the "Select to import" or | |"Default accounting | |details" tabs. | | | |Now there is a warning if | |you don't select a fund: | |"Some funds are not defined | |in item records". --- Comment #9 from David Nind <david@davidnind.com> --- The patch still applies, and I have signed it off. Note that both the fund fields in the "Add orders from ...." page have instructions about what will be used if a fund is not selected (I don't know how to do either of these things, so can't check what happens if these are set): - Select to import tab: . Fund: Select a fund (will use default if set) - Default accounting details tab: . Fund: Select a fund (will populate orders/items if set) Does that mean that making selecting a fund shouldn't generate a warning? Testing notes: 1. Exported Programming Perl with item (biblionumber = 262). 2. Instead of step 3, I didn't do anything. Later on (steps 4-6) the "Koha item type" field is mandatory in the "Item information" tab and is not pre-polulated (in a MARC21 KTD instance). 3. Step 6: If you don't populate the "Koha item type" file in the "Item information" tab, a browser pop-up error/warning message is shown with "Some required item subfields are not set". 4. After applying the patch (step 7) and restarting everything, I also cleared the browser cache. (Which means cleaning and deleting the importing batch, and starting again.) I did this, otherwise I didn't get the pop-up 5. The browser pop-up message is "Some funds are not defined in item records". Note that the qa script complains about tidiness: qa Tag v25.05.00-1 found in /kohadevbox/koha — checking out branch main in /kohadevbox/qa-test-tools Already on 'main' Your branch is up to date with 'origin/main'. testing 1 commit(s) (applied to a81b2cf '4f Bug 16994: (QA follow-up) Align ov') Processing files [RUNNING] koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js Result: [FAIL] koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js` Processing additional checks PASS! * Was this bug sponsored by anyone? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200460&action=edit Bug 41070: Fix selector in addorderiso validator Steps to reproduce, do not apply patch 1 - Go to any record and click save -> marc (Unicode/utf8) 2 - Go to any vendor and add a basket 3 - In your acquisition grid, make sure "barcode" is mandatory 4 - In this basket, create a new order from file, use the generated file and wait for the end of the import. Click on add staged files to basket. 5 - Select the record, make sure no Fund or barcode is filled, neither in first or third tab. 6 - Validate: There will be an error due to the missing barcode. If there is another error, fill the missing part of the form. 7 - Apply patch, repeat 6, the error will be due to the missing fund 8 - Select a fund in the first panel -> the error will be due to the missing barcode 9 - Select a fund in the third panel -> the error will be due to the missing barcode Note: the point about the barcode are not relevant for the bug, they are just here to prevent the submission of the form. And avoid repeating steps 4-5. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41070 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.02 |26.11.00,26.05.02,25.11.08 released in| | --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.