[Bug 20372] New: Correct toolbar markup on some pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Bug ID: 20372 Summary: Correct toolbar markup on some pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are a few instances of div#toolbar which contain markup which isn't consistent with most other examples. This can cause problems with CSS styles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72680&action=edit Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72682&action=edit Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72682|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72687&action=edit Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72687|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72708&action=edit Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of <div id="toolbar"></div> To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, backported to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for 17.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org