[Bug 20376] New: "Select all" button no longer selects disabled checkboxes in Batch Record Deletion Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Bug ID: 20376 Summary: "Select all" button no longer selects disabled checkboxes in Batch Record Deletion Tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Tools Assignee: maksim.sen@inlibro.com Reporter: maksim.sen@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: philippe.blouin@inlibro.com This fix restricts the "Select all" (as well as the "Clear all") button from changing the "checked" status of disabled checkboxes in the Batch Record Deletion Tool. Patch and test plan will be added shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 --- Comment #1 from Maksim Sen <maksim.sen@inlibro.com> --- Created attachment 72726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72726&action=edit Bug 20376: Select all ignores disabled checkboxes Test Plan: 0.1 - find at least one biblionumber that has at least one item checked out 0.2 - find at least one biblionumber that has zero items checked out. 1 - Go into the module "Tools > Batch record deletion" 2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2 3 - click continue 4 - biblionumbers with at least one item checked out should not be clickable. 5 - biblionumbers with zero items checked out should be clickable. 6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes. 7 - apply patch 8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by JM Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72774&action=edit Bug 20376: Select all ignores disabled checkboxes Test Plan: 0.1 - find at least one biblionumber that has at least one item checked out 0.2 - find at least one biblionumber that has zero items checked out. 1 - Go into the module "Tools > Batch record deletion" 2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2 3 - click continue 4 - biblionumbers with at least one item checked out should not be clickable. 5 - biblionumbers with zero items checked out should be clickable. 6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes. 7 - apply patch 8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes. Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72774|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72797&action=edit Bug 20376: Make select/unselect all ignore disabled checkboxes on batch record deletion Test Plan: 0.1 - find at least one biblionumber that has at least one item checked out 0.2 - find at least one biblionumber that has zero items checked out. 1 - Go into the module "Tools > Batch record deletion" 2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2 3 - click continue 4 - biblionumbers with at least one item checked out should not be clickable. 5 - biblionumbers with zero items checked out should be clickable. 6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes. 7 - apply patch 8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes. Signed-off-by: JM Broust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to master for 18.05 Thanks Maksim for your first patch in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, backported to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for 17.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org