[Bug 32679] New: CSS class article-request-title is doubled up in article requests list in OPAC patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Bug ID: 32679 Summary: CSS class article-request-title is doubled up in article requests list in OPAC patron account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The CSS class article-request-title is used for the title of the host and also for the column with the article title. So if you are not careful, things will get mixed up. The classes for 2 different things should be differently named. * Activate article requests in system preferences * Make sure article requests are allowed in circulation conditions * Make an article request for a record in the OPAC * Check the display in the patron account for the article request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is already fixed in master on the OPAC side: <td class="article-request-record-title"> [% INCLUDE 'biblio-title.inc' biblio=ar.biblio link=> 1 %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de Summary|CSS class |CSS class |article-request-title is |article-request-title is |doubled up in article |doubled up in article |requests list in OPAC |requests list in staff |patron account |patron account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145511&action=edit Bug 32679: Use different CSS classes for titles of article requests in staff interface The class article-request-title was used for the column with the article title as well as for the link with the record title. This could cause some confusion when changing the table with CSS. This patch makes it so different CSS classes are used for each. To test: * Activate article requests in system preferences * Make sure circulation conditions have article requets = yes * Create an article request in staff or OPAC * View the list of article requests in the patron account in staff * Add the following line to IntranetUserCSS: .article-request-title { display:none; } * Verify the Title column and the title from Record title (first column) have vanished. * Apply patch: now only the column should vanish, Record title shoudl remain visible * If you want: Verify that the record title has a differently named class now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: I pondered also using biblio-title.inc here, but in the patron account the title links to the article request page and not to the detail page. I didn't find a way to do that using the include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145511|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145515&action=edit Bug 32679: Use different CSS classes for titles of article requests in staff interface The class article-request-title was used for the column with the article title as well as for the link with the record title. This could cause some confusion when changing the table with CSS. This patch makes it so different CSS classes are used for each. To test: * Activate article requests in system preferences * Make sure circulation conditions have article requets = yes * Create an article request in staff or OPAC * View the list of article requests in the patron account in staff * Add the following line to IntranetUserCSS: .article-request-title { display:none; } * Verify the Title column and the title from Record title (first column) have vanished. * Apply patch: now only the column should vanish, Record title shoudl remain visible * If you want: Verify that the record title has a differently named class now. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145515|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147216&action=edit Bug 32679: Use different CSS classes for titles of article requests in staff interface The class article-request-title was used for the column with the article title as well as for the link with the record title. This could cause some confusion when changing the table with CSS. This patch makes it so different CSS classes are used for each. To test: * Activate article requests in system preferences * Make sure circulation conditions have article requets = yes * Create an article request in staff or OPAC * View the list of article requests in the patron account in staff * Add the following line to IntranetUserCSS: .article-request-title { display:none; } * Verify the Title column and the title from Record title (first column) have vanished. * Apply patch: now only the column should vanish, Record title shoudl remain visible * If you want: Verify that the record title has a differently named class now. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.11 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backpoprted to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04,22.05.11 |23.05.00,22.11.04,22.05.11, released in| |21.11.19 Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |arthur.suzuki@biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org