[Bug 33155] New: Category and library filters from header patron search not taken into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Bug ID: 33155 Summary: Category and library filters from header patron search not taken into account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 7380 Caused by commit f1925cf89dbc1039fc48abfabad1472289387148 Bug 7380: Rename filter to avoid confusion [% IF categorycode %] - $("#categorycode_filter").val("[% categorycode %]"); + $("#categorycode_filter").val("[% categorycode_filter %]"); [% END %] [% IF branchcode %] - $("#branchcode_filter").val("[% branchcode %]"); + $("#branchcode_filter").val("[% branchcode_filter %]"); [% END %] Forgot to rename the vars in the IF statements Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 [Bug 7380] Can't filter patron search on detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147834&action=edit Bug 33155: Fix category and library filters in patron search header Caused by commit f1925cf89dbc1039fc48abfabad1472289387148 Bug 7380: Rename filter to avoid confusion [% IF categorycode %] - $("#categorycode_filter").val("[% categorycode %]"); + $("#categorycode_filter").val("[% categorycode_filter %]"); [% END %] [% IF branchcode %] - $("#branchcode_filter").val("[% branchcode %]"); + $("#branchcode_filter").val("[% branchcode_filter %]"); [% END %] Forgot to rename the vars in the IF statements Test plan: Go to the Koha mainpage Click "Search patrons" in the headers Open the filters Select something for library and category, search => The values must be picked for the patron search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147834|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147836&action=edit Bug 33155: Fix category and library filters in patron search header Caused by commit f1925cf89dbc1039fc48abfabad1472289387148 Bug 7380: Rename filter to avoid confusion [% IF categorycode %] - $("#categorycode_filter").val("[% categorycode %]"); + $("#categorycode_filter").val("[% categorycode_filter %]"); [% END %] [% IF branchcode %] - $("#branchcode_filter").val("[% branchcode %]"); + $("#branchcode_filter").val("[% branchcode_filter %]"); [% END %] Forgot to rename the vars in the IF statements Test plan: Go to the Koha mainpage Click "Search patrons" in the headers Open the filters Select something for library and category, search => The values must be picked for the patron search Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Trivial fix, PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.11 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 32651 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- This is on 21.11 Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org