[Bug 5304] New: Too many post find queries for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Summary: Too many post find queries for items Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 C4::Items::GetItemsInfo(): When the items resultset is returned from the search, lots of additional queries are requested for each item in order ti get extra data. This makes large resultsets extremely slow to return. Proposed solution: Rewrite items query so it returns all relevant data at once -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |srdjan@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2010-10-18 21:29:27 UTC --- Created attachment 2692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2692 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2692|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> 2010-10-18 21:51:57 UTC --- Disregard patch, has a nasty bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-11-10 08:49:34 UTC --- This bug is mentioned in: bug 5304: GetItemsInfo() - optimise query http://lists.koha-community.org/pipermail/koha-patches/2010-October/012696.h... bug 5304: GetItemsInfo() - optimise query http://lists.koha-community.org/pipermail/koha-patches/2010-October/012697.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |ian.walls@bywatersolutions. | |com Version|unspecified |master --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-06 16:51:37 UTC --- Increasing the importance on this, as fixing this will improve performance. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 29596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29596&action=edit Use branch codes from the database rather than hardcoded CPL and MPL -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 29597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29597&action=edit bug_5304: GetItemsInfo() - moved issues and serials query from the results loop to the main query -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Testing: Biblio details pages with items need to be visited for regression check, eg opac-detail.pl and ./catalogue/detail.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29596|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29606&action=edit [SIGNED-OFF] Bug 5304: Use branch codes from the database rather than hardcoded CPL and MPL http://bugs.koha-community.org/show_bug.cgi?id=5304 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No commit message No test plan. prove t/db_dependent/Items.t pass No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29597|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29607&action=edit [SIGNED-oFF] Bug 5304: GetItemsInfo() - moved issues and serials query from the results loop to the main query Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No commit message No test plan. No regressions found on opac/staff item display No improvements either, but could be just my test data No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #10 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I forgot to add - it may be worth changing GetItemsInfo() return value to an arrayref instead of array. No big deal for biblios with a small number of items, but makes huge difference for serials with hundreds. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29606|0 |1 is obsolete| | Attachment #29607|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29629&action=edit [PASSED QA] Bug 5304: Use branch codes from the database rather than hardcoded CPL and MPL http://bugs.koha-community.org/show_bug.cgi?id=5304 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No commit message No test plan. prove t/db_dependent/Items.t pass No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29630&action=edit [PASSED QA] [PASSED QA] Bug 5304: GetItemsInfo() - moved issues and serials query from the results loop to the main query Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No commit message No test plan. No regressions found on opac/staff item display No improvements either, but could be just my test data No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29630|[PASSED QA] [PASSED QA] Bug |[PASSED QA] Bug 5304: description|5304: GetItemsInfo() - |GetItemsInfo() - moved |moved issues and serials |issues and serials query |query from the results loop |from the results loop to |to the main query |the main query CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29631&action=edit Bug 5304: GetItemsInfo should return arrayref instead of array -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #13)
Bug 5304: GetItemsInfo should return arrayref instead of array
This needs a test plan please. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #15 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Kyle, that patch sort of defies purpose: my @items = @{ GetItemsInfo( $biblionumber ) }; copies the array, and the idea was to avoid that (see my comment 10). I propose we drop that patch from this ticket, let other two patches go, and open another one for this specific issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29631|1 |0 is patch| | Attachment #29631|0 |1 is obsolete| | CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29629|0 |1 is obsolete| | Attachment #29630|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32722&action=edit [PASSED QA] Bug 5304: Use branch codes from the database rather than hardcoded CPL and MPL http://bugs.koha-community.org/show_bug.cgi?id=5304 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No commit message No test plan. prove t/db_dependent/Items.t pass No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32723&action=edit [PASSED QA] Bug 5304: GetItemsInfo() - moved issues and serials query from the results loop to the main query Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No commit message No test plan. No regressions found on opac/staff item display No improvements either, but could be just my test data No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Passes tests and QA script. Tested detail and item pages in OPAC and staff, no regressions found. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Srdjan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13332 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org