[Bug 12505] New: Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Bug ID: 12505 Summary: Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: simith.doliveira@inlibro.com QA Contact: testopia@bugs.koha-community.org The variable aqorders.listprice shows aqbooksellers.listprice value instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #1 from simith.doliveira@inlibro.com --- Created attachment 29382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29382&action=edit Bug 12505 - Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work Modified: C4/Letters.pm - remove aqbooksellers.* from SELECT statement In Letters - SendAlerts subrotine, is safe to remove aqbooksellers.* from SELECT statement for type=claimacquisition or claimissues. Aqbooksellers is passed to GetPreparedLetter subrotine in tables variable. Testing: I Apply the patch Select Tools -> Notices and slips; Edit ACQCLAIM; Add : <order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered) ($<<aqorders.listprice>> <<aqbooksellers.listprice>> each) has not been received.</order> Save modifications; Create a vendor (Acquisition module); Create an order (Acquisition module); Click Acquisitions -> Late orders; Select the order created; Click Claim order button; Valide <<aqorders.listprice>>; Valide <<aqbooksellers.listprice>>. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10618 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from simith.doliveira@inlibro.com --- *** Bug 10618 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |eric.begin@inLibro.com Assignee|koha-bugs@lists.koha-commun |simith.doliveira@inlibro.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Well in that case the whole join is unnecessary and should be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree doing a join where we dont either return any of the data from the table, or use it in any condition doesn't make sense. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29382|0 |1 is obsolete| | --- Comment #5 from simith.doliveira@inlibro.com --- Created attachment 31034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31034&action=edit This patch removes the unnecessary join -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would be great if someone could test this! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #7 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patch against master 3.17.00.052 head 13113 I cloned the ACQCLAIM to ACQCLAIM-CPL to test the patch: ACQCLAIM-CPL: ($<<aqorders.listprice>> -- <<aqbooksellers.listprice>> each) as required ACQCLAIM: ($<<aqorders.listprice>> each) as by default MASTER: ACQCLAIM-CPL answers: ($USD -- USD each) WRONG ACQCLAIM answers: ($USD each) WRONG APPLIED: ACQCLAIM-CPL answers: ($2000.000000 -- USD each) RIGHT as required ACQCLAIM doesn't send any mail WRONG So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from simith.doliveira@inlibro.com --- I followed the same test (master 3.17.00.054) as Paola executed: ACQCLAIM-CPL: ($<<aqorders.listprice>> -- <<aqbooksellers.listprice>> each) as required ACQCLAIM: ($<<aqorders.listprice>> each) as by default MASTER: ACQCLAIM-CPL answers: ($USD -- USD each) WRONG ACQCLAIM answers: ($USD each) WRONG APPLIED: ACQCLAIM-CPL answers: ($2000.000000 -- USD each) RIGHT as required But: ACQCLAIM: ($2000.000000 each) So, I pass to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Simith. Today I've applied again the patch, against master 3.17.00.054 HEAD 11634. My tests agreed with the Simith's ones in comment 8. So: 2 notices: ACQCLAIM-CPL: ($<<aqorders.listprice>> -- <<aqbooksellers.listprice>> each) as required ACQCLAIM: ($<<aqorders.listprice>> each) as by default On ACQ, on lateorders.pl: MASTER: ACQCLAIM-CPL answers: ($USD -- USD each) WRONG ACQCLAIM answers: ($USD each) WRONG APPLIED: ACQCLAIM-CPL answers: ($2000.000000 -- USD each) RIGHT as required ACQCLAIM: ($2000.000000 each) RIGHT When I didn't check any order in late, and select "Claim order", koha answered: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. I think this is an error. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #10 from simith.doliveira@inlibro.com --- Created attachment 33527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33527&action=edit Bug 12505 - Variable aqorders.listprice from 'Tools' - 'Notices and Slips' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from simith.doliveira@inlibro.com --- The problem described in the comment 9: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. I could verify even before applying the patch, but I corrected it in the second patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #12 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to simith.doliveira from comment #11)
The problem described in the comment 9:
Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054.
I could verify even before applying the patch, but I corrected it in the second patch
Kind Simith, I'm very sorry, the error is mine. I should not have considered that behaviour in this bug, I beg your pardon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31034|0 |1 is obsolete| | --- Comment #13 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 33562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33562&action=edit Bug 12505 31034: This patch removes the unnecessary join I've applied the patch against master 3.17.00.054 head 11634 IMO the second patch "Variable aqorders.listprice from 'Tools' - 'Notices and Slips'" is not needed. I pass the patch "This patch removes the unnecessary join" to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Simith and Paola, thank you for working on this! The behaviour on clicking "Claim order" without any order selected has been improved to display a proper error message - this is nice and should be reflected in the commit messages - no need to hide enhancements :) Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2064. turned to: No order selected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Variable aqorders.listprice |Make variable |from 'Tools' - 'Notices and |aqorders.listprice in acq |Slips' Does not work |claim notice work and | |improve error handling -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33527|0 |1 is obsolete| | Attachment #33562|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33602&action=edit [PASSED QA] Bug 12505 - Acq claim: Show error message when no order is selected If no order is selected on the acq claim page when clicking 'Claim order' an ugly perl error message is displayed. This patch corrects the behaviour to display a human readable 'No order selected' instead. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Reworded commit message to reflect what the patch achieves. Works as described and passes tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33603&action=edit [PASSED QA] Bug 12505 - Variable aqorders.listprice in acq claim notice doesn't work Modified: C4/Letters.pm - remove aqbooksellers.* from SELECT statement In Letters - SendAlerts subrotine, is safe to remove aqbooksellers.* from SELECT statement for type=claimacquisition or claimissues. Aqbooksellers is passed to GetPreparedLetter subrotine in tables variable. Testing: I Apply the patch Select Tools -> Notices and slips; Edit ACQCLAIM; Add : <order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered) ($<<aqorders.listprice>> <<aqbooksellers.listprice>> each) has not been received.</order> Save modifications; Create a vendor (Acquisition module); Create an order (Acquisition module); Click Acquisitions -> Late orders; Select the order created; Click Claim order button; Valide <<aqorders.listprice>>; Valide <<aqbooksellers.listprice>>. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. It's now possible to output the actual price in the claim notice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Simith, I reworded the commit messages to make the intention more clear - I hope my changes are ok for you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #18 from simith.doliveira@inlibro.com --- Ok for me. Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Simith! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- I did not see this patch, sorry. Is it still possible to select info from the aqbooksellers table in the claim notice? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I checked and the bookseller name was still printed into my notice - I was wondering too. If I didn't test it wrong, it should not cause any harm. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #21)
I checked and the bookseller name was still printed into my notice - I was wondering too. If I didn't test it wrong, it should not cause any harm.
Just reading the code, I suspect a regression: The fields from the aqbooksellers table won't be correctly replaced. "name" is replaced because it's a field in the aqcontact table. I don't have the time to test this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can try to retest - but it was "Katrin's bookshop" - so the vendor name that appeared in the notice if I remember correctly. So hopefully no regression, but will try to verify later today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Or maybe someone else can get to it before? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested again and have definitely fields from aqbooksellers showing up in my notice. I tested with postal address and phone. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- <<aqbooksellers.name>> <<aqbooksellers.postal>> <<aqbooksellers.phone>> <order> Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered) ($<<aqorders.listprice>> each) has not been received. </order> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org