[Bug 34946] New: Remove the use of event attributes from self checkout and check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Bug ID: 34946 Summary: Remove the use of event attributes from self checkout and check-in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 34709 There are some event attributes in self checkout and self check-in templates. These should be removed in favor of defining events in JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 [Bug 34709] Eliminate event handler attributes in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156329&action=edit Bug 34946: Remove the use of event attributes from self checkout and check-in This patch removes the use of event attributes from the self checkout and self check-in templates. These events are defined now along with the other in-page JS. To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. - Navigate to the self checkout interface (/cgi-bin/koha/sco/sco-main.pl). - When the page loads, cursor focus should be automatically placed in the barcode field. - Test the "munge history" feature from Bug 10016: [1] Start a web-based self-check session. [2] Enter a patron barcode. [3] Allow the self-check session to time out. [4] Use the back button. You should get the patron barcode entry form; you should not be prompted to resubmit form input. [5] Enter a patron barcode, perform some transactions, then use the finish button. [6] Next, use the back button. You should get the patron barcode entry form. - Test the updated checkout_confirm function by submitting the "magic" barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be ended. - Navigate to the self check-in interface (/cgi-bin/koha/sco/sci-main.pl). - Test the cursor focus and "munge history" feature on this page too. -- You are receiving this mail because: You are watching all bug changes.
To test you must have SelfCheckInModule and WebBasedSelfCheck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- preferences enabled. Is that all to do access the self check-in interface? I get 404 on /cgi-bin/koha/sco/sci-main.pl on both opac and staff
[1] Start a web-based self-check session.
self-check-in right? I just discovered the existence of the self-check-in so I can easily confuse the two. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I didn't have any issue accessing - using KTD (in KTD need to enable SelfCheckInModule, WebBasedSelfCheck already enabled, only available on the OPAC side - http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Victor Grousset/tuxayo from comment #2)
I get 404 on /cgi-bin/koha/sco/sci-main.pl on both opac and staff
It's sci/sci-main.pl not sco/sci-main.pl T_T -- You are receiving this mail because: You are watching all bug changes.
To test you must have SelfCheckInModule and WebBasedSelfCheck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- preferences enabled. And also SelfCheckoutByLogin = cardnumber Test plan updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156329|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 157574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157574&action=edit Bug 34946: Remove the use of event attributes from self checkout and check-in This patch removes the use of event attributes from the self checkout and self check-in templates. These events are defined now along with the other in-page JS. To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. And SelfCheckoutByLogin = cardnumber. - Navigate to the self checkout interface (/cgi-bin/koha/sco/sco-main.pl). - When the page loads, cursor focus should be automatically placed in the barcode field. - Test the "munge history" feature from Bug 10016: [1] Start a web-based self-check session. [2] Enter a patron barcode. [3] Allow the self-check session to time out. [4] Use the back button. You should get the patron barcode entry form; you should not be prompted to resubmit form input. [5] Enter a patron barcode, perform some transactions, then use the finish button. [6] Next, use the back button. You should get the patron barcode entry form. - Test the updated checkout_confirm function by submitting the "magic" barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be ended. - Navigate to the self check-in interface (/cgi-bin/koha/sco/sci-main.pl). - Test the cursor focus and "munge history" feature on this page too. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157574|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157576&action=edit Bug 34946: Remove the use of event attributes from self checkout and check-in This patch removes the use of event attributes from the self checkout and self check-in templates. These events are defined now along with the other in-page JS. To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. And SelfCheckoutByLogin = cardnumber. - Navigate to the self checkout interface (/cgi-bin/koha/sco/sco-main.pl). - When the page loads, cursor focus should be automatically placed in the barcode field. - Test the "munge history" feature from Bug 10016: [1] Start a web-based self-check session. [2] Enter a patron barcode. [3] Allow the self-check session to time out. [4] Use the back button. You should get the patron barcode entry form; you should not be prompted to resubmit form input. [5] Enter a patron barcode, perform some transactions, then use the finish button. [6] Next, use the back button. You should get the patron barcode entry form. - Test the updated checkout_confirm function by submitting the "magic" barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be ended. - Navigate to the self check-in interface (/cgi-bin/koha/sco/sci-main.pl). - Test the cursor focus and "munge history" feature on this page too. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org