[Bug 13673] New: Remove warnings from t/db_dependent/Barcodes.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Bug ID: 13673 Summary: Remove warnings from t/db_dependent/Barcodes.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- All diags should be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38995&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) prove t/db_dependent/Barcodes.t 3) apply patch 4) prove t/db_dependent/Barcodes.t -- same output as before. -- code is identical except for indentations. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38995|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38996&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38997&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38998&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #6 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39000&action=edit Bug 13758: (QA followup) revert case change that broke the tests Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38997|0 |1 is obsolete| | --- Comment #7 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39001&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39001|0 |1 is obsolete| | --- Comment #8 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39002&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38996|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39003&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39003|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39004&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39002|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39005&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38998|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39006&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39006|0 |1 is obsolete| | --- Comment #13 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39010&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39004|0 |1 is obsolete| | --- Comment #14 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39011&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39005|0 |1 is obsolete| | --- Comment #15 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39012&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39010|0 |1 is obsolete| | --- Comment #16 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39013&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com Status|Needs Signoff |Signed Off --- Comment #17 from Indranil Das Gupta <indradg@gmail.com> --- 1/ All three test plans were followed. 2/ All three patches cleared koha-qa.pl -c 1 -v 2 without errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39011|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39220&action=edit [PASSED QA] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39012|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39221&action=edit [PASSED QA] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39013|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39222&action=edit [PASSED QA] Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39223&action=edit Bug 13673: (QA followup) Add license Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org