[Bug 30622] New: Search for cardnumber needs to go directly to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Bug ID: 30622 Summary: Search for cardnumber needs to go directly to patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When searching for a cardnumber that matches exactly an existing cardnumber, the corresponding patron needs to 'found' directly, without displaying a result list. To test: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database - Verify the result list is shown instead of selecting the patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30063 Summary|Search for cardnumber needs |Search for cardnumber needs |to go directly to patron |to go directly to patron |record |record when placing a hold Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Keywords| |rel_22_05_candidate Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134073&action=edit Bug 30622: Patron search when placing hold should redirect if cardnumber is entered When search a patron for placing a hold, if a cardnumber is entered we should pick the patron and use it, instead of display the table result. This was a regression caused by bug 30063. Test plan: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Should this behaviour be applied to some other patron searches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you give an example? I could test if it's a regression with 20.11 or so. But my first reaction would be yes. An exact match on cardnumber or userid should open the patron record directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #3)
Can you give an example? I could test if it's a regression with 20.11 or so.
But my first reaction would be yes.
An exact match on cardnumber or userid should open the patron record directly.
An example of what? Of another patron search? Could be guarantor, user for funds or suggestion, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, I have done some testing on an older (20.11.x) version: Cardnumbers for testing: A A1 A2 1) Patron search: A A opens directly 2) Acq > User to notify on receive A shows only one result Tried something else: AA AA2 AA3 AA = 1 result A = 3 results So it seems to limit when exact match. But then you need to click the single result. 3) Place hold Searching for AA selects the user directly. So it seems the behavior was a little different between searches before, but it should certainly be fixed for place hold. Note: it only seems to work for cardnumber, not for userid. But I think this is ok, you are more likely to scan the card and expect a direct link than when searching for userid. Also userid might be more likely to be more uniqe. While sequential cardnumbers generated with autoMemberNum could lead to a long list of possible candidates quicky (especially if you started with 1). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134073|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 134451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134451&action=edit Bug 30622: Patron search when placing hold should redirect if cardnumber is entered When search a patron for placing a hold, if a cardnumber is entered we should pick the patron and use it, instead of display the table result. This was a regression caused by bug 30063. Test plan: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134451|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134681&action=edit Bug 30622: Patron search when placing hold should redirect if cardnumber is entered When search a patron for placing a hold, if a cardnumber is entered we should pick the patron and use it, instead of display the table result. This was a regression caused by bug 30063. Test plan: - Place a hold on anything in staff - Search for 42 or any other existing cardnumber in your database Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30622 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org