[Bug 15367] New: Batch patron modification: Data loss with multiple repeatable patron attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Bug ID: 15367 Summary: Batch patron modification: Data loss with multiple repeatable patron attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: - Create a patron attribute type that is repeatable, e.g. HOBBIES - Edit a patron and add multiple values of this type, e.g. Skating, Skiing, Swimming - Do a batch update for this patron with three values for the attribute, e.g. Reading, Jogging, Surfing - Go back to patron's detail page. - Result: Only one attribute is set (Surfing) (Expected: All 3 attributes are updated) - Restore the original values Skating, Skiing, Swimming Do the batch modification with one attribute only, e.g. Painting - Go back to patron's detail page - Result: Only one attribute is set (Painting) (Expected: Painting, Skiing, Swimming) Additionally, exclusive attributes can be repeated in batch update, result is similar as above (last attribute is taken). Expected: Exclusive attributes should not be repeatable in batch update. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12636 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45880&action=edit Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45880|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45883&action=edit [SIGNED-OFF] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45883|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46409&action=edit [PASSED QA] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note: this could be implemented. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org