[Bug 15462] New: Unable to renew books via circ/renew.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Bug ID: 15462 Summary: Unable to renew books via circ/renew.pl Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: chad@pennmanor.net QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Renewing books from circ/renew.pl produces an internal server error with the following entry in the logs: ("Can't locate object method \"single\" via package \"5\" (perhaps "...) called at /var/koha/circ/renew.pl line 57 mveron confirmed this impacts the master branch as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 chad@pennmanor.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chad@pennmanor.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical Version|3.22 |master Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Depends on| |13790 Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is critical. It looks like a bad side effect of bug 13790. Still investigating... Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 [Bug 13790] Add unique id issue_id to issues and old_issues tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #2 from Marc Véron <veron@veron.ch> --- Found soultion, patch follows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 46242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46242&action=edit Bug 15462 - Unable to renew books via circ/renew.pl To verify: Got to circ/circulation.pl and try to renew an item. Result: Can't call method "single" without a package or object reference at /usr/share/kohaclone/circ/renew.pl line 57 To test: - Apply patch - Try to renow items that are or are not checked out. Error no longer occurs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- For the record, it has been introduced by commit 3cab4d1efd25268441c88ce74d5a4b568773c8aa Bug 14978: (RM followup) DBIx update Bug 14978 introduced a unique on items.itemnumber to get the constraint we had before bug 13790. With adding this constraint, DBIx::Class::Schema::Loader renamed the has_many issues RS with a might_have issue. +__PACKAGE__->might_have( + "issue", -__PACKAGE__->has_many( - "issues", -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14978 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 [Bug 14978] issues.itemnumber should be a unique key -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46242|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46243&action=edit Bug 15462 - Unable to renew books via circ/renew.pl To verify: Got to circ/circulation.pl and try to renew an item. Result: Can't call method "single" without a package or object reference at /usr/share/kohaclone/circ/renew.pl line 57 To test: - Apply patch - Try to renow items that are or are not checked out. Error no longer occurs. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #6 from chad@pennmanor.net --- This patch fixed it. Thank you! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46243|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46346&action=edit [PASSED QA] Bug 15462 - Unable to renew books via circ/renew.pl To verify: Got to circ/circulation.pl and try to renew an item. Result: Can't call method "single" without a package or object reference at /usr/share/kohaclone/circ/renew.pl line 57 To test: - Apply patch - Try to renew items that are or are not checked out. Error no longer occurs. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org