[Bug 6752] New: Be stricter with utf-8 output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Bug #: 6752 Summary: Be stricter with utf-8 output Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org Many IO handles are opened in Koha with the parameter ':utf8' the result is to flag strings output ( or input )as being utf-8 strings. However the it does accept invalid utf8. To validate the output the parameter ':encoding(UTF-8) is required. We should at least be strict with what we output. As the use of :utf8 is flagged by Perl::Critic policies as a violation the QA test 00-percritic.t fails three tests. We should be stricter with output encodings -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-08-19 11:16:26 UTC --- Created attachment 5058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5058 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-08-19 11:17:16 UTC --- Patch attached: tests now pass -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5058|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-09-01 12:07:15 UTC --- Created attachment 5252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5252 Signed-off patch I understand Colin concern and approve his solution which is obviously valid from a Perl strictness point of view. I haven't tested all modified scripts in order to detect any side effect, but don't think it's necessary. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 14:31:44 UTC --- QA comment : * if it's to fix a perlcritic I won't object * I would have preffered to have included this patch earlier, with opportunity to have more time to test more cases * OTH, Frédéric has also diacritics concern Marking passed QA, but would not object if chris requires more testing ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-12 21:00:22 UTC ---
From what I can tell, this safely implements the stricter UTF-8 checks across numerous affected files; several files (C4/tests/Record_test.pl and C4/Installer.pm, most notably) do not have this change made; they are slurping in UTF-8 *input* however, which is outside the scope of this report.
Any replacement of file handles with variables is done universally, so no mis-matches there. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-19 04:02:40 UTC --- I don't feel I have enough time to test this thoroughly, holding for 3.6.1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Serhij Dubyk <dubyk@library.lviv.ua> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@library.lviv.ua -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 10:18:05 UTC --- sorry, but it does not apply anymore against master : 11:08 ~/koha.dev/koha-community (new/bug_6752 $%)$ git am -3 /tmp/Signed-off-patch-OH345M.patch Applying: Bug 6752: Be stricter with utf-8 encoding of output Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/aqplan.pl Auto-merging circ/overdue.pl CONFLICT (content): Merge conflict in circ/overdue.pl Auto-merging circ/ypattrodue-attr-search-authvalue.pl CONFLICT (content): Merge conflict in circ/ypattrodue-attr-search-authvalue.pl Auto-merging circ/ysearch.pl CONFLICT (content): Merge conflict in circ/ysearch.pl Auto-merging misc/migration_tools/rebuild_zebra.pl Auto-merging misc/translator/xgettext.pl CONFLICT (content): Merge conflict in misc/translator/xgettext.pl Auto-merging tools/export.pl Failed to merge in the changes. Patch failed at 0001 Bug 6752: Be stricter with utf-8 encoding of output I planned to test at least some of them before pushing, and will do that once you submit a rebases patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5252|0 |1 is obsolete| | --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-11-07 14:28:40 UTC --- Created attachment 6248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6248 Patch rebased against current HEAD -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Serhij Dubyk <dubyk@library.lviv.ua> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6554 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 06:30:39 UTC --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6752: Be stricter with utf-8 encoding of output Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging cataloguing/ysearch.pl CONFLICT (content): Merge conflict in cataloguing/ysearch.pl Auto-merging misc/cronjobs/overdue_notices.pl Auto-merging misc/migration_tools/rebuild_zebra.pl Failed to merge in the changes. Patch failed at 0001 Bug 6752: Be stricter with utf-8 encoding of output When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6248|0 |1 is obsolete| | --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-12-23 10:44:34 UTC --- Created attachment 6928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6928 Updated patch Updated patch to remove one case that has already been corrected by a subsequent patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6928|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-01-19 09:58:49 UTC --- Created attachment 7246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7246 signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA Version|master |rel_3_8 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-27 11:10:24 UTC --- This patch has been tested by many people (the initial one, or the rebased one) Marking as "passed QA", i'll push it in a few seconds. However, I keep it for 3.8. If there is an undetected side-effect, we will have time to see it. chris_n, if you object you can push for 3.6, but I think you should not. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-27 11:12:49 UTC --- Patch pushed. Note that Jonathan forgot to add his signoff to the "signed-off patch" he uploaded, I've added it myself (with my signoff) before pushing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6752 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6895 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org