[Bug 7433] New: french translation add a bad single quote into js function
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 Bug #: 7433 Summary: french translation add a bad single quote into js function Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: stephane.delaune@biblibre.com QAContact: ian.walls@bywatersolutions.com in staff, the french version of cgi-bin/koha/tools/stage-marc-import.pl have this line into a javascript's function : alert(_('Echec de l'envoi du formulaire : ') + textStatus); (original text : alert(_('Failed to submit form: ') + textStatus);) the single quote isn't escaped -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |cgi-bin/koha/tools/stage-ma | |rc-import.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|frederic@tamil.fr |stephane.delaune@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 --- Comment #1 from stephane.delaune@biblibre.com 2012-01-10 14:17:33 UTC --- Created attachment 7103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7103 fix 7433 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #2 from stephane.delaune@biblibre.com 2012-01-10 14:22:28 UTC --- to test : misc/translator$ ./translate install fr-FR select fr-FR on language syspref go to cgi-bin/koha/tools/stage-marc-import.pl import a file (clic on "Télécharger fichier") and clic on "traiter pour import" if it works, it's ok -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-13 06:53:14 UTC --- Stephane, wouldn't another option be to fix the po file? So that the ' is escaped? If that isn't a possibility then let me know and I can test and sign off on this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 --- Comment #4 from stephane.delaune@biblibre.com 2012-01-18 10:03:19 UTC --- it is possible to escape the character but is more common to have a text containing ' rather than " so it seems more appropriate to apply this patch, rather than to escape the character ' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-18 10:23:58 UTC --- I think it depends on the language. For example we don't use single quotes in German, but we would use "" for quoting of words. Perhaps a solution would be to fix the translation scripts. So when they find an ' or " in a _javascript_ string, the characters are escaped. Note: Translation of javascript is also problematic for concatenated strings (see bug 7327). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7433 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution| |INVALID -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org