[Bug 21299] New: Move referer code from changelanguage to module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Bug ID: 21299 Summary: Move referer code from changelanguage to module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Originally posted on bug 19799. See also 21267. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19799 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move referer code from |Move referer code from |changelanguage to module |changelanguage to module in | |opac and staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78324&action=edit Bug 21299: Add localReferer function to Util module, add test Before implementing the change in [opac-]changelanguage, we define a new function (in Koha/Util.pm) and add tests. Test plan: Run t/Koha/Util/localReferer.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78325&action=edit Bug 21299: Introduce localReferer in [opac-]changelanguage.pl With the work from the former patch, we now have a nice and easy replace.. NOTE: The additional logic in opac-changelanguage.pl is now also applied to the intranet counterpart (changelanguage.pl). This effectively makes changelanguage.pl no longer refer to external URLs (as the opac already did by testing the referer). Might be just theoretical, but consistent. Test plan: Test changing language from various OPAC and staff locations. Include language=[some_language] in the URL before changing language. [Bonus] Test calling changelanguage.pl from another server. You should no longer be referred back to the calling server. (See below.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added link <a href="[mystaffserver]/cgi-bin/koha/changelanguage.pl?language=en">link</a> somewhere on external server. Verified that without this patch, it hits the staff server and refers back to the caller. But with this patch, it refers to staff homepage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Tomas, this begs for your signoff now :) Note that I found some extra argument for this code in the staff script still allowing external referrals.. And more consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78324|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 78334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78334&action=edit Bug 21299: Add localReferer function to Util module, add test Before implementing the change in [opac-]changelanguage, we define a new function (in Koha/Util.pm) and add tests. Test plan: Run t/Koha/Util/localReferer.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78325|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 78335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78335&action=edit Bug 21299: Introduce localReferer in [opac-]changelanguage.pl With the work from the former patch, we now have a nice and easy replace.. NOTE: The additional logic in opac-changelanguage.pl is now also applied to the intranet counterpart (changelanguage.pl). This effectively makes changelanguage.pl no longer refer to external URLs (as the opac already did by testing the referer). Might be just theoretical, but consistent. Test plan: Test changing language from various OPAC and staff locations. Include language=[some_language] in the URL before changing language. [Bonus] Test calling changelanguage.pl from another server. You should no longer be referred back to the calling server. (See below.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added link <a href="[mystaffserver]/cgi-bin/koha/changelanguage.pl?language=en">link</a> somewhere on external server. Verified that without this patch, it hits the staff server and refers back to the caller. But with this patch, it refers to staff homepage. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #5)
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick comments here: 1. localReferer is camelCase 2. Koha::Util sounds like a very bad idea (too generic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78618&action=edit Bug 21299: (QA follow-up) Rename module and subroutine See QA request at comment7. Removing camelcase from subroutinename. Renaming module to Koha::Util::CGI. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
Quick comments here: 1. localReferer is camelCase 2. Koha::Util sounds like a very bad idea (too generic)
Fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd like other QA point of views. I already had the need of a Koha::CGI, based on CGI - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66045 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)
I'd like other QA point of views. I already had the need of a Koha::CGI, based on CGI - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66045
This is not the same point however. Koha::Util::CGI includes one very specific CGI related utility function. Koha::CGI is a generic interface between Koha and CGI.pm. Also note that Koha::Util::CGI is just a suggestion for a better name. But for me it could be something else too: Util::Navigation or Redirection or ? Do you have another idea/suggestion ? Tomas/Martin: Any feedback on the name ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. could it perhaps sit within Koha::I18N or Koha::Template::Utils, Koha::Language::Utils.. not entirely opinionated about it to be honest.. :0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- @Nick: This is some sort of QA deadlock about the module name. Can we push this further now? If we find a better name, it will be trivial to do the rename operation.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Nick: See previous comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We are not stuck, we are discussing about a better name. The patches are not blocking another work and are not vital/a priority. Maybe we should ask other QAers? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15)
We are not stuck, we are discussing about a better name. The patches are not blocking another work and are not vital/a priority. Maybe we should ask other QAers?
There is no real discussion going on here. See the comments above. And I asked already feedback, and I did it again just now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Koha::Util::Navigation looks best for me, but no strong opinion here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78334|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 81120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81120&action=edit Bug 21299: Add localReferer function to Util module, add test Before implementing the change in [opac-]changelanguage, we define a new function (in Koha/Util.pm) and add tests. Test plan: Run t/Koha/Util/localReferer.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78335|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 81121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81121&action=edit Bug 21299: Introduce localReferer in [opac-]changelanguage.pl With the work from the former patch, we now have a nice and easy replace.. NOTE: The additional logic in opac-changelanguage.pl is now also applied to the intranet counterpart (changelanguage.pl). This effectively makes changelanguage.pl no longer refer to external URLs (as the opac already did by testing the referer). Might be just theoretical, but consistent. Test plan: Test changing language from various OPAC and staff locations. Include language=[some_language] in the URL before changing language. [Bonus] Test calling changelanguage.pl from another server. You should no longer be referred back to the calling server. (See below.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added link <a href="[mystaffserver]/cgi-bin/koha/changelanguage.pl?language=en">link</a> somewhere on external server. Verified that without this patch, it hits the staff server and refers back to the caller. But with this patch, it refers to staff homepage. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78618|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 81122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81122&action=edit Bug 21299: (QA follow-up) Rename module and subroutine See QA request at comment7. Removing camelcase from subroutinename. Renaming module to Koha::Util::Navigation (after cmty feedback). Test plan: Run t/Koha/Util/Navigation.t. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Josef Moravec from comment #17)
Koha::Util::Navigation looks best for me, but no strong opinion here.
Great. Good enough for me. Lets pull this out of discussion now.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks like you renamed in the package declaration but didn't rename the file? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back in queue with the follow-up of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #22)
Looks like you renamed in the package declaration but didn't rename the file?
ll Koha/Util/ total 28 -rw-r--r-- 1 dev-koha dev-koha 1851 Dec 18 2017 FrameworkPlugin.pm -rw-r--r-- 1 dev-koha dev-koha 5472 Dec 18 2017 MARC.pm -rw-r--r-- 1 dev-koha dev-koha 2410 Oct 29 10:13 Navigation.pm -rw-r--r-- 1 dev-koha dev-koha 2077 Dec 18 2017 Normalize.pm -rw-r--r-- 1 dev-koha dev-koha 5049 Oct 10 14:34 StockRotation.pm Please check, Martin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #23)
Back in queue with the follow-up of course.
I see no reason to fail these patches. Please clarify. Back to SO in the meantime. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- In the QA followup patch.. we've renamed the package decalaration package Koha::Util; => package Koha::Util::Navigation; but the file Koha/Util.pm was not moved to Koha/Util/Navigation.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #26)
In the QA followup patch.. we've renamed the package decalaration
package Koha::Util; => package Koha::Util::Navigation;
but the file Koha/Util.pm was not moved to Koha/Util/Navigation.pm
Koha/{Util.pm => Util/Navigation.pm} | 12 ++++++------ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, my mistake.. splinter review doesn't show file moves! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81120|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81470&action=edit Bug 21299: Add localReferer function to Util module, add test Before implementing the change in [opac-]changelanguage, we define a new function (in Koha/Util.pm) and add tests. Test plan: Run t/Koha/Util/localReferer.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81121|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81471&action=edit Bug 21299: Introduce localReferer in [opac-]changelanguage.pl With the work from the former patch, we now have a nice and easy replace.. NOTE: The additional logic in opac-changelanguage.pl is now also applied to the intranet counterpart (changelanguage.pl). This effectively makes changelanguage.pl no longer refer to external URLs (as the opac already did by testing the referer). Might be just theoretical, but consistent. Test plan: Test changing language from various OPAC and staff locations. Include language=[some_language] in the URL before changing language. [Bonus] Test calling changelanguage.pl from another server. You should no longer be referred back to the calling server. (See below.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added link <a href="[mystaffserver]/cgi-bin/koha/changelanguage.pl?language=en">link</a> somewhere on external server. Verified that without this patch, it hits the staff server and refers back to the caller. But with this patch, it refers to staff homepage. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81122|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81472&action=edit Bug 21299: (QA follow-up) Rename module and subroutine See QA request at comment7. Removing camelcase from subroutinename. Renaming module to Koha::Util::Navigation (after cmty feedback). Test plan: Run t/Koha/Util/Navigation.t. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA.. all works as expected, I can't find any regressions and the requested module name change has been made. Thanks for persevering Marcel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43540 [Bug 43540] Switching OPAC language loses /bib/<id> short URLs, redirects to homepage -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org