[Bug 16767] New: OPAC suggestions, existing suggestions don't show after placing a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Bug ID: 16767 Summary: OPAC suggestions, existing suggestions don't show after placing a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org After placing a purchase suggestion on the opac the confirmation screen reads: "Your suggestion has been submitted. There are no pending purchase suggestions." Place another, same result. These lines in opac-suggestions.pl don't seem to be working as intended: 136 ^I^I$$suggestion{$_}='' foreach qw<title author publishercode copyrightdate place collectiontitle isbn STATUS>; 137 ^I^I$suggestions_loop = 138 ^I^I &SearchSuggestion( $suggestion ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com, | |veron@veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 52503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52503&action=edit Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a suggestion To test: 1 - Before applying this patch, place some suggestions 2 - Note that on success you see no suggestions 3 - Apply this patch 4 - Add a suggestion, note you see the new suggestion and all other 5 - Add a duplicate suggestion, note suggestions is rejected and you see all existing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Needs to be unit tested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15128 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 --- Comment #3 from Marc Véron <veron@veron.ch> --- Works fine. QA tool complains about a forbidden pattern tab char, opac/opac-suggestions.pl (line 136) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Sandre Cunha <cunha@monterey.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cunha@monterey.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nick, did you forget about this one? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Seems to be fixed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org