https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1 -- we indicate that a bib is suppressed. Why not also a note on hidden items? I'm asked fairly frequently why something or other hidden by OPACHidden isn't visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28827 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Indicate that a record is |Indicate that a record is |using OpacHiddenItems in |using OpacHiddenItems in |staff client |the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #7)

A new column in items table ?

I think that points back to a conversation we've had elsewhere about how challenging OpacHiddenItems is, since it's based off a multi-factor calculation and not just a database flag. If you changed OpacHiddenItems, you'd have to iterate through every item row in the database to check if the column in the items table is hidden. And even then there's other system preferences to check to see whether or not the actual bib record is hidden. -- I think this would be a useful feature, but it would be very difficult to do without overhauling OpacHiddenItems, which is going to be a high effort activity I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #7)

A new column in items table ?

I meant a column in the HTML table of items, in details page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #11)

(In reply to Fridolin Somers from comment #10)

...

(In reply to Fridolin Somers from comment #7)

...

A new column in items table ?

I meant a column in the HTML table of items, in details page.

I like the idea. Do we expect a performance hit by it? Or could it be an indicator somehow, maybe in one of the existing columns, like a small icon with a tool tip?

Sorry, Frido. Now I feel embarrassed 😅. I think that we could expect a performance hit, but the work should be CPU bound rather than I/O bound, so hopefully it won't be too much. The more rules and the more holdings you have, the worse it will be. If we want to show if the bib is hidden by OpacHiddenItems, then I think it gets more complicated, because Koha::Biblio->hidden_in_opac performs the calculation once, and then when building the item array for display, we'd need to perform the calculation again. This would be suboptimal. Perhaps Koha::Biblio->hidden_in_opac should take an optional argument of "items", and Koha::Item->hidden_in_opac should store its calculation in itself. Alternatively, Koha::Biblio->hidden_in_opac could return a hashref of itemnumbers denoting hidden status, and then on detail.pl when processing items this hashref could be checked to determine hidden status. Or we could just worry about optimizing this later if it's an issue. For a small number of holdings and a small number of rules, it probably wouldn't be noticeable. It would probably just have an impact on a higher number of holdings. But then that's where bug 33568 saves the day... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.