[Bug 7140] New: Add item type description on the catalogue search and detail screens
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Bug #: 7140 Summary: Add item type description on the catalogue search and detail screens Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Similar to opac-detail. Facilitates page text search -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-02 06:51:46 UTC --- Created attachment 6145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6145 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6145|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-11-02 13:54:44 UTC --- Created attachment 6146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6146 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-28 09:02:00 UTC --- Created attachment 6441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6441 Print screen 1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-28 09:02:53 UTC --- Created attachment 6442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6442 Print screen 2 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-28 09:08:48 UTC --- QA Comment: Thanks for sending your patches, but the description of this bug report is minimal and test plan is missing. It would be helpful to include more information. This will help people testing and signing off as well as QA. Please look at the two print screens I attached (with and without your patch). With your patch two item type descriptions are listed. This probably occurs when a icon is not found and the alternate text is displayed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-29 00:00:54 UTC --- It is a fairly small change so I did not describe it in too many details: OPAC catalog search results screen have item type displayed as text as well as the icon. This is for the reason being able to use browser text search on the item type. We wanted to replicate that behaviour on the intranet interface, in catalog search and biblio details screens. How to test: Check that item type text is displayed at the end of item type description on catalogue/search.pl results screen and catalogue/detail.pl items. Doubled description is due to the missing icon. You can try searching on "Books", missing icons text should be skipped. If it is not, please check the page source. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-30 13:20:50 UTC --- Thanks for responding and providing more info. You are right about the double itemtype. It is not related to your patch; it is just a strange thing on several places in Koha to show it twice if noItemTypeImages is set or the imageurl is empty. In my opinion listing it twice is just a bug. But that is another bug report. I would like to add to your comment that results depend on the value of pref item-level_itypes. I have two points on your patch now: Search Results: if item-level_itypes==item, then the itemtype (+icon) is already in the column Location (per item) if item-level_itypes==biblio, then the itemtype (+icon) is already in the column Results my conclusion would be: itemtype is not needed additionally here (redundant) Catalogue Details/Items tab: if item-level_itypes==biblio, then the item type is listed with the biblio on top if item-level_itypes==item, then the item type is listed per item Your patch apparently does not really change anything here. (But it would catch the situation mentioned above!) It merely rearranges the tests on noItemTypeImages and imageurl. Looking further, I think that the moredetail script (for the Items tab) should fill imageurl for items, but it does not. The template uses that empty variable! So it never shows an icon. If you change the code here, please resolve that bug too. After those two points, I am wondering if the changes in Search.pm are necessary. Did not further look into that. Could you explain why they are necessary? I agree with you that this is a lot of text for a small patch ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-30 15:34:49 UTC --- Additional comment: Sorry for the confusion. I was looking for catalogue/detail items at catalogue moredetail items. The noItemTypeImages variable is already filled in Auth.pm, so that is not a bug. Moredetail simply never shows the icon. Your patch adds the description at detail, so that is okay. Remains the first point of search results and the question whether changes in Search.pm are needed? So, even more text.. :-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 --- Comment #9 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-06 03:26:13 UTC --- Search Results: I cannot see where the item type description gets duplicated. My intention was only to make sure it gets displayed regardless of whether the icon is present or not. Can you please point out/supply a screenshot of duplicated item type descriptions -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-09 08:25:16 UTC --- (In reply to comment #9)
Search Results: I cannot see where the item type description gets duplicated. My intention was only to make sure it gets displayed regardless of whether the icon is present or not. Can you please point out/supply a screenshot of duplicated item type descriptions Please see comment 7 (not relevant for this report).
Remains the first point of search results and the question whether changes in Search.pm are needed? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6146|0 |1 is obsolete| | --- Comment #11 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-01-27 04:03:54 UTC --- Created attachment 7344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7344 patch Correct, there was a duplication in one case, I've removed it. Re changes in Search.pm, I believe those are needed, because item type description was not being returned for items, so whenever it was expected on the item level it was empty -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7344|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-07 14:18:48 UTC --- Created attachment 7475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7475 Bug 7140: Added item description to complement icon to search result and biblio detail pages Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> This seems like a very big improvement, especially for people using screen readers. I agree that the change to C4::Search is required. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-20 20:33:48 UTC --- Trying to QA this patch, and there's something I don't understand. The display of the img is: <img src="[% itemloo.imageurl %]" alt="[% itemloo.description %]" title="[% itemloo.description %]" /> BEFORE the patch. isn't alt related to dealing with the case of screen readers, displaying the "alt" instead of the image ? I tried my test database (that is item-level_itype=biblio), and I see the "Disque compact" text instead of the image when I run lynx. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 --- Comment #14 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-21 04:19:38 UTC --- Our clients asked us for this, so they must have a reason. Do you want me to ask them which particular reader/process they are using? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 15:22:51 UTC --- (In reply to comment #14)
Our clients asked us for this, so they must have a reason. Do you want me to ask them which particular reader/process they are using?
yes, please. And more than this, could you/they confirm that they're not seeing the text twice, because I think they should. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 cmeech@waitaki.govt.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmeech@waitaki.govt.nz --- Comment #16 from cmeech@waitaki.govt.nz --- We find having the item type descriptions along with the item type icon in the detail of the Bibl record provides useful information to our clients and staff using the OPAC. We believe that it would also be useful for staff in he staff client. As we have numerous item types having unique icons for each item type is impractical, hence the value of the item type description. Likewise having the item type descriptions along with the item type icon in the client search results would provide staff with useful information without much screen clutter. Our motivation is not primarily based around alternate browsers or aiding the browsing of visually impaired users, but this is certainly a welcome addition. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6442|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. Marking as Passed QA. Note that display depends on various settings like item-level_itypes, staff xslt options, noitemtypeimages. If imageurl exists but switches to alternative text display, the description is duplicated (missing icon case): no problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- patch pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org