[Bug 35619] New: Change password form in patron account has misaligned validation errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Bug ID: 35619 Summary: Change password form in patron account has misaligned validation errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff interface Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 31829 Bug 31829 fixed the change password form layout but validation error messages are still misaligned. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829 [Bug 31829] Change password form in patron account is misaligned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160132&action=edit Bug 35619: Fix validation error alignment in change password form Bug 31829 made a change to the change password form in the staff interface to accommodate a gap in the CSS following the staff interface redesign. This gap has been fixed, so we don't need a double class on the fieldset. With this change, the "hint" div can also be put back into place. To test, apply the patch and locate a patron record in the staff interface. - Click the "Change password" button on the patron detail page. - Confirm that the form layout looks correct. - Enter mismatched passwords in the "New password" and "Confirm new password" fields and click "Save" - The validation error message should be aligned to the right of the input field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160132|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160168&action=edit Bug 35619: Fix validation error alignment in change password form Bug 31829 made a change to the change password form in the staff interface to accommodate a gap in the CSS following the staff interface redesign. This gap has been fixed, so we don't need a double class on the fieldset. With this change, the "hint" div can also be put back into place. To test, apply the patch and locate a patron record in the staff interface. - Click the "Change password" button on the patron detail page. - Confirm that the form layout looks correct. - Enter mismatched passwords in the "New password" and "Confirm new password" fields and click "Save" - The validation error message should be aligned to the right of the input field. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160168|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160222&action=edit Bug 35619: Fix validation error alignment in change password form Bug 31829 made a change to the change password form in the staff interface to accommodate a gap in the CSS following the staff interface redesign. This gap has been fixed, so we don't need a double class on the fieldset. With this change, the "hint" div can also be put back into place. To test, apply the patch and locate a patron record in the staff interface. - Click the "Change password" button on the patron detail page. - Confirm that the form layout looks correct. - Enter mismatched passwords in the "New password" and "Confirm new password" fields and click "Save" - The validation error message should be aligned to the right of the input field. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35619 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org