[Bug 35547] New: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Bug ID: 35547 Summary: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. To reproduce: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159743&action=edit Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159743|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 159836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159836&action=edit Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown! Signed-off-by: sabrina <kiehl@mpis.mpg.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Sabrina Kiehl <kiehl@mpis.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kiehl@mpis.mpg.de Status|Needs Signoff |Signed Off --- Comment #3 from Sabrina Kiehl <kiehl@mpis.mpg.de> --- Followed all steps of the test plan and all lists are displayed after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159836|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159885&action=edit Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown! Signed-off-by: sabrina <kiehl@mpis.mpg.de> Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159885|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160224&action=edit Bug 35547: Show public "staff only" lists in addbybiblionumber.pl When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown! Signed-off-by: sabrina <kiehl@mpis.mpg.de> Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |addbybiblionumber.pl Summary|When using "Add to a list" |When using "Add to a list" |dialog ( |button with more than 10 |addbybiblionumber.pl ) list |lists, "staff only" does |that are "staff only" do |not show up |not show up | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Patch complexity|--- |Trivial patch CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 33722 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35547 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33722 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722 [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org