https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Deprecate C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111305&action=edit Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111305|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111313&action=edit Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. We also introduce additional feedback for the end user where it did not exist before. Now we notify the user if some of the collection could not be transfers or if transfers were queued rather than set to request immediately. Test plan 1/ Set up a rotating collection 2/ Transfer the collection 3/ Confirm the action succeeds 4/ Set up some branch transfer limits that will affect items in your collection 5/ Transfer the collection 6/ Note that the transfer succeeds but some items are returned as failures -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff URL| |https://gitlab.com/mrenvoiz | |e/Koha/-/tree/bug_22569 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Please test this as part of the bug 22569 tree linked above. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Add a 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116571&action=edit Bug 26618: Remove use of transferbook in RotatingCollections This patch replaces the use of C4::Circulation::transferbook in C4::RotatingCollections with calls to Koha::Item->request_transfer and adds handling for the various failure cases which that can throw. We also introduce additional feedback for the end user where it did not exist before. Now we notify the user if some of the collection could not be transfers or if transfers were queued rather than set to request immediately. Test plan 1/ Set up a rotating collection 2/ Transfer the collection 3/ Confirm the action succeeds 4/ Set up some branch transfer limits that will affect items in your collection 5/ Transfer the collection 6/ Note that the transfer succeeds but some items are returned as failures Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the Rotating Collections | |system to use the recently | |introduces Koha:: methods | |for Item Transfers. | | | |We | |expose some extra feedback | |to the end user to | |highlight where transfers | |would have previously | |failed silently when used | |in combination with other | |systems that trigger | |transfers. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117609&action=edit Bug 26618: (QA follow-up) Update messages syntax As highlighted, we were not using the standard form of message passing here. This patch updates the template and controller to adopt the more usual syntax. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117611&action=edit Bug 26618: Improve Exception Class Names -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement updates |This enhancement updates release notes|the Rotating Collections |the Rotating Collections |system to use the recently |system to use the recently |introduces Koha:: methods |introduced Koha:: methods |for Item Transfers. |for Item Transfers. | | |We |We |expose some extra feedback |expose some extra feedback |to the end user to |to the end user to |highlight where transfers |highlight where transfers |would have previously |would have previously |failed silently when used |failed silently when used |in combination with other |in combination with other |systems that trigger |systems that trigger |transfers. |transfers. CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.