[Bug 28148] New: js error when printing transfer slip for existing transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Bug ID: 28148 Summary: js error when printing transfer slip for existing transfer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When there is a transfer in progress the modal 'Print transfer slip' button has both 'print' and 'openWin' classes The latter takes care of launching the popup - the former is not needed because there is no form to submit because the transfer exists JS error: Uncaught TypeError: this.form is null <anonymous> http://localhost:8081/cgi-bin/koha/circ/returns.pl:1093 jQuery 9 <anonymous> http://localhost:8081/cgi-bin/koha/circ/returns.pl:1088 jQuery 8 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28064 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 [Bug 28064] Transits are not created at check in despite user responding 'Yes, print slip' to the prompt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119588&action=edit Bug 28148: Remove 'print' class from 'Print transfer slip' when transfer exists The 'print' class triggers JS to create the transfer and update a form When a transfer exists we have no form and use 'openWin' to trigger the print Also, I remove a stray '1' in the template To test: 1 - Set AutomaticItemReturn to "Don't" 2 - Check in an item from another branch 3 - Confirm the transfer 4 - Check it in again 5 - Click 'Print slip' 6 - Note error in console: Uncaught TypeError: this.form is null 7 - apply patch 8 - Repeat 9 - No error! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119588|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119589&action=edit Bug 28148: Remove 'print' class from 'Print transfer slip' when transfer exists The 'print' class triggers JS to create the transfer and update a form When a transfer exists we have no form and use 'openWin' to trigger the print Also, I remove a stray '1' in the template To test: 1 - Set AutomaticItemReturn to "Don't" 2 - Check in an item from another branch 3 - Confirm the transfer 4 - Check it in again 5 - Click 'Print slip' 6 - Note error in console: Uncaught TypeError: this.form is null 7 - apply patch 8 - Repeat 9 - No error! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This does resolve the JS error and allows slips to still be printed. There looks to be other cases in the code, but I can't for the life of me work out how to trigger them.. Signing off for now.. other stuff can be handled in other bugs... this code really needs a concerted cleanup.. it's incredibly difficult to follow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119589|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119592&action=edit Bug 28148: Remove 'print' class from 'Print transfer slip' when transfer exists The 'print' class triggers JS to create the transfer and update a form When a transfer exists we have no form and use 'openWin' to trigger the print Also, I remove a stray '1' in the template To test: 1 - Set AutomaticItemReturn to "Don't" 2 - Check in an item from another branch 3 - Confirm the transfer 4 - Check it in again 5 - Click 'Print slip' 6 - Note error in console: Uncaught TypeError: this.form is null 7 - apply patch 8 - Repeat 9 - No error! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|js error when printing |JavaScript error when |transfer slip for existing |printing transfer slip for |transfer |existing transfer --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we have a sign-off from Owen now too - Martin, do you want to add your line again counting for QA? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119592|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120234&action=edit Bug 28148: Remove 'print' class from 'Print transfer slip' when transfer exists The 'print' class triggers JS to create the transfer and update a form When a transfer exists we have no form and use 'openWin' to trigger the print Also, I remove a stray '1' in the template To test: 1 - Set AutomaticItemReturn to "Don't" 2 - Check in an item from another branch 3 - Confirm the transfer 4 - Check it in again 5 - Click 'Print slip' 6 - Note error in console: Uncaught TypeError: this.form is null 7 - apply patch 8 - Repeat 9 - No error! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Restored SO line and converted to QA :) Passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | CC| |andrew@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28148 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org