https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 183191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183191&action=edit Bug 40129: Always show the "Not finding what you're looking for" links in opac-results.tt This patch simplifies the logic for displaying the "make a purchase suggestion" and "interlibrary loan request" links on the OPAC search results page. Previously, the visibility of the purchase suggestion link was tied to a complex set of conditions evaluated in C4/Auth.pm, involving user login status and permissions. This was unintuitive, as the authorization to make a suggestion should be handled by the suggestions page itself (opac-suggestions.pl), I think. This patch alters the template (opac-results.tt) to check the 'suggestion' and 'IllModule' system preferences directly. If suggestions are allowed system-wide or the master switch for the 'IllModule' is on, the links will be shown shown to all patrons, regardless of login status. To test: 1. Go to Administration > System Preferences > OPAC. 2. Ensure 'Suggestion' is set to 'Enable'. 3. Log out of the OPAC if previously logged in. 4. Perform a search that won't yield any results and verify the "Make a purchase suggestion" link appears on the results page. 5. Click the link and verify that you are prompted to log in. 6. Now set the 'AnonSuggestions' system preference to 'Allow'. 7. Make sure that the 'AnonmousPatron' borrowernumber is set to something other than 0 (is this right, though)? 8. Click the link and verify that you are able to make an anonymous suggestion. 9. Log in as a patron who is NOT allowed to make suggestions (check their patron category permissions). 10. Perform a search and verify the link is still visible. 11. Here we then get a 404, this should be handled more gracefully, but still in opac-suggestions.pl to not make opac-results dependent on a patron object. Ideas very welcome! 11. Go back to System Preferences and set 'suggestion' to 'Don't allow'. 12. Refresh the OPAC search results page. 13. Verify the "Make a purchase suggestion" link is now hidden for both anonymous and logged-in users. 14. This confirms the link's visibility is controlled solely by the 'suggestion' system preference. 15. Now the simpler aspect of 'IllModule', first set everything related to suggestions back to defaults. Then set 'IllModule' to 'Enable'. 16. Make sure the link to place an "interlibrary loan request" is now shown for unauthenticated patrons as well. 17. Leave some comments regarding the unsolved issue in 11) or other problems that you might anticipate through this change. I first thought this was trivial, but it is not :_D! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |esther.melander@bywatersolu | |tions.com --- Comment #3 from Esther Melander <esther.melander@bywatersolutions.com> --- Everything appeared to work. I also tested having both the purchase suggestion link and the ILL link enabled at the same time. The links worked as they should while logged in and logged out. Signed off by: Esther Melander <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183191|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183446&action=edit Bug 40129: Always show the "Not finding what you're looking for" links in opac-results.tt This patch simplifies the logic for displaying the "make a purchase suggestion" and "interlibrary loan request" links on the OPAC search results page. Previously, the visibility of the purchase suggestion link was tied to a complex set of conditions evaluated in C4/Auth.pm, involving user login status and permissions. This was unintuitive, as the authorization to make a suggestion should be handled by the suggestions page itself (opac-suggestions.pl), I think. This patch alters the template (opac-results.tt) to check the 'suggestion' and 'IllModule' system preferences directly. If suggestions are allowed system-wide or the master switch for the 'IllModule' is on, the links will be shown shown to all patrons, regardless of login status. To test: 1. Go to Administration > System Preferences > OPAC. 2. Ensure 'Suggestion' is set to 'Enable'. 3. Log out of the OPAC if previously logged in. 4. Perform a search that won't yield any results and verify the "Make a purchase suggestion" link appears on the results page. 5. Click the link and verify that you are prompted to log in. 6. Now set the 'AnonSuggestions' system preference to 'Allow'. 7. Make sure that the 'AnonmousPatron' borrowernumber is set to something other than 0 (is this right, though)? 8. Click the link and verify that you are able to make an anonymous suggestion. 9. Log in as a patron who is NOT allowed to make suggestions (check their patron category permissions). 10. Perform a search and verify the link is still visible. 11. Here we then get a 404, this should be handled more gracefully, but still in opac-suggestions.pl to not make opac-results dependent on a patron object. Ideas very welcome! 11. Go back to System Preferences and set 'suggestion' to 'Don't allow'. 12. Refresh the OPAC search results page. 13. Verify the "Make a purchase suggestion" link is now hidden for both anonymous and logged-in users. 14. This confirms the link's visibility is controlled solely by the 'suggestion' system preference. 15. Now the simpler aspect of 'IllModule', first set everything related to suggestions back to defaults. Then set 'IllModule' to 'Enable'. 16. Make sure the link to place an "interlibrary loan request" is now shown for unauthenticated patrons as well. 17. Leave some comments regarding the unsolved issue in 11) or other problems that you might anticipate through this change. I first thought this was trivial, but it is not :_D! Signed off by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)

Just a dumb question:

+ [% IF Koha.Preference( 'suggestion' ) || Koha.Preference( 'ILLModule' ) %] - [% IF Koha.Preference( 'ILLModule' ) == 1 && ( loggedinusername || Koha.Preference( 'ILLOpacUnauthenticatedRequest' ) ) %] + [% IF Koha.Preference( 'ILLModule' ) %] [% IF Koha.Preference( 'AutoILLBackendPriority' ) %]

Any reason to keep the BackendPriority here?

Reading the context in the template answered my question.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183790&action=edit Bug 40129: Fix selenium tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40129 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.