[Bug 36020] New: Port default recall notices to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Bug ID: 36020 Summary: Port default recall notices to Template Toolkit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Blocks: 15278 The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #1 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Created attachment 166784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166784&action=edit Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET To test: 1) Observe the default notice contains <<>> tags 2) Apply the patch 3) reset_all 4) Check that the notice is now all in template toolkit [% %] tags 5) Enable recalls 6) Check an item out to a patron 7) Make sure the patron has a primary email 8) Make sure a secondary patron has a primary email 9) Generate a recall on the checked out item for the second patron 10) Check the first patron's notices tab to confirm the return recalled item notice generated properly. 11) Check the item back in and generate the recall slip and confirm it generated correctly. 12) Check the second patron's notices tab to confirm the pickup recalled item notice generated properly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com Assignee|koha-bugs@lists.koha-commun |lisette.scheer@bywatersolut |ity.org |ions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166784|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166934&action=edit Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET To test: 1) Observe the default notice contains <<>> tags 2) Apply the patch 3) reset_all 4) Check that the notice is now all in template toolkit [% %] tags 5) Enable recalls 6) Check an item out to a patron 7) Make sure the patron has a primary email 8) Make sure a secondary patron has a primary email 9) Generate a recall on the checked out item for the second patron 10) Check the first patron's notices tab to confirm the return recalled item notice generated properly. 11) Check the item back in and generate the recall slip and confirm it generated correctly. 12) Check the second patron's notices tab to confirm the pickup recalled item notice generated properly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166935&action=edit Bug 36020: (follow-up) Use title includes This patch updates the recall sample notices to use the patron-title and biblio-title includes for patron and biblio title displays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- 'biblio-title.inc' produces the text "No bibliographic record" for me with this applied. 'biblio-title.inc' biblio=title' Shouldn't this pass the biblionumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166935|0 |1 is obsolete| | --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 170885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170885&action=edit Bug 36020: (follow-up) Use title includes This patch updates the recall sample notices to use the patron-title and biblio-title includes for patron and biblio title displays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170885|0 |1 is obsolete| | --- Comment #6 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 170886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170886&action=edit Bug 36020: (follow-up) Fix title includes This patch updates the recall notices to fill the titles when using the title include. Author: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170886|0 |1 is obsolete| | --- Comment #7 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 170887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170887&action=edit Bug 36020: (follow-up) Fix title includes This patch updates the recall notices to fill the titles when using the title include. Author: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166935|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #8 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 170889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170889&action=edit Bug 36020: (follow-up) Changed biblio=title to biblio=biblio Note: fixed a typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37793 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org Status|Needs Signoff |Failed QA --- Comment #9 from Jason Robb <jrobb@sekls.org> --- A couple of notices have errors: RECALL_REQUESTER_DET - The commas in the address are included even if a patron does not have address info stored in the account - HTML isn't rendered under the ITEMS RECALLED heading PICKUP_RECALLED_ITEM - Recall pickup location is not present - Recall expiration date is not present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #10 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 172134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172134&action=edit Bug 36020: (follow-up) Changed biblio=title to biblio=biblio Note: fixed a typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 172135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172135&action=edit Bug: 36020: (follow-up) fixed no_html and recalls to recall Fixed the errors from the last comment. To test: follow the test plan and confirm it works now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|roadmap_24_05 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172135|0 |1 is obsolete| | --- Comment #12 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 172147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172147&action=edit Bug: 36020: (follow-up) fixed no_html and recalls to recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #13 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 172148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172148&action=edit Bug 36020: (follow-up) Add TT support to recall notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Jason Robb <jrobb@sekls.org> --- RECALL_REQUESTER_DET - This slip is still displaying unrendered HTML: Date: 09/27/2024 Recall for pickup at Centerville koha (42) , , example2@example.com ITEM RECALLED <span class="biblio-title">Seesaw</span> by Hart, Beth Barcode: 39999000013733 Callnumber: Waiting since: 2024-09-27 18:37:03 Notes: - It would be good to omit the extra commas in the address line if there's no data - borrower.state is missing between borrower.city and borrower.zipcode RETURN_RECALLED_ITEM - Still not showing the issue.date_due PICKUP_RECALLED_ITEM - It would be better to use the branch's name rather than its id in the [% recall.pickup_library_id %] area -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #15 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 176478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176478&action=edit Bug 36020: (follow-up) Fix formatting and dates RECALL_REQUESTER_DET will need to be marked as HTML. I fixed all the issues from Comment 14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172147|0 |1 is obsolete| | --- Comment #16 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 176479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176479&action=edit Bug 36020: (follow-up) fixed no_html and recalls to recall Fixed a typo in the commit title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hey everyone, this fix is of interest to us - can we help revive it or do you have plans to come back to it soon? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #18 from Lisette Scheer <lisette@bywatersolutions.com> --- I plan on working on it this week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks Lisette. One of our libraries is happy to sponsor this so let me know if I can help you out. Maybe I can test when you're ready. Aleisha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #20 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #19)
Thanks Lisette. One of our libraries is happy to sponsor this so let me know if I can help you out. Maybe I can test when you're ready.
Aleisha
I've done some work on it again and realized what stopped me last time I tried: In RETURN_RECALLED_ITEM: [%~ INCLUDE 'patron-title.inc' patron => borrower, no_title => 1, no_cardnumber => 1 ~%], comes out Henry Acevedo , and I can't make the extra space go away The same thing happens in PICKUP_RECALLED_ITEM Edna Acosta , I think this might be a bigger issue than this bug. I'm attaching the patches, but I'm not sure it's ready for SO until we can get the extra space fixed. There's no space in the last name, the patron-title.inc doesn't seem to have one either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166934|0 |1 is obsolete| | Attachment #166935|0 |1 is obsolete| | Attachment #172134|0 |1 is obsolete| | Attachment #172148|0 |1 is obsolete| | Attachment #176478|0 |1 is obsolete| | Attachment #176479|0 |1 is obsolete| | --- Comment #21 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182711&action=edit Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET To test: 1) Observe the default notice contains <<>> tags 2) Apply the patch 3) reset_all 4) Check that the notice is now all in template toolkit [% %] tags with html selected 5) Enable recalls 6) Enable SMS 7) Check an item out to a patron 8) Make sure the patron has a primary email, sms, and recall notices enabled 9) Make sure a secondary patron has a primary email, sms, and recall notices enabled 10) Generate a recall on the checked out item for the second patron 11) Check the first patron's notices tab to confirm the return recalled item notice generated properly. 12) Check the item back in and generate the recall slip and confirm it generated correctly. 13) Check the second patron's notices tab to confirm the pickup recalled item notice generated properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Lisette Scheer from comment #20)
(In reply to Aleisha Amohia from comment #19)
Thanks Lisette. One of our libraries is happy to sponsor this so let me know if I can help you out. Maybe I can test when you're ready.
Aleisha
I've done some work on it again and realized what stopped me last time I tried: In RETURN_RECALLED_ITEM:
[%~ INCLUDE 'patron-title.inc' patron => borrower, no_title => 1, no_cardnumber => 1 ~%],
comes out Henry Acevedo , and I can't make the extra space go away
The same thing happens in PICKUP_RECALLED_ITEM
Edna Acosta ,
I think this might be a bigger issue than this bug. I'm attaching the patches, but I'm not sure it's ready for SO until we can get the extra space fixed.
There's no space in the last name, the patron-title.inc doesn't seem to have one either.
I spent a really silly amount of time trying to fix this, but couldn't. Then I tested with the booking confirmation notice and it looks like the space happens there too. So I think fixing that space would be out of the scope for this. So I'll just test your patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182711|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 182713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182713&action=edit Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET To test: 1) Observe the default notice contains <<>> tags 2) Apply the patch 3) reset_all 4) Check that the notice is now all in template toolkit [% %] tags with html selected 5) Enable recalls 6) Enable SMS 7) Check an item out to a patron 8) Make sure the patron has a primary email, sms, and recall notices enabled 9) Make sure a secondary patron has a primary email, sms, and recall notices enabled 10) Generate a recall on the checked out item for the second patron 11) Check the first patron's notices tab to confirm the return recalled item notice generated properly. 12) Check the item back in and generate the recall slip and confirm it generated correctly. 13) Check the second patron's notices tab to confirm the pickup recalled item notice generated properly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Aleisha Amohia from comment #22)
(In reply to Lisette Scheer from comment #20)
I've done some work on it again and realized what stopped me last time I tried: In RETURN_RECALLED_ITEM:
[%~ INCLUDE 'patron-title.inc' patron => borrower, no_title => 1, no_cardnumber => 1 ~%],
comes out Henry Acevedo , and I can't make the extra space go away
The same thing happens in PICKUP_RECALLED_ITEM
Edna Acosta ,
I think this might be a bigger issue than this bug. I'm attaching the patches, but I'm not sure it's ready for SO until we can get the extra space fixed.
There's no space in the last name, the patron-title.inc doesn't seem to have one either.
I spent a really silly amount of time trying to fix this, but couldn't. Then I tested with the booking confirmation notice and it looks like the space happens there too. So I think fixing that space would be out of the scope for this. So I'll just test your patch!
I've reported this as a different bug, Bug 39963 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182713|0 |1 is obsolete| | --- Comment #25 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182774&action=edit Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET To test: 1) Observe the default notice contains <<>> tags 2) Apply the patch 3) reset_all 4) Check that the notice is now all in template toolkit [% %] tags with html selected 5) Enable recalls 6) Enable SMS 7) Check an item out to a patron 8) Make sure the patron has a primary email, sms, and recall notices enabled 9) Make sure a secondary patron has a primary email, sms, and recall notices enabled 10) Generate a recall on the checked out item for the second patron 11) Check the first patron's notices tab to confirm the return recalled item notice generated properly. 12) Check the item back in and generate the recall slip and confirm it generated correctly. 13) Check the second patron's notices tab to confirm the pickup recalled item notice generated properly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #26 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182775&action=edit Bug 36020: (QA follow-up) A few minor corrections Remove unneeded <br> in RECALL_REQUESTER_DET Add IFs to RECALL_REQUESTER_DET to avoid displaying empty lines if there is no phone, email, and/or callnumber to display Use checkout.date_due instead of item.onloan due to bug 39985 Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #27 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- I found two more bugs (bug 39984 and bug 39985) when testing this, but I can reproduce both in main, so they are not blockers for this patch. I made a few small tweaks in a follow-up but everything else looks good! Thanks, Lisette! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #28 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- *** Bug 37793 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |recalls to the objects that | |can be called using | |Template Toolkit and | |updates the default notices | |for RETURN_RECALLED_ITEM, | |PICKUP_RECALLED_ITEM, and | |RECALL_REQUESTER_DET | |notices. | | | |It uses [% INCLUDE | |'biblio-title.inc' | |biblio=biblio link=0 %] | |and [% INCLUDE | |'patron-title.inc' patron | |=> borrower, no_title => 1, | |no_html = 1 %] to pull in | |the title and patron | |information. | | | |Existing installations will | |not see changes to their | |notices but they can be | |viewed using the "See | |default" button when | |editing the notice. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 --- Comment #30 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org