[Bug 39732] New: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Bug ID: 39732 Summary: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181412&action=edit Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39730 [Bug 39730] Remove DelSuggestions from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181412|0 |1 is obsolete| | --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181425&action=edit Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm Note: This function was necessary for a very weird purpose. The whole process was: 1 - Have a suggestion as an hashref 2 - Convert it into a record 3 - Pass it to FindDuplicate 4 - C4/search exctract the exact same hashref as in 1 and performs the search Hence we extracted from FindDuplicate the part that uses the hashref and called it directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181425|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 195128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195128&action=edit Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm Note: This function was necessary for a very weird purpose. The whole process was: 1 - Have a suggestion as an hashref 2 - Convert it into a record 3 - Pass it to FindDuplicate 4 - C4/search extract the exact same hashref as in 1 and performs the search Hence we extracted from FindDuplicate the part that uses the hashref and called it directly Test plan: 1 - Find the ISBN of a book in the database 2 - Make a suggestion with this isbn through the intranet 3 - Make a suggestion with this isbn through the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Note : - need_confirm => 1 + need_confirm => 1, ); + $stored_suggestion = $suggestion_only; $op = 'save'; This fixes a regression concerning this feature but is not directly correlated with the removing from MarcRecordFromNewSuggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23990 |42070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42070 [Bug 42070] Remove ModSuggestion from C4/Suggestion.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_26_05 CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39732 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Dependent bug 39727 no longer applies (sha1/fake ancestor error). Testing notes so far (using KTD): 1. ISBN to use: 9780596004927 2. Make a suggestion using the staff interface: - Acquisitions > Suggestions > New purchase suggestion - Add a title and use ISBN 9780596004927 - Click "Submit your suggestion" - Warning message shown: A similar document already exists: Programming Perl /. Click on "Confirm your suggestion" to ignore this message. - Add details again: title and ISBN - Click "Confirm your suggestion" ==> Result: Suggestion created 3. Make a suggestion using the OPAC - OPAC > Welcome, koha > Your account > Purchase suggestions > New purchase suggestion - Add a title and use ISBN 9780596004927 - Click "Submit your suggestion" - Warning message shown: A similar document already exists: Programming Perl /. Click on "Confirm your suggestion" to ignore this message. - Click "Confirm your suggestion" (note: don't need to add the details again like you do with the staff interface) ==> Result: Suggestion created 4. Apply the patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org