[Bug 41371] New: Title should be recorded to accountlines.description when expired reservation fee is created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41371 Bug ID: 41371 Summary: Title should be recorded to accountlines.description when expired reservation fee is created Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: anni.maki-mantila@turku.fi QA Contact: testopia@bugs.koha-community.org Currently when expire_holds.pl cron creates an expired reservation fee, the description in accountlines-table is left blank. If the biblio title would be saved to description field, we could use it in ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF -notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41371 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41371 --- Comment #1 from Lari Strand <lmstrand@gmail.com> --- Created attachment 194100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194100&action=edit Bug 41371: Record biblio title to RESERVE_EXPIRED accountline description To test: 1. Find an expired reserve or create one by manipulating the reserves.expirationdate value in the database. Make a note of the borrowernumber. 2. Check that the circulation and fine rules has an expired hold charge configured for the tested reserve's itemtype 3. Run cancel_expired_holds.pl -cronscript 4. Note that the created accountline's description is empty either by checking transactions from patron's accounting tab or from database (select * from accountlines where debit_type_code = 'RESERVE_EXPIRED' and borrowernumber = x) 5. Apply patch 6. Repeat steps 1 and 2 7. Note that the created accountline's description now includes the expired reserve's item's bibliographic record's title either by checking transactions from patron's accounting tab or from database (select * from accountlines where debit_type_code = 'RESERVE_EXPIRED' and borrowernumber = x) Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41371 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand@gmail.com --- Comment #2 from Lari Strand <lmstrand@gmail.com> --- *** Bug 41152 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41371 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 198210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198210&action=edit Screenshot - fee for hold waiting too long - title in the description Has this already been implemented? See the screenshot - it shows the title in the description for the "Hold waiting too long" charge. Testing notes (using KTD): 1. Step 1: - I placed a hold for "Programming perl" (biblionumber = 262) for Mary Burton (borrowernumber = 49). - Then I checked in the item (39999000011418), so that there is a waiting hold - To update the expirationdate in the database: . koha-mysql kohadev . update reserves set expirationdate = "2026-01-01"; (This updates all holds, but since this is KTD, there is only one) 2. Step 2: - Set these system preferences: . ExpireReservesMaxPickUpDelay = Allow . ExpireReservesMaxPickUpDelayCharge = 5 . Note that in Administration > Patrons and circulation > Circulation and fine rules, "All All" rule, that for "Expired hold charge" there is a link "Default" (which takes you to the ExpireReservesMaxPickUpDelayCharge system preference) 3. Step 4: misc/cronjobs/holds/cancel_expired_holds.pl The patch still applies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41371 --- Comment #4 from David Nind <david@davidnind.com> --- Additional testing notes (using KTD): 1. Before the patch: - Database: select * from accountlines where debit_type_code = 'RESERVE_EXPIRED' and borrowernumber = 49; ==> Nothing in the description field - UI: The title is already in the description under Accounting > Make a payment: (Programming Perl /) 2. After the patch: - Database: same query as for step 1, description field has Programming Perl / - UI: The title is now repeated in the description under Accounting > Make a payment: Programming Perl / (Programming Perl /) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41371 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lmstrand@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org