https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same today on 18.05_U18 (#112) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82238&action=edit Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82238|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89038&action=edit Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Signed-off-by: Liz Rea <wizzyrea@gmail.com> I couldn't get the test to fail, but it still passes with this change and if Jonathan thinks it needs it, it probably does. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89038|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89300&action=edit Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.