[Bug 41882] New: Batch hold modification tool updates pickup locations to disallowed libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Bug ID: 41882 Summary: Batch hold modification tool updates pickup locations to disallowed libraries Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If a library's 'Holds and bookings policies by item type' is set to only allow pickup at an item's home library, the batch hold modification tool can still be used to update a hold's pickup location to other libraries such that the hold will never trigger to fill. To replicate: -Set ReservesControlBranch to 'item's home library' -Set Main library's 'Holds and bookings policies by item type' so that PASS items can only be picked up at Main -Place a hold on a bib whose only item is a PASS belonging to Main -Use the Batch hold modification tool to identify the hold you just placed -Update the pickup location to North. Note that the update is successful, and there's no indication that the pickup location is now a problem. -Check in Main's PASS, and note that the hold doesn't trigger to fill The batch update shouldn't process for holds where the change will make the hold unfillable per a library's 'Holds and bookings policies by item type'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Severity|normal |major Depends on| |36135 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 [Bug 36135] Add tool to batch modify holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193667&action=edit Bug 41882: Enforce pickup location rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |Main Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193818&action=edit Bug 41882: Enfore pickup location rules To test: 1- Set ReservesControlBranch to 'item's home library' 2- Set Main library's 'Holds and bookings policies by item type' so that PASS items can only be picked up at Main 3- Place a hold on a bib whose only item is a PASS belonging to Main 4- Use the Batch hold modification tool to identify the hold you just placed 5- Update the pickup location to North. Note that the update is successful, and there's no indication that the pickup location is now a problem. 6- Check in Main's PASS, and note that the hold doesn't trigger to fill 7- APPLY PATCH, restart_all 8- Try again, this time the hold should fail to update at all. 9- You should see a new table with the 'Failed hold' in it, it should also include a 'Result' column which explains why the hold failed (New pickup location is invalid). 10- Try modifying a hold to an invalid pickup location, but also attempt to modify something else on the hold at the same time, like expiration date. 11- The hold should not modify anything. If the pickup location is invalid all other modifications should NOT happen on that hold. 12 - Play with the Table settings for the holds_modified tables, ensuring you can hide/show all the columns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193667|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 194175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194175&action=edit Bug 41882: Enforce pickup location rules To test: 1- Set ReservesControlBranch to 'item's home library' 2- Set Main library's 'Holds and bookings policies by item type' so that PASS items can only be picked up at Main 3- Place a hold on a bib whose only item is a PASS belonging to Main 4- Use the Batch hold modification tool to identify the hold you just placed 5- Update the pickup location to North. Note that the update is successful, and there's no indication that the pickup location is now a problem. 6- Check in Main's PASS, and note that the hold doesn't trigger to fill 7- APPLY PATCH, restart_all 8- Try again, this time the hold should fail to update at all. 9- You should see a new table with the 'Failed hold' in it, it should also include a 'Result' column which explains why the hold failed (New pickup location is invalid). 10- Try modifying a hold to an invalid pickup location, but also attempt to modify something else on the hold at the same time, like expiration date. 11- The hold should not modify anything. If the pickup location is invalid all other modifications should NOT happen on that hold. 12 - Play with the Table settings for the holds_modified tables, ensuring you can hide/show all the columns. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #193818|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a problem release notes| |with the batch hold | |modification tool that was | |allowing for holds to be | |batch updated to pickup | |location that are not | |valid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch fixes a problem |This fixes a problem with release notes|with the batch hold |the batch hold modification |modification tool that was |tool that was allowing for |allowing for holds to be |holds to be batch updated |batch updated to pickup |to pickup location that are |location that are not |not valid. |valid. | --- Comment #4 from David Nind <david@davidnind.com> --- Note: I updated the patch title - 'Enfore...' to 'Enforce...'. Testing notes (using KTD with the sample data): 1. Step 2: - "Main" = Centerville - Administration > Patrons and circulation > Circulation and fine rules > [select a library - Centerville] > scroll down the page to "Holds and bookings policies by item type for Centerville" - Instead of "PASS" item type, select: . Item type: Books . Hold policy: From any library . Hold and booking pickup library match: item's hold library . Rest as default - Click Add 2. Step 3: I used Programming Perl, 39999000011418 (one item, current and home library are Centerville) - Place hold for Mary - Used "Hold next available item" - Pickup location is Centerville 3. Step 4: Tools > Patrons and circulation > Batch modify holds - To select the (only) hold placed so far, select Centerville for the libraries field and then search 4. Step 5: - "North" = Midway - Select the hold (tick box) - Under the "Modify holds" heading change "New pickup library" to Midway 5. Step 6: checking in the item message says: Check in message 39999000011418: Programming Perl / Not checked out. 6. After apply the patch and restarting everything, delete the hold created in step 2 (step 3 in the test plan) 7. Step 10: using 'Batch modify holds' (if you try to modify the hold under the holds section for the record, you can't (the only pickup location is "Centerville")): - Same as step 3, select Centerville for batch modify holds - Select the only hold so far - Under modify holds section: . New pickup library: Midway . New hold note: add some text 8. Step 12: The link to configure the modified holds report table (Configure) goes to Circulation tables, not the modified_holds table under tools. But that was the case before the patch as well - so another bug. (I think the test plan should say modified_holds, instead of holds_modified - the URL is cgi-bin/koha/admin/columns_settings.pl?module=tools&page=holds&table=modified_holds) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198159&action=edit Bug 41882: Enforce pickup location rules To test: 1- Set ReservesControlBranch to 'item's home library' 2- Set Main library's 'Holds and bookings policies by item type' so that PASS items can only be picked up at Main 3- Place a hold on a bib whose only item is a PASS belonging to Main 4- Use the Batch hold modification tool to identify the hold you just placed 5- Update the pickup location to North. Note that the update is successful, and there's no indication that the pickup location is now a problem. 6- Check in Main's PASS, and note that the hold doesn't trigger to fill 7- APPLY PATCH, restart_all 8- Try again, this time the hold should fail to update at all. 9- You should see a new table with the 'Failed hold' in it, it should also include a 'Result' column which explains why the hold failed (New pickup location is invalid). 10- Try modifying a hold to an invalid pickup location, but also attempt to modify something else on the hold at the same time, like expiration date. 11- The hold should not modify anything. If the pickup location is invalid all other modifications should NOT happen on that hold. 12 - Play with the Table settings for the holds_modified tables, ensuring you can hide/show all the columns. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198293&action=edit Bug 41882: Enforce pickup location rules To test: 1- Set ReservesControlBranch to 'item's home library' 2- Set Main library's 'Holds and bookings policies by item type' so that PASS items can only be picked up at Main 3- Place a hold on a bib whose only item is a PASS belonging to Main 4- Use the Batch hold modification tool to identify the hold you just placed 5- Update the pickup location to North. Note that the update is successful, and there's no indication that the pickup location is now a problem. 6- Check in Main's PASS, and note that the hold doesn't trigger to fill 7- APPLY PATCH, restart_all 8- Try again, this time the hold should fail to update at all. 9- You should see a new table with the 'Failed hold' in it, it should also include a 'Result' column which explains why the hold failed (New pickup location is invalid). 10- Try modifying a hold to an invalid pickup location, but also attempt to modify something else on the hold at the same time, like expiration date. 11- The hold should not modify anything. If the pickup location is invalid all other modifications should NOT happen on that hold. 12 - Play with the Table settings for the holds_modified tables, ensuring you can hide/show all the columns. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198294&action=edit Bug 41882: (QA follow-up): Correct table settings values The prior patch incorrectly linked to 'circ' and 'holds' in the table settings, causing the Configure to take one to the wrong part of the table settings page and saved table settings to not be enforced. To test: 1: Apply all patches, restart_all 2: Attempt a batch modification of two or more holds such that at least one modification will succeed and at least one will fail 3: On the results page, confirm the Configure button on both the "Updated holds" and "Failed holds" tables correctly lead to the modified_holds table settings 4: Adjust settings for the modified_holds table 5: Confirm your changes are reflected in the results page for subsequent batch hold modifications Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198378&action=edit Bug 41882: (follow-up) Fix failing xt/tt_kohaTable_tidy.t test Patch from commit f5b800f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41882 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org