https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Corrected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 163021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163021&action=edit Bug 36135: Add new permission batch_modify_holds This patch adds new permission "batch_modify_holds". To test: 1. Apply this patch. 2. Run updatedatabase.pl. 3. Check that new permission was added to Patrons->Set permissions. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 163023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163023&action=edit Bug 36135: Add new tool to batch modify holds We sometimes need to modify holds due library closing down etc. For this we need tool to batch modify holds which allows us to filter holds and modify them. Tool allows users to select holds with following parameters: - expiration date -> if patron_expiration_date is set, it is used as main search filter -> otherwise expirationdate is used - library - found status - suspended status - suspend until date - hold note Users are able to modify following with tool: - expiration date (not expiration date set by patron) - pick up library - suspend status (only if hold has no found status) - suspend until date (only if suspend status is set) - hold note To test: 1. Apply this patch. 2. Navigate to new tool Tools->Batch modify holds. 3. Fill in some criteria to search holds with. => Confirm that holds found match your search criteria. 4. Set e.g. new expiration date for all or just selected holds. => Confirm that holds were modified as they should have. => Confirm this also from database. To test suspending holds with found status: 1. Find holds with found status. 2. Attempt to modify their suspend status. => Alert box with text "One or more holds have found status and can't be suspended." should be displayed. Play around, test different search compinations and modifications. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add tool to batch edit |Add tool to batch modify |expiration dates of holds |holds Status|ASSIGNED |Needs Signoff --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- We did some briefing on this and ended up adding ability to modify other fields as well, not just expiration date. I'll adjust bugs title accordingly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Failed QA --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi Emmi, I am running into the following error when attempting to use the Batch Modify Holds tool: Programming error - op 'list' must start with 'cud-' for POST http://localhost:8081/intranet/tools/batch_modify_holds.pl (referer: http://localhost:8081/cgi-bin/koha/tools/batch_modify_holds.pl) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163529|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163530&action=edit Bug 36135: (follow-up) Adjust for CSRF -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163021|0 |1 is obsolete| | --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163540&action=edit Bug 36135: Add new permission batch_modify_holds This patch adds new permission "batch_modify_holds". To test: 1. Apply this patch. 2. Run updatedatabase.pl. 3. Check that new permission was added to Patrons->Set permissions. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163023|0 |1 is obsolete| | --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163542&action=edit Bug 36135: Add new tool to batch modify holds We sometimes need to modify holds due library closing down etc. For this we need tool to batch modify holds which allows us to filter holds and modify them. Tool allows users to select holds with following parameters: - expiration date -> if patron_expiration_date is set, it is used as main search filter -> otherwise expirationdate is used - library - found status - suspended status - suspend until date - hold note Users are able to modify following with tool: - expiration date (not expiration date set by patron) - pick up library - suspend status (only if hold has no found status) - suspend until date (only if suspend status is set) - hold note To test: 1. Apply this patch. 2. Navigate to new tool Tools->Batch modify holds. 3. Fill in some criteria to search holds with. => Confirm that holds found match your search criteria. 4. Set e.g. new expiration date for all or just selected holds. => Confirm that holds were modified as they should have. => Confirm this also from database. To test suspending holds with found status: 1. Find holds with found status. 2. Attempt to modify their suspend status. => Alert box with text "One or more holds have found status and can't be suspended." should be displayed. Play around, test different search compinations and modifications. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163530|0 |1 is obsolete| | --- Comment #15 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163544&action=edit Bug 36135: (follow-up) Adjust for CSRF Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #18 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 163796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163796&action=edit Bug 36135: Add several new features This patch adds following new features to batch modify holds tool. - Do not automatically select login library as search param - Add biblios title and items barcode to found holds table - Add count of found holds at top of the table - Add ability to do not change pick up library - Display those hold rows with some found status in different color Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- This looks good but there are some small fixes to be made: 1. WARN installer/data/mysql/atomicupdate/bug_36135.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) Perltidy your atomicupdate 2. forbidden pattern: simple-quote string (line 312) Line 312: tools/batch_modify_holds.tt, needs double quotes, not single. 3. FAIL tt_valid lines 134 This probably needs to be something like: [% IF hold.found %] <tr class="highlighted-row"> [% ELSE %] <tr> [% END %] 4. Line 123: <th>Title</title> 5. Line 111: Missing a closing </div> 6. Overall there needs to be some improvement to the HTML: <label for="suspend_until">Expiration date:</label> <label for="suspend_until">Suspended until:</label> These should probably be <legend> not <label>. <li> elements inside of <li>? Not a blocker but should these be separate fieldsets? 7. These both use the ID "to" and they should use #expirationdate_to and #suspend_until_to, respectively. 56 <li> 57 <label for="expirationdate_to">To</label> 58 <input type="text" size="10" id="to" name="expirationdate_to" class="flatpickr"/> 59 </li> 91 <label for="suspend_until_to">To</label> 92 <input type="text" size="10" id="to" name="suspend_until_to" class="flatpickr"/> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164037|0 |1 is obsolete| | --- Comment #22 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 164051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164051&action=edit Bug 36135: Fix QA issues and add improvements This patch: - Fixes issues reported by qa-tool - Adds info about how many holds were modified - Add title and barcode columns to table of modified holds - Adds div with class "page-section" to "Modify holds" table Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163541|0 |1 is obsolete| | --- Comment #25 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164058&action=edit Bug 36135: Add links to the batch modify holds tool This patch adds links to new tool batch modify holds tool. To test: 1. Apply this patch. 2. Add patron permission "batch_modify_holds". 3. Login as chosen patron. 4. Navigate to Tools page. => Note there's a link "Batch modify holds". 5. Remove permission from user. => Link to new tool is not displayed. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163543|0 |1 is obsolete| | --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164060&action=edit Bug 36135: Allow using SQL results in batch modify holds tool This patch adds ability to use SQL results for batch holds tool if report contains column reserve_id. To test: 1. Create SQL report which contains column for reserve_id. => e.g "SELECT reserve_id FROM reserves limit 10". 2. Run report. 3. Over report select "Batch operations" should be displayed and under that there should be option "Batch modify holds". 4. Click "Batch modify holds" option. => Confirm that holds displayed in "Batch mofidy holds" tool are same as found with your report. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163796|0 |1 is obsolete| | --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164062&action=edit Bug 36135: Add several new features This patch adds following new features to batch modify holds tool. - Do not automatically select login library as search param - Add biblios title and items barcode to found holds table - Add count of found holds at top of the table - Add ability to do not change pick up library - Display those hold rows with some found status in different color Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #31 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I like this a lot - self contained and makes minimal changes, the patches are clean and easy to read, but I think we need to consider some things here before this moves ahead Must fix: The JS alerts to prevent submission fire an alert per warning, so you need to click through several if you make a mistake - these should be combined into a single alert There is no way to see the limits you have placed on your search - I think these need to be shown to the user, ideally they would be editable, but showing them would be a start Should fix: While I like the idea of minimalizing data for privacy, excluding the borrower info on the holds feels a bit too far. Ideally this would be under columns configuration, and we have patron-title.inc for showing borrower info only to staff who should see it. The current column selection feels The display should be paginated, ideally it would use the holds API to load the holds to ensure performance, as scrolling can get really long really fast. It would be nice too to be able to select all in a filtered search - right now 'Select all' selects even those not visible in the table Could fix: If implemented with the datatables API this could then work like the patron search, with filters present on the page. The batch edit implies more batch actions - cancellation, reverting, etc. but these can all be follow-ups I think -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #33 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Moving on with this really depends on whether API is used or not in this page. Otherwise adding it later would probably mean making same work again with some of the features Nick suggested. As for the filters displayed on page, I think it would be better if they are displayed like in item search page behind "Edit search" button. Putting them on margin just doesn't seem (visually) good idea since there are other links there already. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37032 [Bug 37032] REST API: Unable to call item info via holds endpoint -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Looks like the templates now need to be adjusted for Bootstrap 5 changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177519&action=edit Bug 36135: Fix breadcrumbs/Bootstrap issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177959&action=edit Bug 36135: Fix some markup errors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164058|0 |1 is obsolete| | --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177961&action=edit Bug 36135: Add links to the batch modify holds tool This patch adds links to new tool batch modify holds tool. To test: 1. Apply this patch. 2. Add patron permission "batch_modify_holds". 3. Login as chosen patron. 4. Navigate to Tools page. => Note there's a link "Batch modify holds". 5. Remove permission from user. => Link to new tool is not displayed. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164060|0 |1 is obsolete| | --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177963&action=edit Bug 36135: Allow using SQL results in batch modify holds tool This patch adds ability to use SQL results for batch holds tool if report contains column reserve_id. To test: 1. Create SQL report which contains column for reserve_id. => e.g "SELECT reserve_id FROM reserves limit 10". 2. Run report. 3. Over report select "Batch operations" should be displayed and under that there should be option "Batch modify holds". 4. Click "Batch modify holds" option. => Confirm that holds displayed in "Batch mofidy holds" tool are same as found with your report. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164062|0 |1 is obsolete| | --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177965&action=edit Bug 36135: Add several new features This patch adds following new features to batch modify holds tool. - Do not automatically select login library as search param - Add biblios title and items barcode to found holds table - Add count of found holds at top of the table - Add ability to do not change pick up library - Display those hold rows with some found status in different color Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177518|0 |1 is obsolete| | --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177967&action=edit Bug 36135: Report errors to a modal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177959|0 |1 is obsolete| | --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177969&action=edit Bug 36135: Fix some markup errors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163021|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177975&action=edit Bug 36135: API the found_holds table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #53 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This is still a work in progress but want to mention a few things: 1. Handling state across paginated AJAX table is hard, for me at least. So, I don't think we actually need checkboxes. Instead, you do the search and can bulk update everything that is returned. There should be an option to refine the search. 2. Instead of handling errors with JS before you submit I think can simply report back on holds that were not updated. Example, trying to suspend a waiting hold. 3. The report table in the final step should report back successes and errors, so I think it cannot be an API/AJAX table since you can't get that data from the API. But maybe a standard DataTable? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #55 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 177982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177982&action=edit Bug 36135: Add more API functionality to display holds to modify -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #57 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- There seems to be a way to save the state of checkboxes with pagination, at least I was able to do this via patron search. So we can probably use same method with this also. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177981|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #58 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Emmi Takkinen from comment #57)

There seems to be a way to save the state of checkboxes with pagination, at least I was able to do this via patron search. So we can probably use same method with this also.

Emmi, my apologies here. Sorry for the confusion, I meant to help here but looks like I only got in the way! Maybe using something like this to manage state? https://datatables.net/extensions/select/index Lucas -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163021|0 |1 is obsolete| | --- Comment #60 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178154&action=edit Bug 36135: Add new permission batch_modify_holds This patch adds new permission "batch_modify_holds". To test: 1. Apply this patch. 2. Run updatedatabase.pl. 3. Check that new permission was added to Patrons->Set permissions. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177962|0 |1 is obsolete| | --- Comment #62 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178156&action=edit Bug 36135: Add new tool to batch modify holds We sometimes need to modify holds due library closing down etc. For this we need tool to batch modify holds which allows us to filter holds and modify them. Tool allows users to select holds with following parameters: - expiration date -> if patron_expiration_date is set, it is used as main search filter -> otherwise expirationdate is used - library - found status - suspended status - suspend until date - hold note Users are able to modify following with tool: - expiration date (not expiration date set by patron) - pick up library - suspend status (only if hold has no found status) - suspend until date (only if suspend status is set) - hold note To test: 1. Apply this patch. 2. Navigate to new tool Tools->Batch modify holds. 3. Fill in some criteria to search holds with. => Confirm that holds found match your search criteria. 4. Set e.g. new expiration date for all or just selected holds. => Confirm that holds were modified as they should have. => Confirm this also from database. To test suspending holds with found status: 1. Find holds with found status. 2. Attempt to modify their suspend status. => Alert box with text "One or more holds have found status and can't be suspended." should be displayed. Play around, test different search compinations and modifications. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177964|0 |1 is obsolete| | --- Comment #64 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178158&action=edit Bug 36135: (follow-up) Adjust for CSRF Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177966|0 |1 is obsolete| | --- Comment #66 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178160&action=edit Bug 36135: Fix QA issues and add improvements This patch: - Fixes issues reported by qa-tool - Adds info about how many holds were modified - Add title and barcode columns to table of modified holds - Adds div with class "page-section" to "Modify holds" table Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #68 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178162&action=edit Bug 36135: Fix some markup errors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #70 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178164&action=edit Bug 36135: Add ability to fetch patron info via API holds endpoint -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #72 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178166&action=edit Bug 36135: Save state of selected checkboxes and fix modifying suspend -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #74 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- There is still some issues with modifying suspend status. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #77 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178954&action=edit Bug 36135: Batch clear hold notes and use select2 in multiple filters This patch adds ability to clear hold note from all selected holds. It also adds select2 to libraries and holds status filters. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #78 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Sorry Emmi, patches don't apply to current main. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #80 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I've just tried to apply these and was also unable. This is on my ktd system, on main, immediately after a git pull. Specifically: Applying: Bug 36135: Add links to the batch modify holds tool Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 36135: Add links to the batch modify holds tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #82 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #81)

(In reply to Andrew Fuerste-Henry from comment #80)

...

I've just tried to apply these and was also unable. This is on my ktd system, on main, immediately after a git pull.

Specifically: Applying: Bug 36135: Add links to the batch modify holds tool Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 36135: Add links to the batch modify holds tool

Ah, I see. I'm using git-installation for testing, so I guess it and ktd differ from each other somehow.

And thinking this a little more, it's not possible that they differ. I'll try rebase again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178155|0 |1 is obsolete| | --- Comment #84 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179029&action=edit Bug 36135: Add links to the batch modify holds tool This patch adds links to new tool batch modify holds tool. To test: 1. Apply this patch. 2. Add patron permission "batch_modify_holds". 3. Login as chosen patron. 4. Navigate to Tools page. => Note there's a link "Batch modify holds". 5. Remove permission from user. => Link to new tool is not displayed. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178157|0 |1 is obsolete| | --- Comment #86 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179031&action=edit Bug 36135: Allow using SQL results in batch modify holds tool This patch adds ability to use SQL results for batch holds tool if report contains column reserve_id. To test: 1. Create SQL report which contains column for reserve_id. => e.g "SELECT reserve_id FROM reserves limit 10". 2. Run report. 3. Over report select "Batch operations" should be displayed and under that there should be option "Batch modify holds". 4. Click "Batch modify holds" option. => Confirm that holds displayed in "Batch mofidy holds" tool are same as found with your report. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178159|0 |1 is obsolete| | --- Comment #88 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179033&action=edit Bug 36135: Add several new features This patch adds following new features to batch modify holds tool. - Do not automatically select login library as search param - Add biblios title and items barcode to found holds table - Add count of found holds at top of the table - Add ability to do not change pick up library - Display those hold rows with some found status in different color Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #90 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179035&action=edit Bug 36135: Report errors to a modal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178162|0 |1 is obsolete| | --- Comment #92 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179037&action=edit Bug 36135: Fix some markup errors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178164|0 |1 is obsolete| | --- Comment #94 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179039&action=edit Bug 36135: Add ability to fetch patron info via API holds endpoint -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178167|0 |1 is obsolete| | --- Comment #96 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179041&action=edit Bug 36135: Save state of selected checkboxes and fix modifying suspend -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #98 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- There was something wrong with patches I had in my development branch, they applied cleanly against current main. But after creating a new clean branch and applying patches from Bugzilla I got same merge conflict as Andrew. I had also dropped one of the patches at some point. These should now apply, but I was wondering do they still need some clean up to match changes made for tidying up the whole code base (bug 38664). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #100 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179082&action=edit Bug 36135: (follow-up) Fix link style on guided report page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |e.betemps@gmail.com --- Comment #101 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, I created 3 holds pour the same patron Steps 1 to 4 are ok but when I click on the "Batch modify holds" option, the Tolls page doesn't list any hold I just see the staff interface, the title of this tool (Batch modify holds) but no hold is displayed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #103 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmanuel Bétemps from comment #101)

Hi,

I created 3 holds pour the same patron Steps 1 to 4 are ok but when I click on the "Batch modify holds" option, the Tolls page doesn't list any hold I just see the staff interface, the title of this tool (Batch modify holds) but no hold is displayed

I'm guessing you tested importing SQL results to tool? We noticed the same problem a while ago and I'm think it has something to do with API. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #107 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Lucas Gass (lukeg) from comment #106)

I can select checkboxes from multiple pages now, but when click 'Modify holds' only the ones on my current page are handled. Oof, so it seems. I'll fix it with other problems Andrew pointed out.

Also, we have Bug 23258 which creates/cancels holds. It would be great if we could bring these 2 bugs together, instead of having 2 seperate but similar features? I see your point and agree, these should probably be one and same tool. I'm just wondering what's the best plan here, push tools as they are to main (when they are ready to be pushed to main) and then "merge" them. Or push one to main and then add other to it? Or merge them before the push?

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #109 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Lucas Gass (lukeg) from comment #106)

I can select checkboxes from multiple pages now, but when click 'Modify holds' only the ones on my current page are handled.

Looked into this and it seems to be the default for datatables to handle data like this. I tried turning option "serverSide" as false as suggested in the DataTables forum to fetch all data from table, but no luck, it still changes only the holds in current page. We could fetch hold_ids from localStorage, but then we lose ability to check in front-end if modification is possible (e.g. if user tries to suspend hold with found status) and we can't display error message pop-up before attempting to modify holds. I came up with following ways to handle this: 1) Fetch found and suspended status for selected holds with API and display error message as pop-up like it is currently displayed. 2) Make check from back-end and send error message from there back to front. 3) Do not display error message, but do not modify holds which can't be modified either. Show "Following holds couldn't be modified. Reason:..." in "Holds modified" page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #111 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 183151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183151&action=edit Bug 36135: Add several fixes This patch adds several fixes and improvements: -Allow open-ended search To test: 1. Find holds to modify and fill either "Expiration date from" field or "Expiration date to" field. 2. Click "Search" button. => Confirm that your search contains holds that match your search. -Suspend hold if new suspend until date is set To test: 1. Find some holds to modify which can be suspended. 2. Select holds to modify from your search and set new suspended date for them. Do not select new suspended status from "Suspend holds" dropdown. 3. Click "Modify holds" button. => Confirm that pop-up preventing modificating holds suspend date without setting new suspend status is not displayed and holds are now suspended with new suspended until date. -Add word "and" to suspend date filter message -Change "form" to "cud-form" in guided_reports_start.tt to prevent programming error message Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179028|0 |1 is obsolete| | --- Comment #112 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183294&action=edit Bug 36135: Add new permission batch_modify_holds Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179038|0 |1 is obsolete| | --- Comment #114 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183296&action=edit Bug 36135: Embed items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179082|0 |1 is obsolete| | --- Comment #116 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183298&action=edit Bug 36135: (follow-up) Fix link style on guided report page Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #118 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183300&action=edit Bug 36135: Fix forbidden pattern -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179036|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183294|Bug 36135: Add new |Bug 36135: Add description|permission |batch_modify_holds |batch_modify_holds | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #119 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I squashed some of these patches and am resetting to NSO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #121 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183306&action=edit Bug 36135: Add ability to batch modify holds TO TEST: 0. APPLY PATCHES, updatedatabase, restart_all 1. Create a user with limited permissions, making sure you give them the "batch_modify_holds" permission 2. Login as chosen patron. 3. Navigate to Tools page. 4. Note there's a link "Batch modify holds". 5. Remove permission from user. 6. Link to new tool is not displayed. 7. Navigate to new tool Tools->Batch modify holds. 8. Fill in some criteria to search holds with. 9. Confirm that holds found match your search criteria. 10. Set e.g. new expiration date for all or just selected holds. 11. Confirm that holds were modified as they should have. 12. Confirm this also from database. 13. Find holds with a found/waiting status. 14. Attempt to modify their suspend status. 15. Alert box with text "One or more holds have found status and can't be suspended." should be displayed. 16. Play around, test different modifications. 17. Create SQL report which contains column for reserve_id. 18. e.g "SELECT reserve_id FROM reserves limit 10". 19.. Run report. 20. Over report select "Batch operations" should be displayed and under that there should be option "Batch modify holds". 21. Click "Batch modify holds" option. 22. Confirm that holds displayed in "Batch mofidy holds" tool are same as found with your report. 23. Do a holds search that will bring up multiple pages of results 24. Try selecting some holds from different pages to modify 25. Ensure all selected holds are being modified 26. Play around, test different modifications. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183300|0 |1 is obsolete| | --- Comment #123 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183308&action=edit Bug 36135: Fix forbidden pattern Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183297|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183295|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #124 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- squashed patches and added complete test plan, reading for testing! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #125 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #124)

squashed patches and added complete test plan, reading for testing!

Noting that this all works as intended by chokes if you try to modify a lot of holds at once due to a URI length error. Confirmed it works with about holds but dies with about 1000, so the issue is somewhere in there :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #127 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #126)

(In reply to Andrew Fuerste-Henry from comment #125)

...

(In reply to Lucas Gass (lukeg) from comment #124)

...

squashed patches and added complete test plan, reading for testing!

Noting that this all works as intended by chokes if you try to modify a lot of holds at once due to a URI length error. Confirmed it works with about holds but dies with about 1000, so the issue is somewhere in there :)

This seems to be a dataTable issue. All of the modified hold ID's are send back to be filtered and the number of IDs seems to be too much for dataTables when we approach 1000 modified holds.

I think we could make the modification results table not be generated from the API. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #128 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183771&action=edit Bug 36135: Make modified_holds table not use the API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #129 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 183893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183893&action=edit Bug 36135: Correct tools-menu category logic -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all task changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183306|0 |1 is obsolete| | --- Comment #133 from Jason Robb <jrobb@sekls.org> --- Created attachment 183960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183960&action=edit Bug 36135: Add ability to batch modify holds TO TEST: 0. APPLY PATCHES, updatedatabase, restart_all 1. Create a user with limited permissions, making sure you give them the "batch_modify_holds" permission 2. Login as chosen patron. 3. Navigate to Tools page. 4. Note there's a link "Batch modify holds". 5. Remove permission from user. 6. Link to new tool is not displayed. 7. Navigate to new tool Tools->Batch modify holds. 8. Fill in some criteria to search holds with. 9. Confirm that holds found match your search criteria. 10. Set e.g. new expiration date for all or just selected holds. 11. Confirm that holds were modified as they should have. 12. Confirm this also from database. 13. Find holds with a found/waiting status. 14. Attempt to modify their suspend status. 15. Alert box with text "One or more holds have found status and can't be suspended." should be displayed. 16. Play around, test different modifications. 17. Create SQL report which contains column for reserve_id. 18. e.g "SELECT reserve_id FROM reserves limit 10". 19.. Run report. 20. Over report select "Batch operations" should be displayed and under that there should be option "Batch modify holds". 21. Click "Batch modify holds" option. 22. Confirm that holds displayed in "Batch mofidy holds" tool are same as found with your report. 23. Do a holds search that will bring up multiple pages of results 24. Try selecting some holds from different pages to modify 25. Ensure all selected holds are being modified 26. Play around, test different modifications. Sponsored-by: Koha-Suomi Oy Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183308|0 |1 is obsolete| | --- Comment #135 from Jason Robb <jrobb@sekls.org> --- Created attachment 183962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183962&action=edit Bug 36135: Fix forbidden pattern Sponsored-by: Koha-Suomi Oy Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183893|0 |1 is obsolete| | --- Comment #137 from Jason Robb <jrobb@sekls.org> --- Created attachment 183964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183964&action=edit Bug 36135: Correct tools-menu category logic Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 --- Comment #140 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Thank you Lucas for taking over this! Our libraries have used this tool for a while now and they have pointed out that it should be possible to also modify holds with different status. We thought this should be prevented when we were planning what users should be able to do with the tool but now this has quickly become an issue when holds need to be modified etc. due library being closed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183959|0 |1 is obsolete| | --- Comment #141 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185051&action=edit Bug 36135: Add batch_modify_holds permissions Sponsored-by: Koha-Suomi Oy Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183961|0 |1 is obsolete| | --- Comment #143 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185053&action=edit Bug 36135: Fix syntax error in permissions.inc Sponsored-by: Koha-Suomi Oy Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183963|0 |1 is obsolete| | --- Comment #145 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185055&action=edit Bug 36135: Make modified_holds table not use the API Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183965|0 |1 is obsolete| | --- Comment #147 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185057&action=edit Bug 36135: (follow-up) Fix suspension search and other improvements This patch tries to fix the hold suspension search by copying the code from the expiration date search function. The patch also makes these changes: - Change page title to use i18n functions - Add specific breadcrumb for results page - Update headings between search and results page - Correct table settings (definition was missing from columns_settings.yml - Correct capitalization (e.g. "Pickup location" instead of "Pickup Location" - Use include files for displaying title and patron in update results - Add subtitle and medium to title in search results - Remove quotes from DataTables option names - Add hold date to the search results view. - Without a specified default sort, the table will sort the first column. Since the first column is checkboxes, we ought to explicitly set a default sorting column. I thought hold date seemed like a better default than title. Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #152 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Changing to 'Signed Off' (by Jason Robb <jrobb@sekls.org>) as it was previous to the FQA. -- You are receiving this mail because: You are watching all bug changes.