[Bug 9748] New: noitemlinks not being enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Bug ID: 9748 Summary: noitemlinks not being enforced Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15895&action=edit Bug 9748 - noitemlinks not being enforced It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. This is a problem for SCO kiosks where all the navigation controls are hidden. Clicking the link means leaving the SCO module and not being able to get back. Test plan: 1) Run SCO module, check for item links 2) Apply patch 3) Run SCO module, note that the items no longer have links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15895|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 16085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16085&action=edit Bug 9748: don't link items in SCO checkout list back to main OPAC It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. This is a problem for SCO kiosks where all the navigation controls are hidden. Clicking the link means leaving the SCO module and not being able to get back. Test plan: 1) Run SCO module, check for item links 2) Apply patch 3) Run SCO module, note that the items no longer have links Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I don't understand why links are hidden and how they can be shown (when noitemlinks is false?), but it was the excepted behavior before the conversion to TT. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16085|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16405&action=edit Bug 9748: don't link items in SCO checkout list back to main OPAC It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. This is a problem for SCO kiosks where all the navigation controls are hidden. Clicking the link means leaving the SCO module and not being able to get back. Test plan: 1) Run SCO module, check for item links 2) Apply patch 3) Run SCO module, note that the items no longer have links Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9748 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org