[Bug 7875] New: Pending suggestion link (the numbers) from staff client home directs to accepted suggestions instead of pending
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 Priority: P5 - low Change sponsored?: --- Bug ID: 7875 Assignee: henridamien@koha-fr.org Blocks: 7259 Summary: Pending suggestion link (the numbers) from staff client home directs to accepted suggestions instead of pending QA Contact: koha.sekjal@gmail.com Severity: trivial Classification: Unclassified OS: All Reporter: wizzyrea@gmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Acquisitions Product: Koha The pending approvals count on the staff client home page directs to the "accepted" tab of suggestion management instead of the "pending" tab. It's really a minor thing, but it did manage to confuse several people here, so thought I'd report it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien@koha-fr.org |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16000&action=edit Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions Pending suggestion link from staff client home directs to accepted suggestions instead of pending suggestions. This patch changes the link so that it directs to pending suggestions. To test : 1 - create 2 suggestions, accept 1 of them 2 - click on the link on home page M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16000|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16046&action=edit [SIGNED-OFF] Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions Pending suggestion link from staff client home directs to accepted suggestions instead of pending suggestions. This patch changes the link so that it directs to pending suggestions. To test : 1 - create 2 suggestions, accept 1 of them 2 - click on the link on home page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16046|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16201&action=edit Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions Pending suggestion link from staff client home directs to accepted suggestions instead of pending suggestions. This patch changes the link so that it directs to pending suggestions. To test : 1 - create 2 suggestions, accept 1 of them 2 - click on the link on home page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Trivial change. Should normally work. (I had somehow 2 old suggestions that were counted on the home page, but were not displayed under Pending. Could not reproduce. After deleting them and adding new ones, no problems.) Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- On home page, I think you see all pending suggestions for all branches... It could be fixed in an other patch if you think it is not the good behavior. Maybe home page could say "XX suggestions for all branches, and YY for your branch" ? M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #5)
On home page, I think you see all pending suggestions for all branches... It could be fixed in an other patch if you think it is not the good behavior. Maybe home page could say "XX suggestions for all branches, and YY for your branch" ?
M. Saby
Do not know if they were from another branch and I deleted them in mysql :) If you could work further on this, great. But open up a new report for that. This patch can go in as-is IMO. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7875 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org