[Bug 5672] New: Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Summary: Search History Should have RSS Feeds Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/opac-search-history.pl OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 It would be great to add a column to the search history tab in the OPAC with an RSS feed next to each search to allow patrons to easily subscribe to each of their saved searches (since each one has an RSS feed already it should be easy to add). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- This would still be a cool feature and probably not that hard to implement since the searches all have RSS feeds already. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #2 from Viktor Sarge <viktor.sarge@regionhalland.se> --- *** Bug 11968 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #3 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 28881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28881&action=edit 5672 Gives RSS icons to search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28881|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 28905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28905&action=edit [SIGNED-OFF] 5672 Gives RSS icons to search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, oleonard@myacpl.org --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- All looks good. But one icon in a cell does not seem very elegant. Maybe Owen has a brainwave? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- I'd say just have the RSS icon to the left of the search terms without a header row. The icon is pretty clear on it's own. But I signed off cause it got the functionality in there and figured a follow up could make it pretty. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #7 from Viktor Sarge <viktor.sarge@regionhalland.se> --- (In reply to Nicole C. Engard from comment #6)
I'd say just have the RSS icon to the left of the search terms without a header row. The icon is pretty clear on it's own. But I signed off cause it got the functionality in there and figured a follow up could make it pretty.
To the left of the search sounds good. It's an easy fix but what's the workflow for fixing that? Should I submit a new patch to this thread even though it's signed off? Or do I have to wait until the patch is pushed to master until I can pick it up and change it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Viktor Sarge from comment #7)
To the left of the search sounds good. It's an easy fix but what's the workflow for fixing that? Should I submit a new patch to this thread even though it's signed off? Or do I have to wait until the patch is pushed to master until I can pick it up and change it?
You can submit a follow-up on this bug report and switch the status back to "Needs Signoff". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #9 from Viktor Sarge <viktor.sarge@regionhalland.se> ---
You can submit a follow-up on this bug report and switch the status back to "Needs Signoff".
Seems I have messed something up with my git. It won't add the file again since it thinks nothing is changed. Working on it since it RSS icons to the left of the search instead looks quite a bit better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #10 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 28983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28983&action=edit Bug 5672 Gives RSS icons to search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28905|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 28984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28984&action=edit 5672 Gives RSS icons to search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28983|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 28985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28985&action=edit Bug 5672 Gives RSS icons to search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search History Should have |Biblio search history |RSS Feeds |should have RSS Feeds -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Biblio search history |Catalog search history |should have RSS Feeds |should have RSS Feeds -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28984|0 |1 is obsolete| | Attachment #28985|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29010&action=edit Bug 5672 Gives RSS icons to catalog search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29011&action=edit Bug 5672 Gives RSS icons to catalog search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- I updated bug report summary and commit message to highlight that the patches only affect catalog search history (not authority). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29011|0 |1 is obsolete| | --- Comment #16 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 29018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29018&action=edit [SIGNED-OFF] Bug 5672 Gives RSS icons to catalog search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- Sorry, I missed an update in my email and didn't check here - so I signed off after QA again :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Viktor! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Catalog search history |Add RSS feeds to catalog |should have RSS Feeds |search history -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 kholt@roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholt@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org