[Bug 41558] New: Broken links to tab on opac-user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Bug ID: 41558 Summary: Broken links to tab on opac-user Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 33895, 37972 We have different implemented solution to select a tab on opac-user: * a "tab" variable (from bug 37972), it's never used * several variables passed from the controller to the template, depending on the tab to select (it works and is used) * use of anchors (it does not work and is used) We should fix and standardize it. I've linked to several reports that seem to conflict with each others. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 [Bug 33895] Use template wrapper for tabs: OPAC user summary https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37972 [Bug 37972] Allow selection of tab in patron's summary table by query param -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191048&action=edit Bug 41558: Fix and standardize links to tab on opac-user We have different implemented solution to select a tab on opac-user: * a "tab" variable (from bug 37972), it's never used * several variables passed from the controller to the template, depending on the tab to select (it works and is used) * use of anchors (it does not work and is used) We should fix and standardize it. I've linked to several reports that seem to conflict with each others. This patch suggests to have a "tab" variable Test plan: Confirm that the different links to tab to opac-user are not using a query parameter to pass the tab to select, e.g. from the opac-main page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191048|0 |1 is obsolete| | --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 191049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191049&action=edit Bug 41558: Fix and standardize links to tab on opac-user We have different implemented solution to select a tab on opac-user: * a "tab" variable (from bug 37972), it's never used * several variables passed from the controller to the template, depending on the tab to select (it works and is used) * use of anchors (it does not work and is used) We should fix and standardize it. I've linked to several reports that seem to conflict with each others. This patch suggests to have a "tab" variable Test plan: Confirm that the different links to tab to opac-user are not using a query parameter to pass the tab to select, e.g. from the opac-main page. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41582 [Bug 41582] Tidy kohaTable block - opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 191234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191234&action=edit Bug 41558: Fix and standardize links to tab on opac-user We have different implemented solution to select a tab on opac-user: * a "tab" variable (from bug 37972), it's never used * several variables passed from the controller to the template, depending on the tab to select (it works and is used) * use of anchors (it does not work and is used) We should fix and standardize it. I've linked to several reports that seem to conflict with each others. This patch suggests to have a "tab" variable Test plan: Confirm that the different links to tab to opac-user are not using a query parameter to pass the tab to select, e.g. from the opac-main page. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I've added my sign-off, in case Paul's can be counted as QA. Testing notes (using KTD): 1. Tabs are still directly accessible, for example: /cgi-bin/koha/opac-user.pl?tab=opac-user-recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Test plan: Confirm that the different links to tab to opac-user are not using a query parameter to pass the tab to select, e.g. from the opac-main page. Unclear what this means since you are passing the tab in a query param. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191234|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 194097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194097&action=edit Bug 41558: Fix and standardize links to tab on opac-user We have different implemented solution to select a tab on opac-user: * a "tab" variable (from bug 37972), it's never used * several variables passed from the controller to the template, depending on the tab to select (it works and is used) * use of anchors (it does not work and is used) We should fix and standardize it. I've linked to several reports that seem to conflict with each others. This patch suggests to have a "tab" variable Test plan: Confirm that the different links to tab to opac-user are not using a query parameter to pass the tab to select, e.g. from the opac-main page. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes and standardizes release notes| |links to tabs for the | |patron summary section in | |the OPAC (such as Checked | |out, Overdue, Charges, | |Holds, and so on). | | | |In the past, we have used | |several different ways | |(some that work, some that | |don't) to construct the | |links to the tabs. | | | |Now, to directly link to a | |tab in the summary section, | |add ?tab=opac-user-* to the | |URL when you are in the | |summary section (where * = | |tab name from the anchor | |when you hover over the | |tab, for example checkouts | |(for Checked out), overdues | |(for Overdue), fines (for | |Overdue), recalls (for | |Recalls)). --- Comment #8 from David Nind <david@davidnind.com> --- I attempted to write a release note for this one, and came away confused (even though I signed it off!). 1. What should go in the release notes? 2. Will patrons notice anything different? (not directly I think, unless the "old" way resulted in broken links) 3. Is this more for developers, so they construct things consistently? Experimenting/testing notes (using KTD): 1. Add a hold for a patron 2. Add a charge for a patron 3. Check an item out to a patron 4. Checkout another item to a patron so that it is overdue (use the checkout settings to set the due date as in the past) 5. Place a recall (enable UseRecalls, set circulation rules, check out an item to another patron, place a recall for the item) 6. View the patron's account > Summary section 7. There are tabs for Checked out, Charges, Holds, Recalls 8. When on the summary page (/cgi-bin/koha/opac-user.pl): - Checked out: /cgi-bin/koha/opac-user.pl#opac-user-checkouts_panel - Overdue: /cgi-bin/koha/opac-user.pl#opac-user-overdues_panel - Charges: /cgi-bin/koha/opac-user.pl#opac-user-fines_panel - Holds: /cgi-bin/koha/opac-user.pl#opac-user-holds_panel - Recalls: /cgi-bin/koha/opac-user.pl#opac-user-recalls_panel 9. If you click on any of the tabs, the URL doesn't change (remains as /cgi-bin/koha/opac-user.pl) 10. However, if you try to directly access one of the tabs in a new window with a URL in step 6, you remain on the Checked out tab. 11. If you use the direct URLs shown in the diff, you go directly to the tabs: - Checked out - main tab, so default anyway: /cgi-bin/koha/opac-user.pl?tab=opac-user-checkouts - Overdue: /cgi-bin/koha/opac-user.pl?tab=opac-user-overdues - Charges: /cgi-bin/koha/opac-user.pl?tab=opac-user-fines - Holds: /cgi-bin/koha/opac-user.pl?tab=opac-user-holds - Holds: /cgi-bin/koha/opac-user.pl?tab=opac-user-recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.04 |26.05.00,25.11.04,25.05.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: this was pushed for 25.05.11. --LE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I'm not sure this should be included in an LTS, not backporting to 24.11.x, please tell me if you guys think this should -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- OPAC change, not backporting to 24.11 LTS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org