https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190254&action=edit Bug 41393: Set the correct reply to address for advance notices This patch additionally fetches the reply to address for advance notices To test: 1 - Have some issues that will be due soon for a patron(s) Checkout with the due date set to tomorrow 2 - Verify the patron(s) have an email defined, verify the issuing branch has a reply to set 3 - Verify the patron(s) have messaging preference set to receive Advance notices by email 1 day in advance 4 - perl misc/cronjobs/advance_notices.pl -v -c 5 - Check the message queue SELECT * FROM message_queue WHERE borrowernumber={##} 6 - Note no rpely to is set 7 - Apply patch 8 - perl misc/cronjobs/advance_notices.pl -v -c 9 - Check the message queue 10 - Confirm newer message has the reply to populated 11 - Ensure the issued item has a different homebranch with a reply to address se 12 - perl misc/cronjobs/advance_notices.pl -v -c --frombranch item-homebranch 13 - Confirm message has correct reply to 14 - Set patron to want digest in messaging preferences 15 - Generate notices 16 - Confirm digets has the right reply to -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31281 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190254|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 190312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190312&action=edit Bug 41393: Set the correct reply to address for advance notices This patch additionally fetches the reply to address for advance notices To test: 1 - Have some issues that will be due soon for a patron(s) Checkout with the due date set to tomorrow 2 - Verify the patron(s) have an email defined, verify the issuing branch has a reply to set 3 - Verify the patron(s) have messaging preference set to receive Advance notices by email 1 day in advance 4 - perl misc/cronjobs/advance_notices.pl -v -c 5 - Check the message queue SELECT * FROM message_queue WHERE borrowernumber={##} 6 - Note no rpely to is set 7 - Apply patch 8 - perl misc/cronjobs/advance_notices.pl -v -c 9 - Check the message queue 10 - Confirm newer message has the reply to populated 11 - Ensure the issued item has a different homebranch with a reply to address se 12 - perl misc/cronjobs/advance_notices.pl -v -c --frombranch item-homebranch 13 - Confirm message has correct reply to 14 - Set patron to want digest in messaging preferences 15 - Generate notices 16 - Confirm digets has the right reply to Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190312|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 193515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193515&action=edit Bug 41393: Set the correct reply to address for advance notices This patch additionally fetches the reply to address for advance notices To test: 1 - Have some issues that will be due soon for a patron(s) Checkout with the due date set to tomorrow 2 - Verify the patron(s) have an email defined, verify the issuing branch has a reply to set 3 - Verify the patron(s) have messaging preference set to receive Advance notices by email 1 day in advance 4 - perl misc/cronjobs/advance_notices.pl -v -c 5 - Check the message queue SELECT * FROM message_queue WHERE borrowernumber={##} 6 - Note no rpely to is set 7 - Apply patch 8 - perl misc/cronjobs/advance_notices.pl -v -c 9 - Check the message queue 10 - Confirm newer message has the reply to populated 11 - Ensure the issued item has a different homebranch with a reply to address se 12 - perl misc/cronjobs/advance_notices.pl -v -c --frombranch item-homebranch 13 - Confirm message has correct reply to 14 - Set patron to want digest in messaging preferences 15 - Generate notices 16 - Confirm digets has the right reply to Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tidied inline -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- please add release notes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41393 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Not backporting to 24.11 LTS for sake of behaviour stability -- You are receiving this mail because: You are watching all bug changes.