[Bug 7882] New: move or reorder 6xx and 7xx fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Priority: P5 - low Change sponsored?: --- Bug ID: 7882 Assignee: gmcharlt@gmail.com Summary: move or reorder 6xx and 7xx fields QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: melia@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Would like to be able to move or reorder 6xx and 7xx fields. The only way to change the order of 700s is to copy or cut /paste. We would like to be able to easily move production people on DVDs to below the actors. Or change the order of 6xx fields to more accurately describe the subject of an item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |savitra.sirohi@osslabs.biz Assignee|gmcharlt@gmail.com |savitra.sirohi@osslabs.biz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |elliott@bywatersolutions.co | |m Assignee|savitra.sirohi@osslabs.biz |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #1 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 13184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13184&action=edit Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Elliott Davis <elliott@bywatersolutions.com> --- oops forgot to set the correct flag -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13184|0 |1 is obsolete| | --- Comment #3 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 13556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13556&action=edit Rebase for master http://bugs.koha-community.org/show_bug.cgi?id=7882 http://bugs.koha-community.org/show_bug.cgi?id=7883 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- The reordering works great, but the clone and delete tag links appear to be broken. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch complexity|--- |Large patch --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- I wanted to add myself to the CC list, but couldn't without setting a patch complexity - please update the complexity if I guessed wrong. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13556|0 |1 is obsolete| | Attachment #13556|Rebase for master |Rebase for master -- DO NOT description| |USE -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13184|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13184|0 |1 is obsolete| | --- Comment #6 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 13789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13789&action=edit Bug 7882: Add ability to sort fields and subfields This patch incorporates jquery UI sortable to reorder fields when cataloging items in frameworks. To Test: Open Cataloging Choose to add an item using whatever framework you like Click and drag the arrowed fields around. Subfields should not be interchangeable between fields and fields should not be interchangable between tabs When you are done moving and adding information save your item You should notice the marc record saved in the order you arranged the fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Large patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Elliott, Some remarks: 1/ Could you provide a patch with yours modifications and 1 patch for the indentation please ? It is not easy at all to read the patch. 2/ I just have fields on the first tab, the others tabs are empty. 3/ The title for the cursor_split image is wrong ("move up") 4/ the following if statement is not graceful: if(flag){ return StrAlert; } else { return flag; } It could be replaced with if ( flag ) return StrAlert; return 0; Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13789|0 |1 is obsolete| | --- Comment #8 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14202&action=edit Bug 7882: Add ability to sort fields and subfields This patch incorporates jquery UI sortable to reorder fields when cataloging items in frameworks. To Test: Open Cataloging Choose to add an item using whatever framework you like Click and drag the arrowed fields around. Subfields should not be interchangeable between fields and fields should not be interchangable between tabs When you are done moving and adding information save your item You should notice the marc record saved in the order you arranged the fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #9 from Elliott Davis <elliott@bywatersolutions.com> --- (In reply to comment #7)
Hi Elliott,
Some remarks:
1/ Could you provide a patch with yours modifications and 1 patch for the indentation please ? It is not easy at all to read the patch.
2/ I just have fields on the first tab, the others tabs are empty.
I have corrected this issue
3/ The title for the cursor_split image is wrong ("move up")
I corrected this to say move
4/ the following if statement is not graceful: if(flag){ return StrAlert; } else { return flag; } It could be replaced with if ( flag ) return StrAlert; return 0;
This was added with the tab fix. It appears that the file had tabs in it before and when I replaced them with spaces I got more diff than I bargained for.
Marked as Failed QA.
I don't suppose there is any way to let the changes in whitespace slide. I think to correct them I'd have to re-write the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #9)
2/ I just have fields on the first tab, the others tabs are empty.
I have corrected this issue
3/ The title for the cursor_split image is wrong ("move up")
I corrected this to say move
Thanks!
This was added with the tab fix. It appears that the file had tabs in it before and when I replaced them with spaces I got more diff than I bargained for.
You mean your editor automatically replaces tab with 4 spaces when editing a file?
I don't suppose there is any way to let the changes in whitespace slide. I think to correct them I'd have to re-write the patch.
Yes I know it is not easy for this patch. But try to think about that for your next patch :) There is no SO for your patch so I change the status to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #11 from Elliott Davis <elliott@bywatersolutions.com> --- not automatically, but before I found the git whitespace fix from rangi's blog I had it replace tabs with spaces. Thanks for letting it slide this once and sorry for setting it to the wrong status. I assumed that since it was you (Jonathan) it was going through QA. Thats what I get for not looking at the backlog ;) Elliott Davis -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- This appears to be working at first glance, but I see that there is a problem somewhere with the markup, causing the language-switcher menu not to "stick" to the bottom of the screen. This is probably caused by an unclosed <div> somewhere. I hate to say it, but I really think this patch needs to be submitted without all the whitespace changes. addbiblio.pl is a complex page, and not being able to carefully review the relevant changes makes me nervous. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14202|0 |1 is obsolete| | --- Comment #13 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14908&action=edit Bug 7882 [fixed] Rebased on latest master and fixed whitespace issues. Also changed language from "Move Up" to "Move" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Work as described. Tags and subtags could be reordered. But the result is a bit ugly, and there is too much indentation on subtags. That's cosmetic. The trouble I found is that can't collapse or expand tags. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #15 from Elliott Davis <elliott@bywatersolutions.com> --- (In reply to comment #14)
The trouble I found is that can't collapse or expand tags.
Was this existing functionality? I wasn't aware that you could collapse or expand tags before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #16 from Nicole C. Engard <nengard@gmail.com> --- Elliott, Clicking on the description of the tag let you expand or collapse it. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@unilim.fr --- Comment #17 from Frederic Durand <frederic.durand@unilim.fr> --- I ve tried it on a sandbox, it did not work, here s the error message : Applying: Bug 7882 [fixed] Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #17)
I ve tried it on a sandbox, it did not work, here s the error message : Applying: Bug 7882 [fixed] Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
It is not blocker for testing. The patch was correctly applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #19 from Frederic Durand <frederic.durand@unilim.fr> --- I confirm that expand/collapse is off. When you want to modify you can t do it just clicking on it, you need to click the tag or subtag title or on the left of it Remark/question : when you want to drag and move your field you got a yellow area, i suppose it s done to show you where you are going to move? In this case it misses its goal cause it tends to stay on the top. Hope i m not too blurry in my explanations :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14908|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18024&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18024|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18025&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18026&action=edit Bug 7882 - move or reorder 6xx and 7xx fields - Followup - Remove placeholder highlighting This followup removes the yellow placeholder box when moving fields. To me, it looks and behaves far more sensibly without it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18026|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18027&action=edit Bug 7882 - move or reorder 6xx and 7xx fields - Followup - Remove placeholder highlighting This followup removes the yellow placeholder box when moving fields. To me, it looks and behaves far more sensibly without it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #24 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Kyle, I could move subfields but not fields (ej a <-> b, but not 610 <-> 611) Is that the expected behavior? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #24)
Kyle, I could move subfields but not fields (ej a <-> b, but not 610 <-> 611)
That ^ was my mistake. Works as described, but still could not expand or collapse fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Also another side effect is that load time increases: with this patch ~36 sec without ~9 sec -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #27 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 7882 - move or reorder 6xx and 7xx fields Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css Patch failed at 0001 Bug 7882 - move or reorder 6xx and 7xx fields The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18025|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22835&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18027|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22836&action=edit Bug 7882 - move or reorder 6xx and 7xx fields - Followup - Remove placeholder highlighting This followup removes the yellow placeholder box when moving fields. To me, it looks and behaves far more sensibly without it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|elliott@bywatersolutions.co |kyle@bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22835|0 |1 is obsolete| | Attachment #22836|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23517&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images Primary authorship by Elliott Davis. To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com --- Comment #31 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #32 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 23521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23521&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images Primary authorship by Elliott Davis. To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: After applying the patch, I am not able to add value in input text (as if they were readonly, but they are not...). Moreover the commit message indicates that 6xx and 7xx fields will be sortable, but this patch impacts all fields . Note that the page loading increases from 1.76s (onload: 5.19s) to 2.37s (onload: 7.15s) with this patch. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> ---
After applying the patch, I am not able to add value in input text (as if they were readonly, but they are not...).
Can you post some screenshots, or better yet, a video of this issue? I'm not able to reproduce it, but I'm not sure if I'm looking in the right place either.
Moreover the commit message indicates that 6xx and 7xx fields will be sortable, but this patch impacts all fields .
Is this a real issue? That is, I propose we rename the bug to "move and reorder marc fields". I see this as only adding more flexibility to the marc editor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23984&action=edit Bug 7882: Inputs should be editable disableSelection is deprecated and cause an issue on editing an input (input, select, textarea, etc.) see http://api.jqueryui.com/disableselection/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #34)
After applying the patch, I am not able to add value in input text (as if they were readonly, but they are not...).
Can you post some screenshots, or better yet, a video of this issue? I'm not able to reproduce it, but I'm not sure if I'm looking in the right place either.
I did nothing in particular, just open the editor and try to edit an input. Why do you use disableSelection? My patch fixes my issue.
Moreover the commit message indicates that 6xx and 7xx fields will be sortable, but this patch impacts all fields .
Is this a real issue? That is, I propose we rename the bug to "move and reorder marc fields". I see this as only adding more flexibility to the marc editor.
It is not an issue, of course. But it is not what it is written in the commit message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|move or reorder 6xx and 7xx |Add ability to move and |fields |reorder fields in MARC | |editor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23521|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24227&action=edit Bug 7882 - Add ability to move and reorder fields in MARC editor Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images Primary authorship by Elliott Davis. To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23984|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24228&action=edit Bug 7882: Inputs should be editable disableSelection is deprecated and cause an issue on editing an input (input, select, textarea, etc.) see http://api.jqueryui.com/disableselection/ Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- Works as expected. My only concern is about the page loading time. Tested now: Before the patch: 1.12s (onload: 2.62s) 983ms (onload: 2.35s) 1.14s (onload: 2.5s) After the patch: 1.6s (onload: 2.69s) 1.87s (onload: 3.04s) 1.59s (onload: 2.78s) tested with firebug. Maybe we should add a new pref here in order not to increase load time for low/old computers. I let the RM takes the decision. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt@gmail.com --- Comment #40 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #25)
Works as described, but still could not expand or collapse fields.
This is still a problem -- ExpandField() cataloging.js, and possibly other routines, are expecting that subfields are contained in a <div>, not <li>, and would need to be updated. Another thing that gets broken by the patch is the ability to client on the little triangle icons next to each subfield to move them up or down. That should either be made to work, or it should be removed (on account that the subfields become sortable with this patch). I'm failing the patch for those reasons, but they won't be difficult to deal with. There's a more serious issue, however, which isn't caused by this patch but which would become more obvious with it -- if you open the record again in the editor, field order isn't maintained. For example, if you construct your record so that subject headings are in the following order: 650 $aElizabethan theatre 600 $aShakespeare, William then open it up again in the editor, the 600 will be displayed before the 650, even though the 650 field is stored first in the record. This has the potential to be seriously confusing to users, and I feel that a patch that allows sorting of the fields in a user-specified order needs to be accompanied by work that makes the editor display existing fields in the order that they appear in the record. The increase in the time (as measured by Jonathan) it takes to render the editor is unfortunate, but IMO does not quite rise to the level that calls for a new syspref. Now if Bernardo's experience (36 seconds!) were the norm, that would be unacceptably slow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #41 from Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> --- Hi, Someone is still working on it? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins@cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2124 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #42 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Marjorie Barry-Vila from comment #41)
Someone is still working on it?
I wonder the same thing.. turns out that such feature would really come in handy, especially as C4::AuthoritiesMarc::merge() does currently have uncanny tendency to mess up field order in biblio records pretty badly, when authority records are being modified. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org