http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Elliott, Some remarks: 1/ Could you provide a patch with yours modifications and 1 patch for the indentation please ? It is not easy at all to read the patch. 2/ I just have fields on the first tab, the others tabs are empty. 3/ The title for the cursor_split image is wrong ("move up") 4/ the following if statement is not graceful: if(flag){ return StrAlert; } else { return flag; } It could be replaced with if ( flag ) return StrAlert; return 0; Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.