[Bug 17469] New: fr-CA web installer is missing some sample notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Bug ID: 17469 Summary: fr-CA web installer is missing some sample notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: francois.charbonnier@inlibro.com, gmcharlt@gmail.com xt/sample_notice.t fails when you add fr-CA to it, because the file is missing some of the sample notices: Sample notices to add in fr-CA/obligatoire/sample_notices.sql: HOLD_SLIP, MEMBERSHIP_EXPIRY, PASSWORD_RESET Sample notices to delete in fr-CA/obligatoire/sample_notices.sql: RESERVESLIP (was renamed to be HOLD_SLIP!) The file and the test should be fixed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 [Bug 14622] Add fr-CA data folder in the web installer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14622 |5260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 [Bug 5260] Add option to send an order by e-mail to the acquisition module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 [Bug 14622] Add fr-CA data folder in the web installer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|5260 |14622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 [Bug 5260] Add option to send an order by e-mail to the acquisition module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 [Bug 14622] Add fr-CA data folder in the web installer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can't provide a French translation, but especially the missing HOLD_SLIP could be annoying. Proposing a fix in English for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56681&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP Add fr-CA installer to xt/sample_letter.t To test: - Verify sample_notices.sql is correct SQL and loads cleanly - Verify xt/sample_letter.t test checks fr-CA now and runs all tests successfully Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- #!/bin/bash mysql -u root -p < fr-FR.sql > letter-FR.txt mysql -u root -p < fr-CA.sql > letter-CA.txt diff letter-FR.txt letter-CA.txt use koha_library; delete from letter; source /home/mtompset/kohaclone/installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; select module,code,branchcode,is_html,message_transport_type from letter; use koha_library; delete from letter; source /home/mtompset/kohaclone/installer/data/mysql/fr-CA/obligatoire/sample_notices.sql; select module,code,branchcode,is_html,message_transport_type from letter; mtompset@debian:~/kohaclone$ source check_letters.sh Enter password: Enter password: 12d11 < circulation HOLD_SLIP 1 email 19a19
circulation RESERVESLIP 1 email
-- This is the rename Katrin noticed. 24d23 < members MEMBERSHIP_EXPIRY 0 email 26d24 < members PASSWORD_RESET 1 email -- These are the two Katrin noticed missing. 31d28 < reserves HOLD 0 print -- There is one more you may wish to include, Katrin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17577 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Bug 17577 seems to have triggered a conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59019&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP Add fr-CA installer to xt/sample_letter.t To test: - Verify sample_notices.sql is correct SQL and loads cleanly - Verify xt/sample_letter.t test checks fr-CA now and runs all tests successfully Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59019|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59020&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP Add fr-CA installer to xt/sample_letter.t To test: - Verify sample_notices.sql is correct SQL and loads cleanly - Verify xt/sample_letter.t test checks fr-CA now and runs all tests successfully Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56681|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59021&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP Add fr-CA installer to xt/sample_letter.t To test: - Verify sample_notices.sql is correct SQL and loads cleanly - Verify xt/sample_letter.t test checks fr-CA now and runs all tests successfully Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59020|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59022&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Add fr-CA installer to xt/sample_letter.t To test: - Verify xt/sample_letter.t test checks fr-CA now and fails Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59021|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59023&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP TEST PLAN --------- 1) Apply the first patch 2) prove xt/sample_notices.t -- it should fail. 3) Apply the second patch 4) prove xt/sample_notices.t -- it should pass. 5) run all tests (prove t; prove xt) -- they should generally pass 6) run koha qa test tools NOTE: Split test patch from fix patch, so could prove problem exists easily. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59023|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59024&action=edit Bug 17469: Add missing sample notices fr-CA test Add fr-CA installer to xt/sample_letter.t To test: - Verify xt/sample_letter.t test checks fr-CA now and fails for just fr-CA. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59025&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP TEST PLAN --------- 1) Apply the first patch 2) prove xt/sample_notices.t -- it should fail for fr-CA. 3) Apply the second patch 4) prove xt/sample_notices.t -- it should pass. 5) run all tests (prove t; prove xt) -- they should generally pass 6) run koha qa test tools NOTE: Split test patch from fix patch, so could prove problem exists easily. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59022|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Sorry for the excessive messages. I messed up splitting things. Just one this to clean up. As per comment #3: 31d28 < reserves HOLD 0 print -- There is one more you may wish to include, Katrin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59024|0 |1 is obsolete| | --- Comment #13 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59033&action=edit Bug 17469: Add missing sample notices fr-CA test Add fr-CA installer to xt/sample_letter.t To test: - Verify xt/sample_letter.t test checks fr-CA now and fails for just fr-CA. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caitlin Goodger <caitlingoodger.student@wegc.school.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59025|0 |1 is obsolete| | --- Comment #14 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59034&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP TEST PLAN --------- 1) Apply the first patch 2) prove xt/sample_notices.t -- it should fail for fr-CA. 3) Apply the second patch 4) prove xt/sample_notices.t -- it should pass. 5) run all tests (prove t; prove xt) -- they should generally pass 6) run koha qa test tools NOTE: Split test patch from fix patch, so could prove problem exists easily. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caitlin Goodger <caitlingoodger.student@wegc.school.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- The reason I did not sign off was because of comment #3 which was purposefully repeated the outstanding part in comment #12. Sorry but I'm unsigning it. There is still just one this one to clean up. As per comment #3: 31d28 < reserves HOLD 0 print -- There is one more you may wish to include, Katrin. It can be signed off, if there is a good reason to exclude this. However, that wasn't given. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- It's much nicer to not leave it as needs signoff if its not ready for needs signoff. The students and I will try to fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #17 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59048&action=edit Bug 17469: Follow-up adding hold print notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59048 Bug 17469: Follow-up adding hold print notice Review of attachment 59048: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17469&attachment=59048) ----------------------------------------------------------------- Not sure which solution is best and most likely to be accepted by the community. ::: installer/data/mysql/fr-CA/obligatoire/sample_notices.sql @@ +15,4 @@
('orderacquisition','ACQORDER','','Acquisition order',0,'Order','<<aqbooksellers.name>>\r\n<<aqbooksellers.address1>>\r\n<<aqbooksellers.address2>>\r\n<<aqbooksellers.address3>>\r\n<<aqbooksellers.address4>>\r\n<<aqbooksellers.phone>>\r\n\r\nPlease order for the library:\r\n\r\n<order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (quantity: <<aqorders.quantity>>) ($<<aqorders.listprice>> each).</order>\r\n\r\nThank you,\n\n<<branches.branchname>>', 'email'), ('members','ACCTDETAILS','','Modèle de message pour les détails d\'un compte lecteur - DEFAULT',0,'Votre compte Koha','Bonjour <<borrowers.firstname>> <<borrowers.surname>>,\r\n\r\nLes informations pour vous connecter à votre compte lecteur sont :\r\n\r\nIdentifiant : <<borrowers.userid>>\r\nMot de passe: <<borrowers.password>>\r\n\r\nSi vous rencontrez des problèmes ou avez des questions concernant votre compte, veuillez contacter l\'administrateur de Koha.\r\n\r\nMerci, \r\nL\'administrateur de Koha\r\nkohaadmin@yoursite.org','email'), ('reserves','HOLD','','Réservation en attente de retrait',0,'Réservation en attente de retrait à <<branches.branchname>>','Bonjour <<borrowers.firstname>> <<borrowers.surname>>,\r\n\r\nVotre réservation est disponible depuis le <<reserves.waitingdate>> :\r\n\r\nTitre : <<biblio.title>>\r\nAuteur : <<biblio.author>>\r\nCopie : <<items.copynumber>>\r\nLocalisation : <<branches.branchname>>\r\n<<branches.branchaddress1>>\r\n<<branches.branchaddress2>>\r\n<<branches.branchaddress3>>\r\n<<branches.branchcity>> <<branches.branchzip>>\r\n\r\nNous vous invitons à venir emprunter votre document rapidement.\r\n\r\nMerci.\r\n\r\n<<branches.branchname>>','email'), +('reserves', 'HOLD', 'Réservation disponible pour retrait', 'Réservation disponible à la banque de retrait du site <<branches.branchname>>', '<<branches.branchname>>\n<<branches.branchaddress1>>\n<<branches.branchaddress2>>\n\n\nLe service des réservations\n\n\n\n\n\n\n\n<<borrowers.firstname>> <<borrowers.surname>>\n<<borrowers.address>>\n<<borrowers.city>> <<borrowers.zipcode>>\n\n\n\n\n\n\n\n\n\n\n<<borrowers.firstname>> <<borrowers.surname>> <<borrowers.cardnumber>>\n\nVotre réservation est disponible pour retrait depuis le <<reserves.waitingdate>>:\r\n\r\nTitre: <<biblio.title>>\r\nAuteur: <<biblio.author>>\r\nNuméro de fascicule: <<items.copynumber>>\r\n', 'print'),
Good try, but '' and 0 are missing, as the field lists between the fr-FR and fr-CA differ. A separate INSERT statement would be better, if you are going to cut and paste. Otherwise, make sure the fields line up. Another cut-and-paste idea would be just to copy the email HOLD above, and change it to 'print' on the end. I am sure the folks pushing for this will submit a fix on another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59048|0 |1 is obsolete| | --- Comment #19 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59100&action=edit Bug 17469: Follow-up adding hold print notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Caitlin, thx for rescuing this puppy (... or camel? :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59033|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 59125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59125&action=edit Bug 17469: Add missing sample notices fr-CA test Add fr-CA installer to xt/sample_letter.t To test: - Verify xt/sample_letter.t test checks fr-CA now and fails for just fr-CA. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caitlin Goodger <caitlingoodger.student@wegc.school.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 59126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59126&action=edit [SIGNED OFF] Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP TEST PLAN --------- 1) Apply the first patch 2) prove xt/sample_notices.t -- it should fail for fr-CA. 3) Apply the second patch 4) prove xt/sample_notices.t -- it should pass. 5) run all tests (prove t; prove xt) -- they should generally pass 6) run koha qa test tools NOTE: Split test patch from fix patch, so could prove problem exists easily. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caitlin Goodger <caitlingoodger.student@wegc.school.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 59127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59127&action=edit [SIGNED OFF] Bug 17469: Follow-up adding hold print notice Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Signed off on the follow-ups - thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Well done Caitlin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer@bsz-bw.de |caitlingoodger.student@wegc | |.school.nz CC| |caitlingoodger.student@wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does not work for me: sudo koha-mysql kohadev < installer/data/mysql/fr-CA/obligatoire/sample_notices.sql ERROR 1062 (23000) at line 1: Duplicate entry 'circulation-CHECKIN--email' for key 'PRIMARY' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59125|0 |1 is obsolete| | Attachment #59126|0 |1 is obsolete| | Attachment #59127|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59246&action=edit Bug 17469: Add missing sample notices fr-CA test Add fr-CA installer to xt/sample_letter.t To test: - Verify xt/sample_letter.t test checks fr-CA now and fails for just fr-CA. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caitlin Goodger <caitlingoodger.student@wegc.school.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59247&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP TEST PLAN --------- 1) Apply the first patch 2) prove xt/sample_notices.t -- it should fail for fr-CA. 3) Apply the second patch 4) prove xt/sample_notices.t -- it should pass. 5) run all tests (prove t; prove xt) -- they should generally pass 6) run koha qa test tools NOTE: Split test patch from fix patch, so could prove problem exists easily. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Caitlin Goodger <caitlingoodger.student@wegc.school.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59248&action=edit Bug 17469: Follow-up adding hold print notice Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59249&action=edit Bug 17469: Fix number of values Will fix ERROR 1136 (21S01) at line 57: Column count doesn't match value count at row 2 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #26)
Does not work for me:
sudo koha-mysql kohadev < installer/data/mysql/fr-CA/obligatoire/sample_notices.sql ERROR 1062 (23000) at line 1: Duplicate entry 'circulation-CHECKIN--email' for key 'PRIMARY'
Fixed with the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 17.05, thanks Katrin, Caitlin, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.02. . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #34 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org