[Bug 28180] New: Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Bug ID: 28180 Summary: Use a lightbox gallery to display the images - detail page, OPAC interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 28179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119918&action=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119919&action=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119920&action=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119921&action=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119922&action=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119923&action=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119924&action=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119918|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 120444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120444&action=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119919|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 120445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120445&action=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119920|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 120446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120446&action=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119921|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 120447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120447&action=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119922|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 120448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120448&action=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119923|0 |1 is obsolete| | --- Comment #13 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 120449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120449&action=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119924|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 120450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120450&action=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120444|0 |1 is obsolete| | Attachment #120445|0 |1 is obsolete| | Attachment #120446|0 |1 is obsolete| | Attachment #120447|0 |1 is obsolete| | Attachment #120448|0 |1 is obsolete| | Attachment #120449|0 |1 is obsolete| | Attachment #120450|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120464&action=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120465&action=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120466&action=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120467&action=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120468&action=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120469&action=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120470&action=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Signed-off-by patches attached on behalf of the sponsor. The sandbox's signoff process picked the name of the creator of the sandbox instead of the one filled in on the signoff form. Also, the status has not been adjusted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am seeing a failure in the QA script, can you please check: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters FAIL forbidden patterns forbidden pattern: console.log (line 1754) Also and more importantly, with this patch covers on result list are broken: Uncaught ReferenceError: NO_LOCAL_JACKET is not defined GetCoverFromBibnumber http://localhost:8080/opac-tmpl/bootstrap/js/localcovers_20.1200047.js:25 jQuery 2 GetCoverFromBibnumber http://localhost:8080/opac-tmpl/bootstrap/js/localcovers_20.1200047.js:21 <anonymous> http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=perl&weight_search=1:3137 jQuery 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120753&action=edit Bug 28180: (follow-up) Remove console.log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120754&action=edit Bug 28180: Restore NO_LOCAL_JACKET This is a patch to squash. No idea what it got removed previously -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #23) Both fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120805&action=edit Bug 28180: (follow-up) Updates to styling of lightbox controls This patch adds style changes like the ones made in Bug 28179. It also addresses a bug with the way the verify_images() function was firing. I've moved the function outside of document.ready() and added a call to it on window load, consistent with how it works in the staff client. I've removed a redundant call to verify_images() from the footer include file, opac-bottom.inc. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120805|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122783&action=edit Bug 28180: (follow-up) Updates to styling of lightbox controls This patch adds style changes like the ones made in Bug 28179. It also addresses a bug with the way the verify_images() function was firing. I've moved the function outside of document.ready() and added a call to it on window load, consistent with how it works in the staff client. I've removed a redundant call to verify_images() from the footer include file, opac-bottom.inc. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122784&action=edit Bug 28180: CSS changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Your follow-up is working great, Owen. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please fix the conflicts? Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css M koha-tmpl/opac-tmpl/bootstrap/css/opac.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css error: Failed to merge in the changes. Patch failed at 0001 Bug 28180: CSS changes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #31)
Can you please fix the conflicts?
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css
Those are conflicts on the "Compiled CSS patch". The patch can be skipped and the patch regenerated with "yarn build && yarn build --view=opac" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122784|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123178&action=edit Bug 28180: CSS changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right, I was a little too fast. But why include them in the first place? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #34)
You are right, I was a little too fast. But why include them in the first place?
To ease testing, especially for sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #35)
(In reply to Katrin Fischer from comment #34)
You are right, I was a little too fast. But why include them in the first place?
To ease testing, especially for sandboxes.
You can now do the yarn build bit on the sandboxes, but of course not everybody might know that. I was more thinking about the conflicts causing problems there. There is always something that can go wrong I guess :) I shoudl have taken a better look here at the conflict anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe there might be some problematic constructions for translation in the JavaScript, but need to investigate further: lightbox_descriptions.push("Custom cover image"); lightbox_descriptions.push(_("Image from Google Books (<a href='%s'>see the original image</a>)").format($(img).data('link'))); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One more: img.alt = "Cover image"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use a lightbox gallery to |Use a lightbox gallery to |display the images - detail |display the images on the |page, OPAC interface |detail pages in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is something weird, if multiple cover providers are activated: - Turn on OpenLibrary covers - Turn on Amazon covers - Search for "perl" - Most books will show 2 covers in results and in the detail pages - Example: CGI programming with Perl - Turn on Google covers - Result list shows 3 - Detail page: only Amazon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #37)
I believe there might be some problematic constructions for translation in the JavaScript, but need to investigate further:
lightbox_descriptions.push("Custom cover image"); lightbox_descriptions.push(_("Image from Google Books (<a href='%s'>see the original image</a>)").format($(img).data('link')));
They appear to work, at least seeing the strings in the po file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please check comment#39. Also: 1) Link to source At the bottom of the lightbox view it says: [provider] cover image (see the original image) I wonder if we could make it clearer here that we are linking to the provider's page as this is an external link where you will leave the library's website. And it won't only be the image you get to. Maybe something along the lines of: (see the original image on the [provider]'s website) A native speaker might come up with a better wording :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #39)
There is something weird, if multiple cover providers are activated:
- Turn on OpenLibrary covers - Turn on Amazon covers - Search for "perl" - Most books will show 2 covers in results and in the detail pages - Example: CGI programming with Perl - Turn on Google covers - Result list shows 3 - Detail page: only Amazon
Found it! There is 2 functions "verify_images", and one (the existing one) is coming from amazonimages.js! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123790&action=edit Bug 28180: Fix collision with existing verify_images At the OPAC we already had a verify_images JS function in amazonimages.js It's preferable to use another function name. This patch replace our verify_images with verify_cover_images and apply the change to the staff code as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123792&action=edit Bug 28180: Fix some non-translatable strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123790|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123793&action=edit Bug 28180: Fix collision with existing verify_images At the OPAC we already had a verify_images JS function in amazonimages.js It's preferable to use another function name. This patch replace our verify_images with verify_cover_images and apply the change to the staff code as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's a problem in master as well (staff-side) and highlighted at the OPAC as we have more images coming from external providers. The code to hide the non-existent images does not work as we expect. In my case, a new laptop (faster) make the problem more obvious, the JS code is processed faster than before and we remove the div that contain images from amazon, google, etc. because the images are not loaded yet. I think we should fix that on a separate bug report to fix the staff side at the same time. And obviously this new enhancement won't be pushed until it's fixed. You can continue testing with the following (non optimal) patch: diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 03f41fe8317..93b3c682f61 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1620,7 +1620,7 @@ } } } else { - div.remove(); + //div.remove(); } }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123794&action=edit Bug 28180: Correctly guess if images have been loaded window.load won't assure us that the images loaded using JS code are correctly loaded. This patch adds a flag to the different providers when the images are fully loaded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think this patch is the way to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches still apply, CSS changes need to be rebuilt with `yarn build --view=opac` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches still apply, but something has been broken since my last test run. What I did so far: - Made sure master was current - restart_all, ran database updates - Applied patches, no conflicts - restart_all again - yarn build --view opac 1) Turned on Adlibris covers. Instead of the covers, only a link shows in the result list and detail pages. 2) Additionally activated Google covers. The covers show, but not within the lightbox display. 3) Added Amazon covers Now I see up to 2 covers, but next to each other, still no lightbox. Did a patch get lost here? :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I later realized that this was not meant to change results, but only the detail page. Previous comments apply to the results list. On the detail page for me none of the 3 mentioned cover services covers show :( Example: search for "perl" > Programming Perl - 2 covers and the adlibris link on results - no cover at all on detail page Switch back to master, git stash, restart_all: - Adlibris still broken on results - covers show on results and detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124819&action=edit Bug 28180: Fix bug with AdLibris If Adlibris is first and there is no image -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hi Katrin, thanks! You found a bug in a very specific combination. AdLibris is loaded first but there is no image there (is the service broken currently?). The code copied from staff is broken. As we have much more cover services OPAC side the bugs are easier to catch. I think this last patch is improving the situation but I cannot guarantee it will always work. To be honest I've always tested with local cover images (as it's why this enhancement has been sponsored), and it was always working when a cover image is attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124819|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125666&action=edit Bug 28180: Fix bug with AdLibris If Adlibris is first and there is no image -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Finally back to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am very sorry, but I think I found another inconsistency: CustomCoverImages LocalCoverImages AllowMultipleCovers GoogleJackets 1) On the results page: CustomCover (a random image url), local cover and Google cover. 2) Switch to detail page: Only custom and local cover show. 3) Reload page with F5: Google cover appears. Same test plan applies to results without a local cover. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same behaviour when using the "next" button for navigating between the results, initial page load is always without the Google cover. Requires an explicit refresh. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hi Katrin, I don't recreate the problem you have. I've create a sandbox with your settings: https://opac-bz28180.sandboxes.biblibre.eu/cgi-bin/koha/opac-search.pl?idx=&q=perl&weight_search=1 "Perl DBI" has a local cover image (biblionumber=13). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What you describe make me think the JS cache was not cleared. With this change we have a problem when there is no custom image (for instance), as we don't longer test the height of the images. When the custom image won't exist, the cover slider will display an empty slide for the custom image. But this won't be easy to fix (we cannot have the previous patch "Bug 28180: Fix bug with AdLibris" AND keep the current behavior). It works for the staff interface because we don't have all those services, but the code is not working correctly for OPAC. I would not consider it a blocker. But what you describe is not expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure I fully understand your comment, but I think this is a real regression that will get unhappy comments. Google images are supposedly widely used and they disappear from the detail pages now :( In my test case there always was a custom image - do you mean local? It happened for the record with the local image too - I had 3 shown in results and only 2 missing Google) in the detail page. So not sure that's the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123794|0 |1 is obsolete| | Attachment #125666|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126041&action=edit Bug 28180: Correctly guess if images have been loaded window.load won't assure us that the images loaded using JS code are correctly loaded. This patch adds a flag to the different providers when the images are fully loaded. Note that the img.naturalHeight check is not working for google jackets and is actually not needed (test with a bib record with and without google jacket and confirm that it's working as expected). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126042&action=edit Bug 28180: Fix bug with AdLibris If Adlibris is first and there is no image -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #63 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #60)
I am not sure I fully understand your comment, but I think this is a real regression that will get unhappy comments. Google images are supposedly widely used and they disappear from the detail pages now :(
In my test case there always was a custom image - do you mean local? It happened for the record with the local image too - I had 3 shown in results and only 2 missing Google) in the detail page. So not sure that's the issue.
I did recreate on Firefox, not chrome (usually using Firefox, but the cache didn't want to clear correctly this morning when I tried). That should be fixed now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200 [Bug 29200] Remove Adlibris cover service -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120464|0 |1 is obsolete| | Attachment #120465|0 |1 is obsolete| | Attachment #120466|0 |1 is obsolete| | Attachment #120467|0 |1 is obsolete| | Attachment #120468|0 |1 is obsolete| | Attachment #120469|0 |1 is obsolete| | Attachment #120470|0 |1 is obsolete| | Attachment #120753|0 |1 is obsolete| | Attachment #120754|0 |1 is obsolete| | Attachment #122783|0 |1 is obsolete| | Attachment #123792|0 |1 is obsolete| | Attachment #123793|0 |1 is obsolete| | Attachment #126041|0 |1 is obsolete| | Attachment #126042|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126506&action=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126507&action=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126508&action=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126509&action=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126510&action=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #69 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126511&action=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126512&action=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126513&action=edit Bug 28180: (follow-up) Remove console.log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126514&action=edit Bug 28180: Restore NO_LOCAL_JACKET This is a patch to squash. No idea what it got removed previously -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126515&action=edit Bug 28180: (follow-up) Updates to styling of lightbox controls This patch adds style changes like the ones made in Bug 28179. It also addresses a bug with the way the verify_images() function was firing. I've moved the function outside of document.ready() and added a call to it on window load, consistent with how it works in the staff client. I've removed a redundant call to verify_images() from the footer include file, opac-bottom.inc. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #74 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126516&action=edit Bug 28180: Fix some non-translatable strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126517&action=edit Bug 28180: Fix collision with existing verify_images At the OPAC we already had a verify_images JS function in amazonimages.js It's preferable to use another function name. This patch replace our verify_images with verify_cover_images and apply the change to the staff code as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126518&action=edit Bug 28180: Correctly guess if images have been loaded window.load won't assure us that the images loaded using JS code are correctly loaded. This patch adds a flag to the different providers when the images are fully loaded. Note that the img.naturalHeight check is not working for google jackets and is actually not needed (test with a bib record with and without google jacket and confirm that it's working as expected). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126519&action=edit Bug 28180: Fix bug with first image does not exist This was first written for Adlibris, before its removal from the codebase. But this patch maybe still be useful for other services (if first and no image). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #78 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126520&action=edit Bug 28180: Remove adlibris conflict Can be squashed when pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rebased on top of bug 29200. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126506|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126596&action=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126507|0 |1 is obsolete| | --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126597&action=edit Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC interface This patch is the OPAC version of Bug 28179: Add a lightbox gallery to display cover images - detail page, staff interface But there were several difficulties as the staff and OPAC code diverged a lot. First we are going to apply the different enhancements that have been made staff-side: - Display all the local cover image on the bibliographic detail pages (before this patch only the first one was displayed) - The slider functionality added by bug 25031 Test plan: All the cover images are affected, all the different sources will be tested. All the steps will be done on the same bibliographic record. 1. Local cover images a. Turn on OPACLocalCoverImages and AllowMultipleCover b. Add several local cover images to a bibliographic record c. Add several local cover images to an item d. Click on an image and confirm that it is displayed in a gallery and you can navigate see all the images attached to the bibliographic record e. Same for items 2. Adlibris a. Turn on AdlibrisCoversEnabled b. Edit the biliographic record and add an ISBN that will return a cover image for this service (9780670026623 for instance) c. Display the cover images in the gallery d. Note the link to the adlibris.com website at the bottom 3. Amazon a. Turn on OPACAmazonCoverImages b. Display the cover images in the gallery 4. Coce a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080" and select some values for CoceProviders. b. Display the cover images in the gallery 5. Custom cover images a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg of anything else meaningful b. Display the cover images in the gallery QA Note: Other sources have been removed by this patch but will be re-added by follow-ups Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126508|0 |1 is obsolete| | --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126598&action=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126509|0 |1 is obsolete| | --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126599&action=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126510|0 |1 is obsolete| | --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126600&action=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126511|0 |1 is obsolete| | --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126601&action=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126512|0 |1 is obsolete| | --- Comment #86 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126602&action=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Rasmus Leißner <rasmus.leissner@solutions-factory.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126513|0 |1 is obsolete| | --- Comment #87 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126603&action=edit Bug 28180: (follow-up) Remove console.log Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126514|0 |1 is obsolete| | --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126604&action=edit Bug 28180: Restore NO_LOCAL_JACKET This is a patch to squash. No idea what it got removed previously Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126515|0 |1 is obsolete| | --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126605&action=edit Bug 28180: (follow-up) Updates to styling of lightbox controls This patch adds style changes like the ones made in Bug 28179. It also addresses a bug with the way the verify_images() function was firing. I've moved the function outside of document.ready() and added a call to it on window load, consistent with how it works in the staff client. I've removed a redundant call to verify_images() from the footer include file, opac-bottom.inc. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126516|0 |1 is obsolete| | --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126606&action=edit Bug 28180: Fix some non-translatable strings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126517|0 |1 is obsolete| | --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126607&action=edit Bug 28180: Fix collision with existing verify_images At the OPAC we already had a verify_images JS function in amazonimages.js It's preferable to use another function name. This patch replace our verify_images with verify_cover_images and apply the change to the staff code as well. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126518|0 |1 is obsolete| | --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126608&action=edit Bug 28180: Correctly guess if images have been loaded window.load won't assure us that the images loaded using JS code are correctly loaded. This patch adds a flag to the different providers when the images are fully loaded. Note that the img.naturalHeight check is not working for google jackets and is actually not needed (test with a bib record with and without google jacket and confirm that it's working as expected). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126519|0 |1 is obsolete| | --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126609&action=edit Bug 28180: Fix bug with first image does not exist This was first written for Adlibris, before its removal from the codebase. But this patch maybe still be useful for other services (if first and no image). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126520|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126610&action=edit Bug 28180: Remove adlibris conflict Can be squashed when pushed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #95 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Bug 28180 depends on bug 29200, which changed state. Bug 29200 Summary: Remove Adlibris cover service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29200 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords|release-notes-needed | Text to go in the| |This enhancement to the release notes| |OPAC enables the display of | |multiple cover images on | |the detail page for a | |record in a light box. | |Previously only one image | |was displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to the |This enhancement to the release notes|OPAC enables the display of |OPAC enables the display of |multiple cover images on |multiple cover images on |the detail page for a |the detail page for a |record in a light box. |record or items in a |Previously only one image |gallery. |was displayed. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe another candidate for 'new feature'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26933 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31207 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31207 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 [Bug 31207] The OPAC Shelf browser fails to display local cover images -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217 [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal@gmail.com --- Comment #97 from David Cook <dcook@prosentient.com.au> --- *** Bug 7709 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmkale@anantcorp.com --- Comment #98 from David Cook <dcook@prosentient.com.au> --- *** Bug 7187 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31446 [Bug 31446] Optionally hide lightbox_descriptions from OPAC lightbox gallery -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35633 [Bug 35633] Upgrade Chocolat JS library from v1.1.0 to v1.1.2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 [Bug 36966] Fix links for local cover images for items on staff detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36966 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36966 [Bug 36966] Fix links for local cover images for items on staff detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41078 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org