[Bug 15076] New: Remove file misc/maintenance/fix_accountlines_date.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Bug ID: 15076 Summary: Remove file misc/maintenance/fix_accountlines_date.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org The file misc/maintenance/fix_accountlines_date.pl seems to be a file used for an update, could it be obsolete? If yes, it can be removed. See discussion on Bug 14998 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998#c5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14998 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 [Bug 14998] Remove C4::Dates from installer and maintenance folders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about removing it - it might still be useful for people updating from really old versions or something like that. Can we find out more about the context of when this was added? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |jweaver@bywatersolutions.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- commit bf4a39d7ce3d7618d6afe1cec6cc5d5b55885abe Author: Jesse Weaver <jesse.weaver@liblime.com> Date: Mon Jul 14 12:15:14 2008 -0500 new script to fix date code in accountlines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14998 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 [Bug 14998] Remove C4::Dates from installer and maintenance folders -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I'd be inclined to remove it at this point. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 44955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44955&action=edit Bug 15076: Remove file misc/maintenance/fix_accountlines_date.pl This patch removes the file misc/maintenance/fix_accountlines_date.pl To test: - Verify that the file is removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14870 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14870 --- Comment #5 from Marc Véron <veron@veron.ch> --- Independently on removal, the file does no longer block 14870, moved from "Blocks" to "See also" Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Because overdue fines include title and original due date in the description, and because UpdateFine matches on the due date in the description when finding an existing account line to update... this script would still be a useful thing to run if ever a library decides to change the dateformat system preference. Of course, changing the dateformat is not a common decision. My vote: keep this script until such time as Koha no longer relies on matching dates in the description to find accountlines to update when adjusting an overdue fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13104 --- Comment #7 from Marc Véron <veron@veron.ch> --- (In reply to Galen Charlton from comment #6)
Because overdue fines include title and original due date in the description, and because UpdateFine matches on the due date in the description when finding an existing account line to update... this script would still be a useful thing to run if ever a library decides to change the dateformat system preference.
Of course, changing the dateformat is not a common decision.
My vote: keep this script until such time as Koha no longer relies on matching dates in the description to find accountlines to update when adjusting an overdue fine.
Hi Galen, So I think we would have to make this bug dependent of a bug that resolves the issue. Is there a bug about the issue regarding matching dates? I only found: Bug 13104 - Changing date or time format on a production server will create duplicate fines! (It adds the note about duplicate fines to the syspref 'dateformat') Bug 12188 - fines duplicated after changing dateformat (Resolved - duplicate of 13104) I tried to find out where in the code the duplication happens, but I had no success. Any hint is welcome. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12188 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it happens when the system has to decide wether to update an existing fine or to add a new fine. Take a look at the UpdateFines routine: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Overdues.pm;hb=... I think this isn't easy to fix/change right now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marc Véron from comment #7)
(In reply to Galen Charlton from comment #6)
Of course, changing the dateformat is not a common decision.
We just introduced a new dateformat (DD.MM.YYYY), so I think some switching will happen soon, at least for installations in some areas :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15310 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15312 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org